Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

patches to fix duplicates track problem in upgrade geometry #3051

Merged
merged 3 commits into from Mar 31, 2014

Conversation

cerati
Copy link
Contributor

@cerati cerati commented Mar 27, 2014

patches to fix duplicates track problem in upgrade geometry

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @cerati for CMSSW_6_2_X_SLHC.

patches to fix duplicates track problem in upgrade geometry

It involves the following packages:

RecoTracker/CkfPattern
RecoTracker/TkDetLayers

@nclopezo, @cmsbuild, @anton-a, @thspeer, @slava77, @Degano can you please review it and eventually sign? Thanks.
@ghellwig, @gpetruc, @GiacomoSguazzoni, @rovere, @venturia this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@andersonjacob, @mark-grimes you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@andersonjacob
Copy link
Contributor

This one isn't merging. It is complaining about PixelBlades.cc. It looks like @boudoul made the same changes last week. If there are additional changes can you rebase on the latest head and then push that to this branch to resolve the merge conflicts.

@cerati
Copy link
Contributor Author

cerati commented Mar 30, 2014

there are additional changes, so I rebased and merged

@cmsbuild
Copy link
Contributor

Pull request #3051 was updated. @nclopezo, @cmsbuild, @anton-a, @thspeer, @slava77, @Degano can you please check and sign again.

@mark-grimes
Copy link

merge

Merges fine after rebase, only known problems when testing.
Tests 10000, 10200, 10400, 11200, 11400, 11600, 11800, 12000, 12800 and 13000 pass all steps.
Tests 12200, 12400, 12600, 13200 and 13400 fail in step 2 with known errors.

cmsbuild added a commit that referenced this pull request Mar 31, 2014
patches to fix duplicates track problem in upgrade geometry
@cmsbuild cmsbuild merged commit 14924bd into cms-sw:CMSSW_6_2_X_SLHC Mar 31, 2014
makortel referenced this pull request in makortel/cmssw Dec 9, 2014
Code commented with annotation
"fixme gc patched for SLHC - skip this check to avoid overlaps (to be tested for standard geom)"
makortel referenced this pull request in makortel/cmssw Dec 9, 2014
Couple of the changes annotated with
"fixme gc patched for SLHC - force order here to be in z"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants