Phase2 L1 ParticleFlow #30510
Merged
Phase2 L1 ParticleFlow #30510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hase2 L1T sequence.
…or TriggerPrimitives, L1T , and L1T that depend on TrackTrigger tracks.
|
The code-checks are being triggered in jenkins. |
|
please test |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30510/16712
|
|
The tests are being triggered in jenkins.
|
|
A new Pull Request was created by @silviodonato (Silvio Donato) for master. It involves the following packages: L1Trigger/Configuration @cmsbuild, @rekovic, @benkrikler, @kpedro88 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
It crashes at |
|
-1 Tested at: 8738603 CMSSW: CMSSW_11_2_X_2020-07-02-1100 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
You can see more details here: You can see the results of the tests here: I found follow errors while testing this PR Failed tests: RelVals
When I ran the RelVals I found an error in the following workflows: runTheMatrix-results/20434.0_TTbar_14TeV+TTbar_14TeV_TuneCP5_2026D41_GenSimHLBeamSpotFull14+DigiFullTrigger_2026D41+RecoFullGlobal_2026D41+HARVESTFullGlobal_2026D41/step2_TTbar_14TeV+TTbar_14TeV_TuneCP5_2026D41_GenSimHLBeamSpotFull14+DigiFullTrigger_2026D41+RecoFullGlobal_2026D41+HARVESTFullGlobal_2026D41.log23234.0 step2 runTheMatrix-results/23234.0_TTbar_14TeV+TTbar_14TeV_TuneCP5_2026D49_GenSimHLBeamSpotFull14+DigiFullTrigger_2026D49+RecoFullGlobal_2026D49+HARVESTFullGlobal_2026D49/step2_TTbar_14TeV+TTbar_14TeV_TuneCP5_2026D49_GenSimHLBeamSpotFull14+DigiFullTrigger_2026D49+RecoFullGlobal_2026D49+HARVESTFullGlobal_2026D49.log The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
You can see more details here: |
|
Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped) |
|
The tests are being triggered in jenkins.
|
|
Pull request #30510 was updated. @cmsbuild, @rekovic, @benkrikler, @kpedro88 can you please check and sign again. |
Closed
|
+1 |
|
Comparison job queued. |
|
merge |
|
Comparison is ready Comparison Summary:
|
@rekovic please have a look, was it expected? |
|
I don't understand this. This PR should be only making extra Phase2 L1T products not used anywhere at the moment, but intended to be used by the future Phase2 HLT. DQM should not be affected. |
|
But perhaps this level of disagreement in comparison (7730 failed / 2776340 successes) is tolerable and is not an indication of true changes introduced. |
No, it really isn't. |
|
I agree with Kevin. |
|
Diff of dumps of step1 of 5.1_TTbar+TTbarFS+HARVESTFS: same thing for all other process.akXXPFJetsYY |
silviodonato
commented
Jul 3, 2020
| l1PFMets = cms.Sequence(l1PFMetCalo + l1PFMetPF + l1PFMetPuppi) | ||
|
|
||
| from RecoJets.JetProducers.ak4PFJets_cfi import ak4PFJets as _ak4PFJets | ||
| _ak4PFJets.doAreaFastjet = False |
There was a problem hiding this comment.
I think the problem is here @rekovic
There was a problem hiding this comment.
This is certainly a problem. Configuration objects should be modified only in the files that define them (and we really should clean up all the bad examples in Configuration/StandardSequences/python).
|
ok, indeed i was looking at the plots, and the area seems the only one NOT
compatible with some decent level fluctuations ...
was this setting changes in some PF modifiers ?
…On Fri, Jul 3, 2020 at 3:15 PM Silvio Donato ***@***.***> wrote:
Diff of dumps of step1 of 5.1_TTbar+TTbarFS+HARVESTFS:
@@ -98048,7 +98048,7 @@ process.ak4PFJets = cms.EDProducer("FastjetJetProducer",
Rho_EtaMax = cms.double(4.4),
applyWeight = cms.bool(False),
doAreaDiskApprox = cms.bool(False),
- doAreaFastjet = cms.bool(True),
+ doAreaFastjet = cms.bool(False),
doPUOffsetCorr = cms.bool(False),
doPVCorrection = cms.bool(False),
doRhoFastjet = cms.bool(False),
@@ -98483,6 +98483,45 @@ process.ak4PFJetsSK = cms.EDProducer("FastjetJetProducer",
)
same thing for all other process.akXXPFJetsYY
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#30510 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AA7HMYK3GGE2PHMXIGZEAHDRZXKVHANCNFSM4OPC5PUA>
.
--
Tommaso Boccali
INFN Pisa
|
makortel
reviewed
Jul 3, 2020
| import FWCore.ParameterSet.Config as cms | ||
|
|
||
| from RecoMET.METProducers.pfMet_cfi import pfMet as _pfMet | ||
| _pfMet.calculateSignificance = False |
There was a problem hiding this comment.
This is a problem as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #30482.
PR description:
New Package - Phase2 L1 ParticleFlow
This is a rebase of #30256, with addressed all comments and removed data files.
This PR adds the ParticleFlow based modules are added to the Phase2 L1T Sequence. We distinguish the (a) Lower-level objects, which are inputs to (b) Higher-level objects that are (can be) used in the L1T Menu.
(a) Lower-level objects:
(b) Higher-level objects, that are (can be) used in the L1T Menu:
In this PR, we use phase2_trackerV14 modifier to enable in the sequence the phase2 L1T modules that depend on TrackTriggerTracks. This solution effectively means that the central workflows earlier than era Phase2C9 will not execute these modules (neither will TrackTrigger TrackFinderTrack module)
The reason for this is that the Hybrid TrackTriggerTrackFinder at the moment cannot run on geometries earlier that Tracker v14, and are enabled via the same modifier only in eras Phase2C9 and later.
Still to do
Phase1 PF jets
from L1Trigger.L1CaloTrigger.Phase1L1TJets_cff import *
_phase2_siml1emulator.add(Phase1L1TJetsTask)
However, in this ParticleFlow package we already have the jets ak4PFL1PuppiCorrected that could be used in principle. Although these were not used in the Menu of the L1T TDR, the two have a vary similar performance. The plan is, if possible to include the Phase1 PFJets is time permits, to be fully consistent with the L1T TDR.