Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use --customise instead of --customise_unsc in TestOldDigi workflow #30536

Merged

Conversation

silviodonato
Copy link
Contributor

PR description:

Use --customise instead of --customise_unsc in TestOldDigi workflow

PR validation:

From python dump of 23234.1001 step1:

Without PR

process.L1TrackTrigger_step = cms.Path(cms.Task(process.TTClusterAssociatorFromPixelDigis, process.TTClustersFromPhase2TrackerDigis, process.TTStubAssociatorFromPixelDigis, process.TTStubsFromPhase2TrackerDigis, process.TTTrackAssociatorFromPixelDigis, process.TTTrackAssociatorFromPixelDigisExtended, process.TTTracksFromExtendedTrackletEmulation, process.TTTracksFromTrackletEmulation, process.TrackerDTCProducer, process.offlineBeamSpot))

With PR

process.L1TrackTrigger_step = cms.Path(cms.Task(process.TTClustersFromPhase2TrackerDigis, process.TTStubsFromPhase2TrackerDigis, process.TTTracksFromExtendedTrackletEmulation, process.TTTracksFromTrackletEmulation, process.TrackerDTCProducer, process.offlineBeamSpot))

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 3, 2020

The code-checks are being triggered in jenkins.

@silviodonato
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 3, 2020

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30536/16764

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 3, 2020

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 3, 2020

A new Pull Request was created by @silviodonato (Silvio Donato) for master.

It involves the following packages:

Configuration/PyReleaseValidation

@chayanit, @cmsbuild, @wajidalikhan, @pgunnell, @kpedro88 can you please review it and eventually sign? Thanks.
@makortel, @Martin-Grunewald, @fabiocos, @slomeo this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 4, 2020

+1
Tested at: af1c9e2
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-077cd4/7689/summary.html
CMSSW: CMSSW_11_2_X_2020-07-03-2300
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 4, 2020

Comparison job queued.

@silviodonato
Copy link
Contributor Author

merge

@cmsbuild cmsbuild merged commit 498fe5f into cms-sw:master Jul 4, 2020
@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 4, 2020

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-077cd4/7689/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 37
  • DQMHistoTests: Total histograms compared: 2784120
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2784069
  • DQMHistoTests: Total skipped: 50
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 36 files compared)
  • Checked 154 log files, 17 edm output root files, 37 DQM output files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants