Pixel template making code update #30563

tvami · 2020-07-06T21:36:32Z

PR description:

Move the codes that are used to create the (2D)Template and GenErr objects to central CMSSW (instead of living on individual github accounts)

PR validation:

in CondTools/SiPixel/test

cmsRun SiPixelTemplateDBObjectUploader_cfg.py Fullname=SiPixelTemplateDBObject_phase1_0T_mc_BoR3_v1_bugfix Map=../data/SiPixelTemplateDBObject_0T_phase1_BoR3_v1/mapping.csv TemplateFilePath=CondTools/SiPixel/data/SiPixelTemplateDBObject_0T_phase1_BoR3_v1

and

cmsRun SiPixelGenErrorDBObjectUploader_cfg.py Fullname=SiPixelGenErrorDBObject_phase1_0T_mc_BoR3_v1_bugfix Map=../data/SiPixelTemplateDBObject_0T_phase1_BoR3_v1/mapping.csv GenErrFilePath=CondTools/SiPixel/data/SiPixelTemplateDBObject_0T_phase1_BoR3_v1

if this PR is a backport please specify the original PR and why you need to backport that PR:

This is not a PR, and there is no PR planned

cc: @mmusich @tsusa

cmsbuild · 2020-07-06T21:36:58Z

The code-checks are being triggered in jenkins.

cmsbuild · 2020-07-06T21:43:36Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30563/16799

This PR adds an extra 1332KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

code-format:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30563/16799/code-format.patch
e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30563/16799/code-format.patch | patch -p1
You can also run scram build code-format to apply code format directly

cmsbuild · 2020-07-06T21:49:10Z

The code-checks are being triggered in jenkins.

cmsbuild · 2020-07-06T21:54:38Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30563/16800

This PR adds an extra 1336KB to repository

cmsbuild · 2020-07-06T21:54:59Z

A new Pull Request was created by @tvami (Tamas Vami) for master.

It involves the following packages:

CondTools/SiPixel

@ggovi, @cmsbuild can you please review it and eventually sign? Thanks.
@mmusich, @dkotlins, @VinInn this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

tvami · 2020-07-06T22:47:30Z

Hi @christopheralanwest , could you please initiate the tests? Thanks!

mmusich · 2020-07-07T05:34:59Z

CondTools/SiPixel/data/SiPixelTemplateDBObject_0T_phase1_BoR3_v1/generror_summary_zp0310.out

@@ -0,0 +1,1437 @@
+Dot1_150x100_dj0260a@-375V,0.0T@90d,263K,rh=1.10/0.7,1.3/1.3 


Hi @tvami, these huge files do not belong to cmssw. Please remove them and squash your commit history in order not to clog the repo.

mmusich · 2020-07-07T05:36:57Z

CondTools/SiPixel/test/run_0T_BoR3.sh

@@ -0,0 +1,2 @@
+cmsRun SiPixelTemplateDBObjectUploader_cfg.py Fullname=SiPixelTemplateDBObject_phase1_0T_mc_BoR3_v1_bugfix Map=../data/SiPixelTemplateDBObject_0T_phase1_BoR3_v1/mapping.csv TemplateFilePath=CondTools/SiPixel/data/SiPixelTemplateDBObject_0T_phase1_BoR3_v1


@tvami maybe this can become a unit test?

cmsbuild · 2020-07-07T17:50:04Z

The code-checks are being triggered in jenkins.

cmsbuild · 2020-07-07T17:54:27Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30563/16816

This PR adds an extra 1336KB to repository
Found files with invalid states:
- CondTools/SiPixel/data/SiPixelTemplateDBObject_0T_phase1_BoR3_v1/generror_summary_zp0313.out:
  - Added: 7a13dde
  - Deleted: 028161f
- CondTools/SiPixel/data/SiPixelTemplateDBObject_0T_phase1_BoR3_v1/generror_summary_zp0312.out:
  - Added: 7a13dde
  - Deleted: 028161f
- CondTools/SiPixel/data/SiPixelTemplateDBObject_0T_phase1_BoR3_v1/generror_summary_zp0311.out:
  - Added: 7a13dde
  - Deleted: 028161f
- CondTools/SiPixel/data/SiPixelTemplateDBObject_0T_phase1_BoR3_v1/template_summary_zp0311.out:
  - Added: 7a13dde
  - Deleted: 028161f
- CondTools/SiPixel/data/SiPixelTemplateDBObject_0T_phase1_BoR3_v1/template_summary_zp0310.out:
  - Added: 7a13dde
  - Deleted: 028161f
- CondTools/SiPixel/data/SiPixelTemplateDBObject_0T_phase1_BoR3_v1/template_summary_zp0313.out:
  - Added: 7a13dde
  - Deleted: 028161f
- CondTools/SiPixel/data/SiPixelTemplateDBObject_0T_phase1_BoR3_v1/mapping.csv:
  - Added: 7a13dde
  - Deleted: 028161f
- CondTools/SiPixel/data/SiPixelTemplateDBObject_0T_phase1_BoR3_v1/template_summary_zp0315.out:
  - Added: 7a13dde
  - Deleted: 028161f
- CondTools/SiPixel/data/SiPixelTemplateDBObject_0T_phase1_BoR3_v1/template_summary_zp0312.out:
  - Added: 7a13dde
  - Deleted: 028161f
- CondTools/SiPixel/data/SiPixelTemplateDBObject_0T_phase1_BoR3_v1/generror_summary_zp0310.out:
  - Added: 7a13dde
  - Deleted: 028161f
- CondTools/SiPixel/data/SiPixelTemplateDBObject_0T_phase1_BoR3_v1/generror_summary_zp0314.out:
  - Added: 7a13dde
  - Deleted: 028161f
- CondTools/SiPixel/data/SiPixelTemplateDBObject_0T_phase1_BoR3_v1/generror_summary_zp0315.out:
  - Added: 7a13dde
  - Deleted: 028161f
- CondTools/SiPixel/data/SiPixelTemplateDBObject_0T_phase1_BoR3_v1/template_summary_zp0314.out:
  - Added: 7a13dde
  - Deleted: 028161f

cmsbuild · 2020-07-07T17:54:49Z

Pull request #30563 was updated. @ggovi, @cmsbuild can you please check and sign again.

clang code-format minor changes testing files clang code-format again Removing input files

cmsbuild · 2020-07-07T21:25:03Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-cae53e/7766/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 37
DQMHistoTests: Total histograms compared: 2787364
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2787313
DQMHistoTests: Total skipped: 50
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 36 files compared)
Checked 154 log files, 17 edm output root files, 37 DQM output files

cmsbuild · 2020-07-07T21:25:25Z

The code-checks are being triggered in jenkins.

mmusich · 2020-07-07T21:26:50Z

@cmsbuild, please test with cms-data/CalibTracker-SiPixelESProducers#1

cmsbuild · 2020-07-07T21:30:38Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30563/16823

This PR adds an extra 20KB to repository

cmsbuild · 2020-07-07T21:31:01Z

The tests are being triggered in jenkins.
Tested with other pull request(s) cms-data/CalibTracker-SiPixelESProducers#1

CMSSW_11_2_X_2020-07-07-1100/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/7770/console Started: 2020/07/07 23:32

cmsbuild · 2020-07-07T21:31:04Z

Pull request #30563 was updated. @ggovi, @cmsbuild can you please check and sign again.

cmsbuild · 2020-07-08T07:03:18Z

+1
Tested at: bd78af9
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-68bfb5/7770/summary.html
CMSSW: CMSSW_11_2_X_2020-07-07-1100
SCRAM_ARCH: slc7_amd64_gcc820

cmsbuild · 2020-07-08T07:03:23Z

Comparison job queued.

cmsbuild · 2020-07-08T08:46:12Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-68bfb5/7770/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 37
DQMHistoTests: Total histograms compared: 2787364
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2787313
DQMHistoTests: Total skipped: 50
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 36 files compared)
Checked 154 log files, 17 edm output root files, 37 DQM output files

mmusich · 2020-07-08T19:58:59Z

@smuzaffar, the static analyzer has some complaints about this PR: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-68bfb5/7770/summary.html, but checking the log is not very clear which change proposed here is triggering the warning. Do you have any hint?

ggovi · 2020-07-10T19:28:39Z

+1

cmsbuild · 2020-07-10T19:29:05Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2)

silviodonato · 2020-07-12T10:29:58Z

+1

cmsbuild added this to the CMSSW_11_2_X milestone Jul 6, 2020

cmsbuild added code-checks-pending comparison-pending db-pending orp-pending pending-signatures tests-pending labels Jul 6, 2020

cmsbuild added code-checks-rejected code-checks-pending and removed code-checks-pending code-checks-rejected labels Jul 6, 2020

cmsbuild added code-checks-approved and removed code-checks-pending labels Jul 6, 2020

mmusich reviewed Jul 7, 2020

View reviewed changes

tvami mentioned this pull request Jul 7, 2020

Input files for SiPixelTemplateDBObject_0T_phase1_BoR3_v1 cms-data/CalibTracker-SiPixelESProducers#1

Merged

cmsbuild added code-checks-pending and removed code-checks-approved labels Jul 7, 2020

cmsbuild added code-checks-approved and removed code-checks-pending labels Jul 7, 2020

Updating Template and GenErr making codes

9fe5c9b

clang code-format minor changes testing files clang code-format again Removing input files

tvami force-pushed the PixelTemplateMakingUpdate branch from 028161f to 9fe5c9b Compare July 7, 2020 18:02

tvami force-pushed the PixelTemplateMakingUpdate branch from f620ae6 to bd78af9 Compare July 7, 2020 21:25

cmsbuild added code-checks-approved and removed code-checks-pending labels Jul 7, 2020

cmsbuild added requires-external tests-started and removed tests-pending labels Jul 7, 2020

cmsbuild added tests-approved and removed tests-started labels Jul 8, 2020

cmsbuild added comparison-available and removed comparison-pending labels Jul 8, 2020

cmsbuild added db-approved fully-signed and removed db-pending pending-signatures labels Jul 10, 2020

cmsbuild added orp-approved and removed orp-pending labels Jul 12, 2020

cmsbuild merged commit b2aff51 into cms-sw:master Jul 12, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Pixel template making code update #30563

Pixel template making code update #30563

tvami commented Jul 6, 2020

cmsbuild commented Jul 6, 2020

cmsbuild commented Jul 6, 2020

cmsbuild commented Jul 6, 2020

cmsbuild commented Jul 6, 2020

cmsbuild commented Jul 6, 2020

tvami commented Jul 6, 2020

mmusich Jul 7, 2020

mmusich Jul 7, 2020

tvami Jul 7, 2020

cmsbuild commented Jul 7, 2020

cmsbuild commented Jul 7, 2020

cmsbuild commented Jul 7, 2020

cmsbuild commented Jul 7, 2020

cmsbuild commented Jul 7, 2020

mmusich commented Jul 7, 2020

cmsbuild commented Jul 7, 2020

cmsbuild commented Jul 7, 2020 •

edited

cmsbuild commented Jul 7, 2020

cmsbuild commented Jul 8, 2020

cmsbuild commented Jul 8, 2020

cmsbuild commented Jul 8, 2020

mmusich commented Jul 8, 2020

ggovi commented Jul 10, 2020

cmsbuild commented Jul 10, 2020

silviodonato commented Jul 12, 2020

		@@ -0,0 +1,1437 @@
		Dot1_150x100_dj0260a@-375V,0.0T@90d,263K,rh=1.10/0.7,1.3/1.3

		@@ -0,0 +1,2 @@
		cmsRun SiPixelTemplateDBObjectUploader_cfg.py Fullname=SiPixelTemplateDBObject_phase1_0T_mc_BoR3_v1_bugfix Map=../data/SiPixelTemplateDBObject_0T_phase1_BoR3_v1/mapping.csv TemplateFilePath=CondTools/SiPixel/data/SiPixelTemplateDBObject_0T_phase1_BoR3_v1

Pixel template making code update #30563

Pixel template making code update #30563

Conversation

tvami commented Jul 6, 2020

PR description:

PR validation:

if this PR is a backport please specify the original PR and why you need to backport that PR:

cmsbuild commented Jul 6, 2020

cmsbuild commented Jul 6, 2020

cmsbuild commented Jul 6, 2020

cmsbuild commented Jul 6, 2020

cmsbuild commented Jul 6, 2020

tvami commented Jul 6, 2020

mmusich Jul 7, 2020

Choose a reason for hiding this comment

mmusich Jul 7, 2020

Choose a reason for hiding this comment

tvami Jul 7, 2020

Choose a reason for hiding this comment

cmsbuild commented Jul 7, 2020

cmsbuild commented Jul 7, 2020

cmsbuild commented Jul 7, 2020

cmsbuild commented Jul 7, 2020

cmsbuild commented Jul 7, 2020

mmusich commented Jul 7, 2020

cmsbuild commented Jul 7, 2020

cmsbuild commented Jul 7, 2020 • edited

cmsbuild commented Jul 7, 2020

cmsbuild commented Jul 8, 2020

cmsbuild commented Jul 8, 2020

cmsbuild commented Jul 8, 2020

mmusich commented Jul 8, 2020

ggovi commented Jul 10, 2020

cmsbuild commented Jul 10, 2020

silviodonato commented Jul 12, 2020

cmsbuild commented Jul 7, 2020 •

edited