Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add L1 hitless seeding for tracking @ HLT (11_1_X) #30574

Merged

Conversation

cmantill
Copy link
Contributor

@cmantill cmantill commented Jul 7, 2020

PR description:

Adding hitless seeds from L1 tracks to be used in the Phase2 HLT tracking sequence.

PR validation:

runTheMatrix.py -l limited -i all --ibeos

Should not affect any current workflows.

if this PR is a backport please specify the original PR and why you need to backport that PR:

Backport of 30342.

Needed for HLT MC samples production.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 7, 2020

A new Pull Request was created by @cmantill (Cristina Ana Mantilla Suarez) for CMSSW_11_1_X.

It involves the following packages:

RecoTracker/TkSeedGenerator
TrackingTools/TrajectoryState

@perrotta, @jpata, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@jhgoh, @trocino, @calderona, @makortel, @felicepantaleo, @abbiendi, @GiacomoSguazzoni, @JanFSchulte, @rovere, @VinInn, @bellan, @cericeci, @HuguesBrun, @Fedespring, @lecriste, @mschrode, @gpetruc, @ebrondol, @mtosi, @dgulhan, @folguera this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

@slava77
Copy link
Contributor

slava77 commented Jul 7, 2020

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 7, 2020

The tests are being triggered in jenkins.

@slava77
Copy link
Contributor

slava77 commented Jul 7, 2020

backport of #30342

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 7, 2020

+1
Tested at: 0130cff
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-539853/7759/summary.html
CMSSW: CMSSW_11_1_X_2020-07-07-1100
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 7, 2020

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 7, 2020

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-539853/7759/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 6 differences found in the comparisons
  • DQMHistoTests: Total files compared: 36
  • DQMHistoTests: Total histograms compared: 2780792
  • DQMHistoTests: Total failures: 4
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2780738
  • DQMHistoTests: Total skipped: 50
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 35 files compared)
  • Checked 152 log files, 16 edm output root files, 36 DQM output files

@slava77
Copy link
Contributor

slava77 commented Jul 8, 2020

+1

for #30574 0130cff

  • the backport is correct; the only difference in the PR diffs compared to the master version is in SeedGeneratorFromL1TTracksEDProducer.cc due to the change of name of TrajectorySeed::RecHitContainer typedef (introduced recently in the 11_2_X). This code is to be used for HLT developments; it is currently not a part of the standard workflows.
  • jenkins tests pass and comparisons show no relevant differences

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 8, 2020

This pull request is fully signed and it will be integrated in one of the next CMSSW_11_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2)

@silviodonato
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants