Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Phase2-gex05 Bug fix to Phase2 geometries D49 and higher versions #30603

Merged
merged 1 commit into from Jul 9, 2020

Conversation

bsunanda
Copy link
Contributor

@bsunanda bsunanda commented Jul 8, 2020

PR description:

Bug fix to Phase2 geometries D49 and higher versions (backport from PR #30579)

PR validation:

Tested using runTheMatrix test workflows

if this PR is a backport please specify the original PR and why you need to backport that PR:

Back port from #30579

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 8, 2020

A new Pull Request was created by @bsunanda for CMSSW_11_1_X.

It involves the following packages:

Configuration/Geometry
Geometry/CMSCommonData

@civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @kpedro88 can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @fabiocos, @slomeo, @vargasa this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

@bsunanda
Copy link
Contributor Author

bsunanda commented Jul 8, 2020

@cmsbuild Please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 8, 2020

The tests are being triggered in jenkins.

@silviodonato
Copy link
Contributor

merge

@cmsbuild cmsbuild merged commit a14a4b8 into cms-sw:CMSSW_11_1_X Jul 9, 2020
@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 9, 2020

+1
Tested at: 19012af
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e4273b/7811/summary.html
CMSSW: CMSSW_11_1_X_2020-07-08-2300
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 9, 2020

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 9, 2020

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e4273b/7811/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 3392 differences found in the comparisons
  • DQMHistoTests: Total files compared: 36
  • DQMHistoTests: Total histograms compared: 2780792
  • DQMHistoTests: Total failures: 40735
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2740007
  • DQMHistoTests: Total skipped: 50
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 35 files compared)
  • Checked 152 log files, 16 edm output root files, 36 DQM output files

@kpedro88
Copy link
Contributor

kpedro88 commented Jul 9, 2020

+upgrade

@cvuosalo
Copy link
Contributor

cvuosalo commented Jul 9, 2020

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 9, 2020

This pull request is fully signed and it will be integrated in one of the next CMSSW_11_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_2_X is complete. This pull request will be automatically merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants