Remove further unused classes from DataFormats/GEMDigi

[watson-ij]

PR description:

Per #30586 removing further unused classes DataFormats/GEMDigi/GEMAMCStatusDigi and GEMGEBStatusDigi. These classes are older unused versions of replacements in EventFilter/GEMRawToDigi.

@jshlee @quark2 @hyunyong @davidlange6

PR validation:

Checked run the matrix on the 2021 10mu workflow 11621.0 runs without issue after removing the classes.

if this PR is a backport please specify the original PR and why you need to backport that PR:

Before submitting your pull requests, make sure you followed this checklist:

• verify that the PR is really intended for the chosen branch
• verify that changes follow CMS Naming, Coding, And Style Rules
• verify that the PR passes the basic test procedure suggested in the CMSSW PR instructions

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

-code-checks

ERROR: Build errors found during clang-tidy run.

gmake: *** [tmp/slc7_amd64_gcc820/Makefile:32: .SCRAM/slc7_amd64_gcc820/timestamps/clhepheader] Error 1

gzip: /build/cmsbld/jenkins/workspace/run-pr-code-checks/CMSSW_11_2_X_2020-07-08-2300/.SCRAM/slc7_amd64_gcc820/ToolCache.db.gz: unexpected end of file
Can't call method "initpathvars" on an undefined value at /cvmfs/cms-ib.cern.ch/nweek-02636/share/lcg/SCRAMV1/V2_2_9_pre07/src/SCRAM/SCRAM.pm line 392.
--
gmake: *** [tmp/slc7_amd64_gcc820/Makefile:32: .SCRAM/slc7_amd64_gcc820/timestamps/clhep] Error 1

Finding a value for CORAL_BASE:

--
gmake: *** No rule to make target 'code-checks'.
gmake: *** [There are compilation/build errors. Please see the detail log above.] Error 2

[watson-ij]

I don't think this is due to me. I added this onto a branch that was previously merged into master, could that cause an issue?

[davidlange6]

@smuzaffar - seems code checks are not working this morning On Jul 9, 2020, at 8:20 AM, cmsbuild <notifications@github.com<mailto:notifications@github.com>> wrote:

…

-code-checks ERROR: Build errors found during clang-tidy run. gmake: *** [tmp/slc7_amd64_gcc820/Makefile:32: .SCRAM/slc7_amd64_gcc820/timestamps/clhepheader] Error 1 gzip: /build/cmsbld/jenkins/workspace/run-pr-code-checks/CMSSW_11_2_X_2020-07-08-2300/.SCRAM/slc7_amd64_gcc820/ToolCache.db.gz: unexpected end of file Can't call method "initpathvars" on an undefined value at /cvmfs/cms-ib.cern.ch/nweek-02636/share/lcg/SCRAMV1/V2_2_9_pre07/src/SCRAM/SCRAM.pm<http://cms-ib.cern.ch/nweek-02636/share/lcg/SCRAMV1/V2_2_9_pre07/src/SCRAM/SCRAM.pm> line 392. -- gmake: *** [tmp/slc7_amd64_gcc820/Makefile:32: .SCRAM/slc7_amd64_gcc820/timestamps/clhep] Error 1 Finding a value for CORAL_BASE:

-- gmake: *** No rule to make target 'code-checks'. gmake: *** [There are compilation/build errors. Please see the detail log above.] Error 2 — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<#30609 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ABGPFQZS7JXRYGGHV6UQKMLR2VORFANCNFSM4OVHXWKA>.

[davidlange6]

code-checks

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30609/16900

• This PR adds an extra 16KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File DataFormats/GEMDigi/src/GEMGEBStatusDigi.cc modified in PR(s): [RFC] Test clang-tidy --checks performance-unnecessary-value-param #29933

[cmsbuild]

A new Pull Request was created by @watson-ij (Ian J. Watson) for master.

It involves the following packages:

DataFormats/GEMDigi

@cmsbuild, @civanch, @kpedro88, @mdhildreth can you please review it and eventually sign? Thanks.
@jshlee, @dildick, @rovere this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

[kpedro88]

please test

[cmsbuild]

The tests are being triggered in jenkins.

• CMSSW_11_2_X_2020-07-10-1100/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/7868/console Started: 2020/07/10 17:50

[cmsbuild]

+1
Tested at: ac66488
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-60614e/7868/summary.html
CMSSW: CMSSW_11_2_X_2020-07-10-1100
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-60614e/7868/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 37
• DQMHistoTests: Total histograms compared: 2787429
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2787378
• DQMHistoTests: Total skipped: 50
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 36 files compared)
• Checked 154 log files, 17 edm output root files, 37 DQM output files

[kpedro88]

+upgrade

[civanch]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2)

[silviodonato]

+1