Check valid pads and clusters in GEM trigger primitive producers

[dildick]

PR description:

I added a few statements to ignore invalid pads and clusters in the GEM-CSC trigger. I also added checks (LogWarnings, not selections) in the GEM trigger primitive producers.

PR validation:

Tested with 23234.0 in 11_2_X.

if this PR is a backport please specify the original PR and why you need to backport that PR:

N/A

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30624/16887

• This PR adds an extra 12KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File L1Trigger/CSCTriggerPrimitives/src/GEMCoPadProcessor.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-use-emplace #29937, [RFC] Test clang-tidy --checks modernize-loop-convert #29935

[cmsbuild]

A new Pull Request was created by @dildick (Sven Dildick) for master.

It involves the following packages:

L1Trigger/CSCTriggerPrimitives

@cmsbuild, @rekovic, @benkrikler can you please review it and eventually sign? Thanks.
@valuev, @ptcox, @Martin-Grunewald this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

[silviodonato]

@rekovic do you have any comments?

[silviodonato]

please test

[cmsbuild]

The tests are being triggered in jenkins.

• CMSSW_11_2_X_2020-07-13-1100/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/7909/console Started: 2020/07/13 17:07

[cmsbuild]

+1
Tested at: 7ed1564
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7eba07/7909/summary.html
CMSSW: CMSSW_11_2_X_2020-07-13-1100
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7eba07/7909/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 37
• DQMHistoTests: Total histograms compared: 2787429
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2787378
• DQMHistoTests: Total skipped: 50
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 36 files compared)
• Checked 154 log files, 17 edm output root files, 37 DQM output files

[dildick]

@rekovic If you could wait with signing this. I'll amend this pull requests with log warnings in the pad and cluster producer is invalid primitives are produced.

[cmsbuild]

+1
Tested at: b189232
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7eba07/8652/summary.html
CMSSW: CMSSW_11_2_X_2020-08-07-1100
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7eba07/8652/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 35
• DQMHistoTests: Total histograms compared: 2612401
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2612352
• DQMHistoTests: Total skipped: 48
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
• Checked 149 log files, 22 edm output root files, 35 DQM output files

[kpedro88]

+upgrade

[cvuosalo]

+1

[civanch]

+1

[dildick]

@rekovic Could you sign, please?

[silviodonato]

kind reminder @cms-sw/l1-l2

[rekovic]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1