Phase2-gem43 Remove an overlap in the MF shield #30654
Conversation
|
The code-checks are being triggered in jenkins. |
|
@slomeo Please check this |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30654/16932
|
|
A new Pull Request was created by @bsunanda for master. It involves the following packages: Geometry/MuonCommonData @civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
@cmsbuild Please test |
|
The tests are being triggered in jenkins. |
|
ERROR: empty variable. PR had errors - #30654. |
|
-1 Tested at: 73a8409 CMSSW: CMSSW_11_2_X_2020-07-12-2300 I found follow errors while testing this PR Failed tests: RelVals AddOn
When I ran the RelVals I found an error in the following workflows: DAS Error
I found errors in the following addon tests: cmsDriver.py RelVal -s HLT:2018,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run2_data_2018 --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2018 --processName=HLTRECO --filein file:RelVal_Raw_2018_DATA.root --fileout file:RelVal_Raw_2018_DATA_HLT_RECO.root : FAILED - time: date Mon Jul 13 10:08:27 2020-date Mon Jul 13 09:54:45 2020 s - exit: 34304 |
|
Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped) |
|
Pull request #30654 was updated. @civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild can you please check and sign again. |
|
@cmsbuild Please test |
|
The tests are being triggered in jenkins.
|
|
+1 |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
@bsunanda : I rebased your PR in CMSSW_11_2_X_2020-07-12-2300 and I put in Geometry/CMSCommonData/python/cmsExtendedGeometry2026D59XML_cfi.py the line 'Geometry/MuonCommonData/data/muonYoke/2026/v1/muonYoke.xml' instead of Geometry/MuonCommonData/data/muonYoke/2021/v3/muonYoke.xml'. Then I checked the overlaps with cmsShow and I found what you can see in the attached picture: |
|
@cvuosalo Can you approve this PR. I urgently need this PR to resolve overlaps in many phase2 scenarios |
|
+1 |
cmsbuild
added
fully-signed
geometry-approved
and removed
geometry-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2) |
|
@bsunanda Is Sergio's comment saying that there are still overlaps in this PR? |
|
+1 |
PR description:
ShieldingME4 in muonYoke.xml (as in 2021/v3) is overlapping with ShieldongBoronPoly_1_ME in mfshield.xml (as of 2026/v4) over a large region. They are made of same material and one of them is commented out in 2026/v1 version of muonYoke.xml
PR validation:
Tested using overlap tool in a phase2 scenario
if this PR is a backport please specify the original PR and why you need to backport that PR:
Nothing special