Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert the CSCTriggerPrimitivesProducer to a "one" module #30657

Conversation

fwyzard
Copy link
Contributor

@fwyzard fwyzard commented Jul 13, 2020

Uses a single CSCTriggerPrimitivesBuilder instead of one per stream, saving ~570 MB per stream in a TTbar Phase 2 workflow.

Uses a single CSCTriggerPrimitivesBuilder instead of one per stream,
saving ~570 MB per stream in a TTbar Phase 2 workflow.
@fwyzard
Copy link
Contributor Author

fwyzard commented Jul 13, 2020

backport #30656

@fwyzard
Copy link
Contributor Author

fwyzard commented Jul 13, 2020

urgent

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 13, 2020

A new Pull Request was created by @fwyzard (Andrea Bocci) for CMSSW_11_1_X.

It involves the following packages:

L1Trigger/CSCTriggerPrimitives

@cmsbuild, @rekovic, @benkrikler can you please review it and eventually sign? Thanks.
@valuev, @Martin-Grunewald, @ptcox, @dildick this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

@fwyzard
Copy link
Contributor Author

fwyzard commented Jul 13, 2020

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 13, 2020

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+1
Tested at: 1da1e4c
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-74314b/7905/summary.html
CMSSW: CMSSW_11_1_X_2020-07-13-1100
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-74314b/7905/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 36
  • DQMHistoTests: Total histograms compared: 2780792
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2780741
  • DQMHistoTests: Total skipped: 50
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 35 files compared)
  • Checked 152 log files, 16 edm output root files, 36 DQM output files

@silviodonato
Copy link
Contributor

merge

@cmsbuild cmsbuild merged commit 531d66c into cms-sw:CMSSW_11_1_X Jul 13, 2020
@rekovic
Copy link
Contributor

rekovic commented Jul 14, 2020

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_11_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_2_X is complete. This pull request will be automatically merged.

@fwyzard fwyzard deleted the convert_CSCTriggerPrimitivesProducer_to_one_11_1_x branch July 14, 2020 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants