Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to vdt_headers toolfile #3066

Merged
merged 1 commit into from Apr 2, 2014
Merged

Switch to vdt_headers toolfile #3066

merged 1 commit into from Apr 2, 2014

Conversation

ktf
Copy link
Contributor

@ktf ktf commented Mar 28, 2014

In cms-sw/cmsdist#524 we split vdt toolfile in vdt_headers and vdt (i.e. the compatibility library). This moves all the build file to use vdt_headers and introduces a cmsRunVDT which binds libvdt as early as possible (to demonstrate this is actually enough).

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @ktf (Giulio Eulisse) for CMSSW_7_1_X.

Switch to vdt_headers toolfile

It involves the following packages:

FWCore/Framework
Geometry/CommonTopologies
RecoJets/JetProducers
RecoLocalCalo/EcalRecAlgos
RecoLocalTracker/SiPixelRecHits
RecoLocalTracker/SiStripRecHitConverter
RecoParticleFlow/PFClusterProducer
RecoVertex/PrimaryVertexProducer
SimTracker/Common
SimTracker/SiStripDigitizer
TrackingTools/AnalyticalJacobians
TrackingTools/GeomPropagators
TrackingTools/TrajectoryState

@civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @anton-a, @thspeer, @slava77, @Degano, @ktf, @nclopezo can you please review it and eventually sign? Thanks.
@ghellwig, @TaiSakuma, @wmtan, @yslai, @GiacomoSguazzoni, @rovere, @argiro, @nhanvtran, @gpetruc, @cerati, @venturia this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@ianna
Copy link
Contributor

ianna commented Mar 28, 2014

+1

@ktf
Copy link
Contributor Author

ktf commented Mar 28, 2014

+1

@cmsbuild
Copy link
Contributor

Pull request #3066 was updated. @civanch, @nclopezo, @mdhildreth, @cmsbuild, @anton-a, @thspeer, @slava77, @Degano can you please check and sign again.

@ktf
Copy link
Contributor Author

ktf commented Mar 28, 2014

@VinInn

@civanch
Copy link
Contributor

civanch commented Mar 29, 2014

+1

@VinInn
Copy link
Contributor

VinInn commented Apr 2, 2014

what is so no obvious in this that requires tons of signature, all pending?

@ktf
Copy link
Contributor Author

ktf commented Apr 2, 2014

+1
The fact that before it was linking libvdt while now it's not. If @slava77 does not care, I'll just bypass.

@civanch
Copy link
Contributor

civanch commented Apr 2, 2014

+1

@slava77
Copy link
Contributor

slava77 commented Apr 2, 2014

@ktf
Copy link
Contributor Author

ktf commented Apr 2, 2014

@nclopezo can you run again?

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 2, 2014

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 2, 2014

@slava77
Copy link
Contributor

slava77 commented Apr 2, 2014

+1

for 7d335bb
looked at jenkins relmon and with fwlite script using jenkins outputs

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 2, 2014

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes (tests are also fine). @nclopezo, @ktf can you please take care of it?

ktf added a commit that referenced this pull request Apr 2, 2014
Switch to vdt_headers toolfile
@ktf ktf merged commit c43c550 into cms-sw:CMSSW_7_1_X Apr 2, 2014
@ktf ktf deleted the cleanup-vdt branch April 2, 2014 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants