Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[11.1.X] add onlineMetaDataDigis unpacker for Strip online client #30678

Merged

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Jul 14, 2020

backport of #30677

PR description:

Title says it all, adds the onlineMetaDataDigis unpacker for Strip online client, to fix a crash seen in the DQM playback system.

PR validation:

None so far.

 ./src/DQM/Integration/test/runtest.sh sistrip_dqm_sourceclient-live_cfg.py

runs to completion.

if this PR is a backport please specify the original PR and why you need to backport that PR:

This is a backport of #30677

@mmusich
Copy link
Contributor Author

mmusich commented Jul 14, 2020

urgent

@mmusich
Copy link
Contributor Author

mmusich commented Jul 14, 2020

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 14, 2020

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 14, 2020

A new Pull Request was created by @mmusich (Marco Musich) for CMSSW_11_1_X.

It involves the following packages:

DQM/Integration

@andrius-k, @kmaeshima, @schneiml, @cmsbuild, @jfernan2, @fioriNTU can you please review it and eventually sign? Thanks.
@threus, @batinkov, @battibass this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

+1
Tested at: c17049f
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-83e359/7927/summary.html
CMSSW: CMSSW_11_1_X_2020-07-14-1100
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-83e359/7927/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 36
  • DQMHistoTests: Total histograms compared: 2780792
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2780741
  • DQMHistoTests: Total skipped: 50
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 35 files compared)
  • Checked 152 log files, 16 edm output root files, 36 DQM output files

@jfernan2
Copy link
Contributor

+1
Tested in Online DQM and it fixes the issue

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_11_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2)

@silviodonato
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 2df13a8 into cms-sw:CMSSW_11_1_X Jul 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants