Removed boost::filesystem in GeneratorInterface/EvtGenInterface

[camolezi]

PR description:

Boost here is only used to create a temporary file.
I think a std::tmpnam should be enough in this case.

PR validation:

Passed on basic runTheMatrix test.

if this PR is a backport please specify the original PR and why you need to backport that PR:

@vgvassilev @davidlange6

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30692/16984

• This PR adds an extra 20KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-checks:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30692/16984/code-checks.patch
  e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30692/16984/code-checks.patch | patch -p1
  You can also run scram build code-checks to apply code checks directly

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30692/16986

• This PR adds an extra 20KB to repository

[cmsbuild]

A new Pull Request was created by @camolezi (Lucas Camolezi) for master.

It involves the following packages:

GeneratorInterface/EvtGenInterface

@SiewYan, @mkirsano, @cmsbuild, @GurpreetSinghChahal, @agrohsje, @alberto-sanchez, @qliphy can you please review it and eventually sign? Thanks.
@alberto-sanchez, @agrohsje, @mkirsano this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

[davidlange6]

please test

[cmsbuild]

The tests are being triggered in jenkins.

• CMSSW_11_2_X_2020-07-15-2300/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/7995/console Started: 2020/07/16 10:59

[cmsbuild]

+1
Tested at: c8f3b80
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-afaa7f/7995/summary.html
CMSSW: CMSSW_11_2_X_2020-07-15-2300
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-afaa7f/7995/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 35
• DQMHistoTests: Total histograms compared: 2612943
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2612894
• DQMHistoTests: Total skipped: 48
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
• Checked 146 log files, 17 edm output root files, 35 DQM output files

[qliphy]

please test workflow 541.0,545.0

[cmsbuild]

The tests are being triggered in jenkins.
Test Parameters:

• MATRIX_EXTRAS = 545.0,541.0
• CMSSW_11_2_X_2020-07-16-2300/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/8034/console Started: 2020/07/17 09:20

[cmsbuild]

+1
Tested at: c8f3b80
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-afaa7f/8034/summary.html
CMSSW: CMSSW_11_2_X_2020-07-16-2300
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-afaa7f/8034/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

• /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-afaa7f/541.0_BuToKstarJPsiToMuMu_forSTEAM_13TeV+BuToKstarJPsiToMuMu_forSTEAM_13TeV+HARVESTGEN
• /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-afaa7f/545.0_BsToMuMu_forSTEAM_13TeV+BsToMuMu_forSTEAM_13TeV+HARVESTGEN

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 35
• DQMHistoTests: Total histograms compared: 2612943
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2612894
• DQMHistoTests: Total skipped: 48
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
• Checked 146 log files, 17 edm output root files, 35 DQM output files

[qliphy]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2)

[silviodonato]

+1

[silviodonato]

@camolezi we are getting a warning during the compilation of GeneratorInterface/EvtGenInterface
/opt/cmssw/slc7_amd64_gcc820/cms/cmssw/CMSSW_11_2_X_2020-07-20-2300/src/GeneratorInterface/EvtGenInterface/plugins/EvtGen/EvtGenInterface.cc:366: warning: the use of tmpnam' is dangerous, better use mkstemp'
could you fix it? Thanks

[camolezi]

@camolezi we are getting a warning during the compilation of GeneratorInterface/EvtGenInterface
/opt/cmssw/slc7_amd64_gcc820/cms/cmssw/CMSSW_11_2_X_2020-07-20-2300/src/GeneratorInterface/EvtGenInterface/plugins/EvtGen/EvtGenInterface.cc:366: warning: the use of tmpnam' is dangerous, better use mkstemp'
could you fix it? Thanks

sure