New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix tmpnam warning in GenIface #30851
Conversation
please test |
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30851/17203
|
The tests are being triggered in jenkins.
|
A new Pull Request was created by @mrodozov (Mircho Rodozov) for master. It involves the following packages: GeneratorInterface/EvtGenInterface @SiewYan, @mkirsano, @cmsbuild, @GurpreetSinghChahal, @agrohsje, @alberto-sanchez, @qliphy can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
+1 |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
After #30692 this warning poped:
warning: the use of tmpnam is dangerous, better use mkstemp
I'm following what the compiler suggested
PR validation:
builds and tests ran, checked the tmpfile creation in standalone example, it worked as described in
https://www.man7.org/linux/man-pages/man3/mkstemp.3.html