utilities for HGCAL end of life

[franzoni]

PR description:

Only technical changes:

• avoid looping over in-time and out-of-time HGCAL digis if a data farme wont' be kept
• add utilities and customise functions we've used to validate the HGCAL noise model and occupancies toggling on-and-off noise, out-of-time
• implement interface to actually use the existing capability of scaling the fluence map to model HGCAL ageing at an arbitrary integrated luminosity

PR validation:

We've reported on occupancy and spectra on slides 17-22 of this talk at the HGCAL mini-workshop last week

Not a backport.

@pfs @rovere

[franzoni]

please test

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30697/16997

• This PR adds an extra 32KB to repository

[cmsbuild]

The tests are being triggered in jenkins.

• CMSSW_11_2_X_2020-07-14-2300/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/7961/console Started: 2020/07/15 13:13

[cmsbuild]

A new Pull Request was created by @franzoni (Giovanni Franzoni) for master.

It involves the following packages:

SimCalorimetry/HGCalSimAlgos
SimCalorimetry/HGCalSimProducers

@cmsbuild, @civanch, @kpedro88, @mdhildreth can you please review it and eventually sign? Thanks.
@vandreev11, @sethzenz, @makortel, @rovere, @lgray, @cseez, @apsallid, @pfs, @deguio, @hatakeyamak this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

-1

Tested at: 92964ef

CMSSW: CMSSW_11_2_X_2020-07-14-2300
SCRAM_ARCH: slc7_amd64_gcc820
You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ecc5ff/7961/summary.html

I found follow errors while testing this PR

Failed tests: RelVals

• RelVals:

When I ran the RelVals I found an error in the following workflows:
23234.1001 step1

runTheMatrix-results/23234.1001_TTbar_14TeV+RecoFullGlobal_TestOldDigi_2026D49+HARVESTFullGlobal_2026D49/step1_TTbar_14TeV+RecoFullGlobal_TestOldDigi_2026D49+HARVESTFullGlobal_2026D49.log

23234.0 step3

runTheMatrix-results/23234.0_TTbar_14TeV+TTbar_14TeV_TuneCP5_2026D49_GenSimHLBeamSpotFull14+DigiFullTrigger_2026D49+RecoFullGlobal_2026D49+HARVESTFullGlobal_2026D49/step3_TTbar_14TeV+TTbar_14TeV_TuneCP5_2026D49_GenSimHLBeamSpotFull14+DigiFullTrigger_2026D49+RecoFullGlobal_2026D49+HARVESTFullGlobal_2026D49.log

28234.0 step3

runTheMatrix-results/28234.0_TTbar_14TeV+TTbar_14TeV_TuneCP5_2026D60_GenSimHLBeamSpotFull14+DigiFullTrigger_2026D60+RecoFullGlobal_2026D60+HARVESTFullGlobal_2026D60/step3_TTbar_14TeV+TTbar_14TeV_TuneCP5_2026D60_GenSimHLBeamSpotFull14+DigiFullTrigger_2026D60+RecoFullGlobal_2026D60+HARVESTFullGlobal_2026D60.log

[cmsbuild]

Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped)

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30697/17094

• This PR adds an extra 88KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File RecoLocalCalo/HGCalRecProducers/interface/HGCalImagingAlgo.h modified in PR(s): [HGCal] Shrinking Layer Clustering internal data structures #30753
  • File RecoLocalCalo/HGCalRecProducers/plugins/HGCalCLUEAlgo.h modified in PR(s): [HGCal] Shrinking Layer Clustering internal data structures #30753
  • File SimCalorimetry/HGCalSimProducers/python/hgcalDigitizer_cfi.py modified in PR(s): remove phase2_hgcalV9 modifier #30702

[cmsbuild]

The tests are being triggered in jenkins.

• CMSSW_11_2_X_2020-07-16-1100/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/8028/console Started: 2020/07/16 22:48

[cmsbuild]

Pull request #30697 was updated. @perrotta, @civanch, @kpedro88, @cmsbuild, @mdhildreth, @slava77, @jpata can you please check and sign again.

[cmsbuild]

+1
Tested at: b43af76
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ecc5ff/8028/summary.html
CMSSW: CMSSW_11_2_X_2020-07-16-1100
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ecc5ff/8028/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 35
• DQMHistoTests: Total histograms compared: 2612943
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2612894
• DQMHistoTests: Total skipped: 48
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
• Checked 146 log files, 17 edm output root files, 35 DQM output files

[perrotta]

+1

• Changes in reco are consequent to the technical updates in the simulation part
• Having the simulation parameters defined inside the reco producers is not satisfactory in the long term, but it is not the scope of this PR to fix it
• Jenkins tests pass and show no differences, as expected

[civanch]

+1

[kpedro88]

+upgrade

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2)

[silviodonato]

+1