Add to GetterOfProducts support for ProcessBlock

[wddgit]

PR description:

Improve GetterOfProducts so that it can be used to get products from a ProcessBlock. I also updated some comments.

PR validation:

An existing unit test which tests getting products from ProcessBlock was extended to cover the use of GetterOfProducts. This should have no effect on any existing RelVal tests or workflows as nothing is using ProcessBlock yet outside of Framework unit tests.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30737/17049

• This PR adds an extra 36KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File FWCore/Integration/test/TestFindProduct.cc modified in PR(s): [Clang tidy] Apply checks for core #30712

[cmsbuild]

A new Pull Request was created by @wddgit (W. David Dagenhart) for master.

It involves the following packages:

FWCore/Framework
FWCore/Integration

@makortel, @smuzaffar, @cmsbuild, @Dr15Jones can you please review it and eventually sign? Thanks.
@makortel this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

[wddgit]

please test

[cmsbuild]

The tests are being triggered in jenkins.

• CMSSW_11_2_X_2020-07-15-1100/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/7987/console Started: 2020/07/15 22:50

[cmsbuild]

+1
Tested at: 17a2ff1
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ad0413/7987/summary.html
CMSSW: CMSSW_11_2_X_2020-07-15-1100
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ad0413/7987/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 35
• DQMHistoTests: Total histograms compared: 2612943
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2612894
• DQMHistoTests: Total skipped: 48
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
• Checked 146 log files, 17 edm output root files, 35 DQM output files

[makortel]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2)

[silviodonato]

+1