Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Unknown parameter name ClusterShapeCacheSrc specified while calling Modifier #30767

Merged
merged 1 commit into from Jul 17, 2020

Conversation

jeongeun
Copy link
Contributor

PR description:

To Fix the failing workflows issue : PR#30766.
raise KeyError("Unknown parameter name "+key+" specified while calling Modifier") KeyError: 'Unknown parameter name ClusterShapeCacheSrc specified while calling Modifier'

The reference PR is PR#30671 : drop type specs in RecoTracker/{MkFit,MeasurementDet,IterativeTracking}

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30767/17099

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @jeongeun (JeongEun Lee) for master.

It involves the following packages:

RecoTracker/IterativeTracking

@perrotta, @jpata, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@makortel, @felicepantaleo, @GiacomoSguazzoni, @JanFSchulte, @rovere, @VinInn, @mschrode, @gpetruc, @ebrondol, @mtosi, @dgulhan this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

@slava77
Copy link
Contributor

slava77 commented Jul 17, 2020

@cmsbuild please test workflow 1325.2,1325.3,10024.4

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 17, 2020

The tests are being triggered in jenkins.
Test Parameters:

@silviodonato
Copy link
Contributor

urgent

@cmsbuild
Copy link
Contributor

+1
Tested at: 039d5b7
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8d247c/8036/summary.html
CMSSW: CMSSW_11_2_X_2020-07-16-2300
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

Comparison job queued.

@silviodonato
Copy link
Contributor

merge
it is included in the morning IB

@cmsbuild cmsbuild merged commit 288d05d into cms-sw:master Jul 17, 2020
@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8d247c/8036/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-8d247c/10024.4_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017_GenSimFull+DigiFull_2017+RecoFull_trackingLowPU_2017+HARVESTFull_2017
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-8d247c/1325.2_TTbar_13+TTbar_13+DIGIUP15+RECOUP15_trackingLowPU+HARVESTUP15
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-8d247c/1325.3_TTbar_13+TTbar_13+DIGIUP15+RECOUP15_trackingOnlyLowPU+HARVESTUP15_trackingOnly

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 35
  • DQMHistoTests: Total histograms compared: 2612943
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2612894
  • DQMHistoTests: Total skipped: 48
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
  • Checked 146 log files, 17 edm output root files, 35 DQM output files

@jfernan2
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants