Add numberOfValidPixelHits methods with maxLayer/maxDisk

[cerati]

New numberOfValidPixelHits methods taking and argument the maximum layer or disk to consider when counting. Useful to adapt selections to tracker geometry with only pixel layers as in 620SLHCX.

[cmsbuild]

A new Pull Request was created by @cerati for CMSSW_6_2_X_SLHC.

Add numberOfValidPixelHits methods with maxLayer/maxDisk

It involves the following packages:

DataFormats/TrackReco

@nclopezo, @cmsbuild, @anton-a, @thspeer, @slava77, @Degano can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@andersonjacob, @mark-grimes you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

[andersonjacob]

This PR doesn't compile. There is an effect downstream in AnalysisDataFormats/SUSYBSMObjects where the ROOT dictionaries can't be built.

error: class 'susybsm::HSCPCaloInfo' has a different checksum for ClassVersion 11. Increment ClassVersion to 12 and assign it to checksum 2407040083
gmake: *** [tmp/slc5_amd64_gcc472/src/AnalysisDataFormats/SUSYBSMObjects/src/AnalysisDataFormatsSUSYBSMObjects/libAnalysisDataFormatsSUSYBSMObjectsCapabilities.so] Error 1
gmake: *** Waiting for unfinished jobs....

Did you do a check-deps and make sure everything compiled?

[cerati]

I did not do checkdeps because I did not modify existing methods, I just added 3 new ones, which can't break dependent code.
I see the problem is in the checksum... I guess I should add a new class version in classes_def.xml.
Does anybody know how to compute the new checksum?

[cerati]

I do not see how this change can affect the checksum of susybsm::HSCPCaloInfo... anyway, now I am trying to reproduce the problem: checkdeps and compiling - as expected it checked out almost all CMSSW, compilation will take hours

[mark-grimes]

The checksum is calculated automatically and given in the error message Jake posted - "Increment ClassVersion to 12 and assign it to checksum 2407040083". That is the checksum to change it to.

[cerati]

I cannot reproduce the problem, it compiled successfully (CMSSW_6_2_0_SLHC9 with slc5_amd64_gcc472). I can try on the latest IB... but please check everything is ok from your side

[andersonjacob]

We should just check out that package from the latest IB and see if it will
compile or not.

On Mon, Mar 31, 2014 at 8:17 AM, cerati notifications@github.com wrote:

I cannot reproduce the problem, it compiled successfully
(CMSSW_6_2_0_SLHC9 with slc5_amd64_gcc472). I can try on the latest IB...
but please check everything is ok from your side

Reply to this email directly or view it on GitHubhttps://github.com//pull/3078#issuecomment-39056769
.

[cerati]

I tried with CMSSW_6_2_X_SLHC_2014-03-28-0200 updating to HEAD and merging the PR and got no compilation errors

[mark-grimes]

merge

I can't reproduce the problem either. I don't understand how it could break for Jake but work for Giuseppe and me. We'll put it in the Integration Build and see if that builds okay. Currently need to build ~400 packages on top of CMSSW_6_2_X_SLHC_2014-03-28-0200 to get to CMSSW_6_2_X_SLHC plus this pull request.
Tests 10000, 10200, 10400, 11200, 11400, 11600, 11800, 12000, 12800 and 13000 pass all steps.
Tests 12200, 12400, 12600, 13200 and 13400 fail in step 2 with known errors.