[Clang tidy] Apply checks for reconstruction

[cmsbuild]

Apply new clang checks, redone. Apologies for the inconvenience. See #30508 for more info.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

-code-checks

ERROR: Build errors found during clang-tidy run.

RecoBTag/FeatureTools/plugins/DeepFlavourTagInfoProducer.cc:473:1: error: version control conflict marker in file [clang-diagnostic-error]
<<<<<<< HEAD
^
Suppressed 2448 warnings (2439 in non-user code, 8 NOLINT, 1 with check filters).
--
gmake: *** [config/SCRAM/GMake/Makefile.coderules:128: code-checks] Error 2
gmake: *** [There are compilation/build errors. Please see the detail log above.] Error 2

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30805/17147

• This PR adds an extra 20KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File RecoTracker/FinalTrackSelectors/plugins/TrackMerger.cc modified in PR(s): added esConsumes to modules in RecoTracker/FinalTrackSelectors #30812

[cmsbuild]

A new Pull Request was created by @cmsbuild for master.

It involves the following packages:

CommonTools/RecoAlgos
DataFormats/Luminosity
DataFormats/TauReco
EventFilter/HcalRawToDigi
EventFilter/SiPixelRawToDigi
MagneticField/GeomBuilder
RecoBTag/CTagging
RecoBTag/Combined
RecoBTag/FeatureTools
RecoBTag/PerformanceDB
RecoBTag/SecondaryVertex
RecoBTag/SoftLepton
RecoBTau/JetTagComputer
RecoEcal/EgammaClusterAlgos
RecoEgamma/EgammaElectronAlgos
RecoEgamma/EgammaIsolationAlgos
RecoEgamma/EgammaTools
RecoEgamma/ElectronIdentification
RecoEgamma/PhotonIdentification
RecoHI/HiJetAlgos
RecoJets/FFTJetAlgorithms
RecoJets/FFTJetProducers
RecoJets/JetAlgorithms
RecoJets/JetProducers
RecoLocalCalo/EcalDeadChannelRecoveryAlgos
RecoLocalCalo/EcalRecProducers
RecoLocalCalo/HcalRecAlgos
RecoLocalMuon/CSCSegment
RecoLocalMuon/DTSegment
RecoLocalMuon/RPCRecHit
RecoLocalTracker/SiStripClusterizer
RecoLocalTracker/SiStripZeroSuppression
RecoLuminosity/LumiProducer
RecoMET/METPUSubtraction
RecoMuon/MuonIdentification
RecoMuon/TrackingTools
RecoPPS/Local
RecoParticleFlow/PFClusterProducer
RecoParticleFlow/PFProducer
RecoParticleFlow/PFSimProducer
RecoParticleFlow/PFTracking
RecoPixelVertexing/PixelLowPtUtilities
RecoTauTag/RecoTau
RecoTracker/CkfPattern
RecoTracker/ConversionSeedGenerators
RecoTracker/FinalTrackSelectors
RecoTracker/MeasurementDet
RecoTracker/TkDetLayers
RecoTracker/TkHitPairs
RecoTracker/TkSeedingLayers
RecoTracker/TkTrackingRegions
RecoTracker/TransientTrackingRecHit
RecoVertex/GhostTrackFitter
RecoVertex/KalmanVertexFit
RecoVertex/V0Producer
TrackPropagation/SteppingHelixPropagator
TrackingTools/GsfTools
TrackingTools/GsfTracking
TrackingTools/TrackFitters

@perrotta, @jpata, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@echabert, @emilbols, @gouskos, @makortel, @yslai, @felicepantaleo, @jainshilpi, @hatakeyamak, @robervalwalsh, @rappoccio, @argiro, @echapon, @alesaggio, @jazzitup, @mandrenguyen, @ahinzmann, @abbiendi, @varuns23, @seemasharmafnal, @mmarionncern, @smoortga, @HuguesBrun, @JyothsnaKomaragiri, @pieterdavid, @mtosi, @JanFSchulte, @jhgoh, @lgray, @apsallid, @sobhatta, @cericeci, @hqucms, @ferencek, @dkotlins, @yduhm, @rociovilar, @Sam-Harper, @afiqaize, @GiacomoSguazzoni, @rovere, @VinInn, @jdamgov, @bellan, @nhanvtran, @gkasieczka, @threus, @schoef, @mschrode, @ebrondol, @ptcox, @abdoulline, @dgulhan, @clelange, @Martin-Grunewald, @namapane, @jdolen, @rchatter, @trocino, @riga, @battibass, @gbenelli, @Fedespring, @calderona, @mverzett, @yenjie, @lecriste, @kurtejung, @cbernet, @gpetruc, @mariadalfonso, @yetkinyilmaz, @mmusich, @andrzejnovak, @folguera this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

[mrodozov]

please test

[cmsbuild]

The tests are being triggered in jenkins.

• CMSSW_11_2_X_2020-07-17-1100/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/8068/console Started: 2020/07/17 21:20

[cmsbuild]

+1
Tested at: f126e9e
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21bf2b/8068/summary.html
CMSSW: CMSSW_11_2_X_2020-07-17-1100
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[mrodozov]

right, we have to wait for the next IB

[mrodozov]

please test for CMSSW_11_2_X_2020-07-18-1100

[mrodozov]

test parameters:

• release = CMSSW_11_2_X_2020-07-18-1100

[mrodozov]

please test

[cmsbuild]

The tests are being triggered in jenkins.
Test Parameters:

• RELEASE_FORMAT = CMSSW_11_2_X_2020-07-18-1100
• CMSSW_11_2_X_2020-07-18-1100/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/8143/console Started: 2020/07/20 21:29

[cmsbuild]

+1
Tested at: c5d093b
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21bf2b/8143/summary.html
CMSSW: CMSSW_11_2_X_2020-07-18-1100
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21bf2b/8143/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 34
• DQMHistoTests: Total histograms compared: 2525996
• DQMHistoTests: Total failures: 7
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2525942
• DQMHistoTests: Total skipped: 47
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
• Checked 144 log files, 17 edm output root files, 34 DQM output files

[perrotta]

+1

• Technical
• Jenkins tests pass

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2)

[silviodonato]

+1