[Clang tidy] Apply checks for reconstruction-upgrade

[cmsbuild]

Apply new clang checks, redone. Apologies for the inconvenience. See #30508 for more info.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30806/17139

• This PR adds an extra 12KB to repository

[cmsbuild]

A new Pull Request was created by @cmsbuild for master.

It involves the following packages:

RecoLocalCalo/HGCalRecProducers
RecoLocalFastTime/FTLRecProducers
RecoLocalTracker/SiPhase2Clusterizer
RecoMTD/MeasurementDet

@perrotta, @jpata, @cmsbuild, @kpedro88, @slava77 can you please review it and eventually sign? Thanks.
@felicepantaleo, @pfs, @threus, @sethzenz, @makortel, @JanFSchulte, @lgray, @apsallid, @vandreev11, @GiacomoSguazzoni, @rovere, @VinInn, @cseez, @deguio, @hatakeyamak, @ebrondol, @mtosi, @fabiocos, @clelange, @riga, @edjtscott, @lecriste, @gpetruc this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

[mrodozov]

please test

[cmsbuild]

The tests are being triggered in jenkins.

• CMSSW_11_2_X_2020-07-17-1100/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/8075/console Started: 2020/07/17 21:22

[cmsbuild]

+1
Tested at: fd3e443
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7403cf/8075/summary.html
CMSSW: CMSSW_11_2_X_2020-07-17-1100
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7403cf/8075/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 2 differences found in the comparisons
• DQMHistoTests: Total files compared: 34
• DQMHistoTests: Total histograms compared: 2525996
• DQMHistoTests: Total failures: 5
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 2525943
• DQMHistoTests: Total skipped: 47
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.004 KiB( 33 files compared)
• DQMHistoSizes: changed ( 10224.0 ): 0.004 KiB MessageLogger/Warnings
• Checked 144 log files, 17 edm output root files, 34 DQM output files

[slava77]

+1

for #30806 fd3e443

• technical
• no (relevant) changes in test comparisons

[kpedro88]

+upgrade

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2)

[silviodonato]

+1