Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Clang tidy] Apply checks for visualization #30809

Merged
merged 2 commits into from Jul 18, 2020

Conversation

cmsbuild
Copy link
Contributor

Apply new clang checks, redone. Apologies for the inconvenience. See #30508 for more info.

@cmsbuild
Copy link
Contributor Author

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor Author

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30809/17142

  • This PR adds an extra 8KB to repository

@cmsbuild
Copy link
Contributor Author

A new Pull Request was created by @cmsbuild for master.

It involves the following packages:

Fireworks/Core
Fireworks/FWInterface
Fireworks/ParticleFlow

@makortel, @cmsbuild, @Dr15Jones, @alja can you please review it and eventually sign? Thanks.
@alja this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

@mrodozov
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor Author

cmsbuild commented Jul 17, 2020

The tests are being triggered in jenkins.

@alja
Copy link
Contributor

alja commented Jul 17, 2020

+1

@cmsbuild
Copy link
Contributor Author

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2)

@cmsbuild
Copy link
Contributor Author

+1
Tested at: 962a881
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-32c34b/8072/summary.html
CMSSW: CMSSW_11_2_X_2020-07-17-1100
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor Author

Comparison not run due to Fireworks only changes in PR (RelVals and Igprof tests were also skipped)

@silviodonato
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 2e69bdc into master Jul 18, 2020
@smuzaffar smuzaffar deleted the apply-new-ct-checks-for-visualization branch November 6, 2020 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants