RecoHGCal/TICL: optimize calculation for comparison in HGCDoublet::areAligned #30815

gartung · 2020-07-17T19:46:45Z

By squaring cosTheta and multiplying by the squares of the magnitudes an equivalent comparison is made without the division and square root which are costly FP ops.

without PR

Relarted modules:

TimeReport   0.151110     0.151110     0.151110  ticlTrackstersEM
TimeReport   0.244630     0.244630     0.244630  ticlTrackstersHAD
TimeReport   5.448030     5.448030     5.448030  ticlTrackstersMIP
TimeReport   0.489669     0.489669     0.489669  ticlTrackstersMerge
TimeReport   5.136405     5.136405     5.136405  ticlTrackstersTrk

Unrelated modules:

TimeReport   2.788299     2.788299     2.788299  unsortedOfflinePrimaryVertices
TimeReport   3.190056     3.190056     3.190056  unsortedOfflinePrimaryVertices4D
TimeReport   2.398358     2.398358     2.398358  unsortedOfflinePrimaryVertices4DnoPID


MemoryReport> Peak virtual size 16747.1 Mbytes
 Key events increasing vsize:
[5] run: 1 lumi: 1 event: 6  vsize = 12483.1 deltaVsize = 680 rss = 7707.91 delta = 1096.84
[6] run: 1 lumi: 1 event: 2  vsize = 13507.1 deltaVsize = 1024 rss = 7626.52 delta = -81.3906
[11] run: 1 lumi: 1 event: 13  vsize = 15043.1 deltaVsize = 1536 rss = 7504.27 delta = -122.246
[51] run: 1 lumi: 1 event: 54  vsize = 16107.1 deltaVsize = 320 rss = 7668.46 delta = 164.191
[58] run: 1 lumi: 1 event: 59  vsize = 16427.1 deltaVsize = 320 rss = 8162.55 delta = 494.09
[88] run: 1 lumi: 1 event: 90  vsize = 16747.1 deltaVsize = 0 rss = 7822.57 delta = 143.547
[87] run: 1 lumi: 1 event: 91  vsize = 16747.1 deltaVsize = 0 rss = 7898.27 delta = 219.254
[86] run: 1 lumi: 1 event: 87  vsize = 16747.1 deltaVsize = 320 rss = 7679.02 delta = -483.535
TimeReport> Time report complete in 3095.72 seconds
 Time Summary:
 - Min event:   74.3302
 - Max event:   191.179
 - Avg event:   117.212
 - Total loop:  3024.91
 - Total init:  70.7418
 - Total job:   3095.72
 - EventSetup Lock:   0
 - EventSetup Get:   0
 Event Throughput: 0.0330588 ev/s
 CPU Summary:
 - Total loop:  11994.8
 - Total init:  44.139
 - Total extra: 0
 - Total job:   12039
 Processing Summary:
 - Number of Events:  100
 - Number of Global Begin Lumi Calls:  1
 - Number of Global Begin Run Calls: 1

with PR

Related modules

TimeReport   0.137062     0.137062     0.137062  ticlTrackstersEM
TimeReport   0.220417     0.220417     0.220417  ticlTrackstersHAD
TimeReport   4.989291     4.989291     4.989291  ticlTrackstersMIP
TimeReport   0.463667     0.463667     0.463667  ticlTrackstersMerge
TimeReport   4.469128     4.469128     4.469128  ticlTrackstersTrk

Unrelated modules

TimeReport   2.601440     2.601440     2.601440  unsortedOfflinePrimaryVertices
TimeReport   2.993901     2.993901     2.993901  unsortedOfflinePrimaryVertices4D
TimeReport   2.244631     2.244631     2.244631  unsortedOfflinePrimaryVertices4DnoPID


MemoryReport> Peak virtual size 17345.9 Mbytes
 Key events increasing vsize:
[3] run: 1 lumi: 1 event: 7  vsize = 12805.9 deltaVsize = 288 rss = 6317.03 delta = -843.027
[4] run: 1 lumi: 1 event: 1  vsize = 13229.9 deltaVsize = 424 rss = 6637.75 delta = 320.719
[10] run: 1 lumi: 1 event: 10  vsize = 16045.9 deltaVsize = 2560 rss = 7548.33 delta = 910.582
[61] run: 1 lumi: 1 event: 65  vsize = 17345.9 deltaVsize = 394 rss = 7922.04 delta = 373.711
[27] run: 1 lumi: 1 event: 28  vsize = 16621.9 deltaVsize = 320 rss = 8049.02 delta = 500.691
[63] run: 1 lumi: 1 event: 68  vsize = 17345.9 deltaVsize = 0 rss = 7725.5 delta = -196.539
[62] run: 1 lumi: 1 event: 48  vsize = 17345.9 deltaVsize = 0 rss = 7909.17 delta = -12.8672
[61] run: 1 lumi: 1 event: 65  vsize = 17345.9 deltaVsize = 394 rss = 7922.04 delta = -205.59
TimeReport> Time report complete in 2889.58 seconds
 Time Summary:
 - Min event:   69.4932
 - Max event:   169.038
 - Avg event:   109.613
 - Total loop:  2820.21
 - Total init:  69.3035
 - Total job:   2889.58
 - EventSetup Lock:   0
 - EventSetup Get:   0
 Event Throughput: 0.0354584 ev/s
 CPU Summary:
 - Total loop:  11197.6
 - Total init:  36.5688
 - Total extra: 0
 - Total job:   11234.3
 Processing Summary:
 - Number of Events:  100
 - Number of Global Begin Lumi Calls:  1
 - Number of Global Begin Run Calls: 1

…eAligned By squaring cosTheta and multiplying by the squares of the magnitudes an equivalent comparison is made without the division and square root which are costly FP ops.

cmsbuild · 2020-07-17T19:47:06Z

The code-checks are being triggered in jenkins.

cmsbuild · 2020-07-17T19:52:28Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30815/17150

This PR adds an extra 16KB to repository

cmsbuild · 2020-07-17T19:52:50Z

A new Pull Request was created by @gartung (Patrick Gartung) for master.

It involves the following packages:

RecoHGCal/TICL

@perrotta, @jpata, @cmsbuild, @kpedro88, @slava77 can you please review it and eventually sign? Thanks.
@felicepantaleo, @riga, @apsallid, @sobhatta, @lecriste, @hatakeyamak, @clelange this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

slava77 · 2020-07-17T19:56:42Z

@cmsbuild please test

cmsbuild · 2020-07-17T19:57:04Z

The tests are being triggered in jenkins.

CMSSW_11_2_X_2020-07-17-1100/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/8094/console Started: 2020/07/17 22:24

cmsbuild · 2020-07-17T21:28:31Z

+1
Tested at: a9840a9
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3ef9f6/8094/summary.html
CMSSW: CMSSW_11_2_X_2020-07-17-1100
SCRAM_ARCH: slc7_amd64_gcc820

cmsbuild · 2020-07-17T21:28:34Z

Comparison job queued.

cmsbuild · 2020-07-18T03:33:38Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3ef9f6/8094/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 2 differences found in the comparisons
DQMHistoTests: Total files compared: 34
DQMHistoTests: Total histograms compared: 2525996
DQMHistoTests: Total failures: 5
DQMHistoTests: Total nulls: 1
DQMHistoTests: Total successes: 2525943
DQMHistoTests: Total skipped: 47
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.004 KiB( 33 files compared)
DQMHistoSizes: changed ( 10224.0 ): 0.004 KiB MessageLogger/Warnings
Checked 144 log files, 17 edm output root files, 34 DQM output files

kpedro88 · 2020-07-20T15:08:32Z

+upgrade

…when debugging is enabled.

cmsbuild · 2020-07-21T16:09:22Z

+1
Tested at: cc44839
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3ef9f6/8172/summary.html
CMSSW: CMSSW_11_2_X_2020-07-21-1100
SCRAM_ARCH: slc7_amd64_gcc820

cmsbuild · 2020-07-21T16:09:24Z

Comparison job queued.

cmsbuild · 2020-07-21T18:20:55Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3ef9f6/8172/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 4 differences found in the comparisons
DQMHistoTests: Total files compared: 34
DQMHistoTests: Total histograms compared: 2525996
DQMHistoTests: Total failures: 5
DQMHistoTests: Total nulls: 1
DQMHistoTests: Total successes: 2525943
DQMHistoTests: Total skipped: 47
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: -0.004 KiB( 33 files compared)
DQMHistoSizes: changed ( 10224.0 ): -0.004 KiB MessageLogger/Warnings
Checked 144 log files, 17 edm output root files, 34 DQM output files

slava77 · 2020-07-21T18:50:57Z

+1

for #30815 cc44839

code changes are in line with the PR description and the follow up comments from the community ( @VinInn; https://mattermost.web.cern.ch/cms-o-and-c/pl/9c4k99je3b8ptbzwsccu5j7cxa)
jenkins tests pass and comparisons with the baseline show no relevant differences, as expected from a technical update
- timing report provided with the PR description suggests about 4% speedup in ticlTracksters* modules (after scaling to provided times in unrelated modules)

kpedro88 · 2020-07-21T18:53:51Z

+upgrade

cmsbuild · 2020-07-21T18:54:09Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2)

silviodonato · 2020-07-22T07:28:53Z

+1

RecoHGCal/TICL: optimize calculation for comparison in HGCDoublet::ar…

a9840a9

…eAligned By squaring cosTheta and multiplying by the squares of the magnitudes an equivalent comparison is made without the division and square root which are costly FP ops.

cmsbuild added this to the CMSSW_11_2_X milestone Jul 17, 2020

cmsbuild added code-checks-pending comparison-pending orp-pending pending-signatures reconstruction-pending tests-pending upgrade-pending labels Jul 17, 2020

cmsbuild added code-checks-approved and removed code-checks-pending labels Jul 17, 2020

cmsbuild added tests-started and removed tests-pending labels Jul 17, 2020

cmsbuild added tests-approved and removed tests-started labels Jul 17, 2020

cmsbuild added comparison-available and removed comparison-pending labels Jul 18, 2020

cmsbuild added upgrade-approved and removed upgrade-pending labels Jul 20, 2020

Store results used in debug message so they are not calculated twice …

cc44839

…when debugging is enabled.

cmsbuild removed the code-checks-approved label Jul 20, 2020

cmsbuild added tests-approved and removed tests-started labels Jul 21, 2020

cmsbuild added comparison-available and removed comparison-pending labels Jul 21, 2020

cmsbuild added reconstruction-approved and removed reconstruction-pending labels Jul 21, 2020

cmsbuild added fully-signed upgrade-approved and removed pending-signatures upgrade-pending labels Jul 21, 2020

cmsbuild added orp-approved and removed orp-pending labels Jul 22, 2020

cmsbuild merged commit e2bf145 into cms-sw:master Jul 22, 2020

cmsbuild mentioned this pull request Jul 22, 2020

drop wrong default params in TLorentzVector in TestCorrections.C #30872

Merged

gartung deleted the gartung-RecoHGCal-TICL-HGCDoublet-areAlinged-opt branch July 24, 2020 16:00

slava77 mentioned this pull request Jul 28, 2020

phase-2 reco CPU hotspot: HGCDoublet::checkCompatibilityAndTag #30957

Closed

rovere pushed a commit to rovere/cmssw that referenced this pull request Oct 16, 2020

Backport of cms-sw#30815

eba07fd

rovere pushed a commit to rovere/cmssw that referenced this pull request Oct 22, 2020

Backport of cms-sw#30815

1fb321d

rovere pushed a commit to rovere/cmssw that referenced this pull request Oct 30, 2020

Backport of cms-sw#30815

9a0ba47

rovere pushed a commit to rovere/cmssw that referenced this pull request Nov 8, 2020

Backport of cms-sw#30815

c39d841

rovere pushed a commit to rovere/cmssw that referenced this pull request Nov 15, 2020

Backport of cms-sw#30815

e46e054

perrotta mentioned this pull request Nov 19, 2020

TICL reconstruction update #31907

Merged

slava77 mentioned this pull request Apr 8, 2021

[HGCAL] EDAnalyzer for TICL tracksters validation #33360

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

RecoHGCal/TICL: optimize calculation for comparison in HGCDoublet::areAligned #30815

RecoHGCal/TICL: optimize calculation for comparison in HGCDoublet::areAligned #30815

gartung commented Jul 17, 2020 •

edited

Loading

cmsbuild commented Jul 17, 2020

cmsbuild commented Jul 17, 2020

cmsbuild commented Jul 17, 2020

slava77 commented Jul 17, 2020

cmsbuild commented Jul 17, 2020 •

edited

Loading

cmsbuild commented Jul 17, 2020

cmsbuild commented Jul 17, 2020

cmsbuild commented Jul 18, 2020

kpedro88 commented Jul 20, 2020

cmsbuild commented Jul 21, 2020

cmsbuild commented Jul 21, 2020

cmsbuild commented Jul 21, 2020

slava77 commented Jul 21, 2020

kpedro88 commented Jul 21, 2020

cmsbuild commented Jul 21, 2020

silviodonato commented Jul 22, 2020

RecoHGCal/TICL: optimize calculation for comparison in HGCDoublet::areAligned #30815

RecoHGCal/TICL: optimize calculation for comparison in HGCDoublet::areAligned #30815

Conversation

gartung commented Jul 17, 2020 • edited Loading

cmsbuild commented Jul 17, 2020

cmsbuild commented Jul 17, 2020

cmsbuild commented Jul 17, 2020

slava77 commented Jul 17, 2020

cmsbuild commented Jul 17, 2020 • edited Loading

cmsbuild commented Jul 17, 2020

cmsbuild commented Jul 17, 2020

cmsbuild commented Jul 18, 2020

kpedro88 commented Jul 20, 2020

cmsbuild commented Jul 21, 2020

cmsbuild commented Jul 21, 2020

cmsbuild commented Jul 21, 2020

slava77 commented Jul 21, 2020

kpedro88 commented Jul 21, 2020

cmsbuild commented Jul 21, 2020

silviodonato commented Jul 22, 2020

gartung commented Jul 17, 2020 •

edited

Loading

cmsbuild commented Jul 17, 2020 •

edited

Loading