[HGCAL] EDAnalyzer for TICL tracksters validation

[ebrondol]

PR description:

This PR introduce an EDAnalyzer for TICL Tracksters. In this moment the tracksters are validated using the MultiClusters object, while this analyzer takes directly the trackster objects. It also include a validation of the edges, this is why it is specified in the name. Currently we do not save the edges information and for this reason the analyzer is not run by default.
Once the analyzer is run, additional plots are included in the DQM root file and produced automatically with the makeHGCalValidationPlots.py script:

In the future, we plan to review time and memory to save the edges and to run analyzer by default.

PR validation:

• workflow 23293.0 run with and without the analyzer

@apsallid @lecriste @rovere @felicepantaleo

[ebrondol]

It would be good to know if someone in the Track reco group has some problem with our changes in Validation/RecoTrack/python/plotting/plotting.py. Can we ping somebody there?

[lecriste]

It would be good to know if someone in the Track reco group has some problem with our changes in Validation/RecoTrack/python/plotting/plotting.py. Can we ping somebody there?

I have informed Mia Tosi and Valentina Mariani when I did the change.

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-250d84/14105/summary.html
COMMIT: d87de01
CMSSW: CMSSW_11_3_X_2021-04-08-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/33360/14105/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 38
• DQMHistoTests: Total histograms compared: 2865506
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2865483
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 9.836 KiB( 37 files compared)
• DQMHistoSizes: changed ( 23234.0,... ): 2.459 KiB HGCAL/HGCalValidator
• Checked 160 log files, 37 edm output root files, 38 DQM output files
• TriggerResults: no differences found

[slava77]

+reconstruction

for #33360 d87de01

• code changes in reco category are rather straightforward, in RecoHGCal/TICL/plugins/HGCDoublet.cc in LogDebug, which now includes more data and is partly also improving on RecoHGCal/TICL: optimize calculation for comparison in HGCDoublet::areAligned #30815.

[jfernan2]

+1

[civanch]

+1

[srimanob]

Looking at DQM as attached, two of them have no directory name, is this because they are empty?
https://tinyurl.com/yflwjfjj

[jfernan2]

@srimanob No, just the names of the folders are too large for the letter size chosen. Please select large or fill in the Size menu at the left of the tool bar

[srimanob]

+Upgrade

Thanks @jfernan2

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1