New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run3-hcx261 Adopt the validation tool for dd4hep application #30837
Conversation
The code-checks are being triggered in jenkins. |
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30837/17177
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30837/17180
|
A new Pull Request was created by @bsunanda for master. It involves the following packages: Validation/Geometry @andrius-k, @Dr15Jones, @makortel, @cvuosalo, @schneiml, @ianna, @mdhildreth, @cmsbuild, @kmaeshima, @jfernan2, @fioriNTU, @civanch can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild Please test |
The tests are being triggered in jenkins.
|
-1 Tested at: a2630a9 CMSSW: CMSSW_11_2_X_2020-07-20-1100 I found follow errors while testing this PR Failed tests: RelVals
When I ran the RelVals I found an error in the following workflows: runTheMatrix-results/1330.0_ZMM_13+ZMM_13+DIGIUP15+RECOUP15_L1TMuDQM+HARVESTUP15_L1TMuDQM+NANOUP15/step5_ZMM_13+ZMM_13+DIGIUP15+RECOUP15_L1TMuDQM+HARVESTUP15_L1TMuDQM+NANOUP15.log |
Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped) |
Looks good. Are the PR tests working now? |
@cmsbuild Please test |
The tests are being triggered in jenkins.
|
+1 |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
(*job)()->get<IdealGeometryRecord>().get(pDD); | ||
if (theHistoHcal_) | ||
theHistoHcal_->fillBeginJob((*pDD)); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Both if/else options do the same?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes they do - but the 2 pDD's are different type of objects DDCompactView vs cms::DDCompactView - one works for DDD and the other for DD4Hep. I think this may be the simplest construct.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, I see. Thanks
+1 |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
Adopt the validation tool for material budget study in HCAL to dd4hep application
PR validation:
Tested using the workflows in Validation/Geometry/test for DDD as well as DD4Hep
if this PR is a backport please specify the original PR and why you need to backport that PR:
Nothing special