Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add topology class for Shashlik #3086

Merged
merged 1 commit into from Mar 29, 2014

Conversation

andersonjacob
Copy link
Contributor

Sunanda's Shashlik07 was giving me merge problems so I've re-based it solve the conflicts and created a new pull request.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @andersonjacob for CMSSW_6_2_X_SLHC.

Add topology class for Shashlik

It involves the following packages:

Geometry/CaloEventSetup
Geometry/CaloTopology
Geometry/Records

@civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @nclopezo, @Degano, @ktf can you please review it and eventually sign? Thanks.
@ghellwig this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@andersonjacob, @mark-grimes you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@andersonjacob
Copy link
Contributor Author

merge

passes tests with only known failures.

cmsbuild added a commit that referenced this pull request Mar 29, 2014
@cmsbuild cmsbuild merged commit 3275f0f into cms-sw:CMSSW_6_2_X_SLHC Mar 29, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants