Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Memory efficient implementation of timing information for HGCDigitizer module for Premix Workflow. #30867

Merged
merged 3 commits into from Aug 6, 2020
Merged

Memory efficient implementation of timing information for HGCDigitizer module for Premix Workflow. #30867

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b8e7a32
Tue7_21_Commit-1
adas1994 Jul 21, 2020
d71814e
Tue7_21_Commit-2
adas1994 Jul 21, 2020
66cc323
Tue7_21_Commit-3
adas1994 Jul 21, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions SimCalorimetry/HGCalSimProducers/interface/HGCDigitizer.h
View file
Open in desktop
Expand Up @@ -153,6 +153,7 @@ class HGCDigitizer {
static const unsigned int thisBx_ = 9;
std::vector<float> cce_;
std::unordered_map<uint32_t, std::vector<std::pair<float, float> > > hitRefs_bx0;
std::unordered_map<uint32_t, std::vector<std::tuple<float, float, float> > > PhitRefs_bx0;
std::unordered_map<uint32_t, bool> hitOrder_monitor;
};

Expand Down
87 changes: 79 additions & 8 deletions SimCalorimetry/HGCalSimProducers/src/HGCDigitizer.cc
View file
Open in desktop
Expand Up @@ -25,8 +25,13 @@
//#define EDM_ML_DEBUG
using namespace std;
using namespace hgc_digi;

typedef std::vector<std::pair<float, float>>::iterator itr;
typedef std::map<uint32_t, std::vector<std::pair<float, float>>> IdHit_Map;
typedef std::unordered_map<uint32_t, std::vector<std::pair<float, float>>> IdHit_Map;
typedef std::tuple<float, float, float> hit_timeStamp;
typedef std::unordered_map<uint32_t, std::vector<hit_timeStamp>> hitRec_container;
typedef std::vector<hit_timeStamp>::iterator hitRec_itr;

namespace {

constexpr std::array<double, 4> occupancyGuesses = {{0.5, 0.2, 0.2, 0.8}};
Expand Down Expand Up @@ -143,8 +148,6 @@ namespace {
simResult.shrink_to_fit();
}

typedef std::vector<std::pair<float, float>>::iterator itr;
typedef std::unordered_map<uint32_t, std::vector<std::pair<float, float>>> IdHit_Map;
template <typename GEOM>
void loadSimHitAccumulator_forPreMix(hgc::HGCSimHitDataAccumulator& simData,
hgc::HGCPUSimHitDataAccumulator& PUSimData,
Expand Down Expand Up @@ -338,7 +341,9 @@ void HGCDigitizer::initializeEvent(edm::Event const& e, edm::EventSetup const& e
//
void HGCDigitizer::finalizeEvent(edm::Event& e, edm::EventSetup const& es, CLHEP::HepRandomEngine* hre) {
hitRefs_bx0.clear();
PhitRefs_bx0.clear();
hitOrder_monitor.clear();

const CaloSubdetectorGeometry* theGeom = (nullptr == gHGCal_ ? static_cast<const CaloSubdetectorGeometry*>(gHcal_)
: static_cast<const CaloSubdetectorGeometry*>(gHGCal_));

Expand Down Expand Up @@ -416,6 +421,7 @@ void HGCDigitizer::accumulate_forPreMix(edm::Event const& e,
edm::EventSetup const& eventSetup,
CLHEP::HepRandomEngine* hre) {
//get inputs

edm::Handle<edm::PCaloHitContainer> hits;
e.getByLabel(edm::InputTag("g4SimHits", hitCollection_), hits);
if (!hits.isValid()) {
Expand Down Expand Up @@ -508,9 +514,11 @@ void HGCDigitizer::accumulate_forPreMix(edm::Handle<edm::PCaloHitContainer> cons
return;

float keV2fC(0.f);
//configuration to apply for the computation of time-of-flight
std::array<float, 3> tdcForToAOnset{{0.f, 0.f, 0.f}};

int nchits = (int)hits->size();

int count_thisbx = 0;
std::vector<HGCCaloHitTuple_t> hitRefs;
hitRefs.reserve(nchits);
for (int i = 0; i < nchits; ++i) {
Expand All @@ -530,7 +538,6 @@ void HGCDigitizer::accumulate_forPreMix(edm::Handle<edm::PCaloHitContainer> cons
if (!validIds_.count(id))
continue;

HGCPUSimHitDataAccumulator::iterator simHitIt = pusimHitAccumulator_->emplace(id, HGCCellHitInfo()).first;
if (id == 0)
continue;

Expand All @@ -545,17 +552,81 @@ void HGCDigitizer::accumulate_forPreMix(edm::Handle<edm::PCaloHitContainer> cons
if (itime < 0 || itime > (int)maxBx_)
continue;

if (itime >= (int)simHitIt->second.PUhit_info[0].size())
if (itime >= (int)(maxBx_ + 1))
continue;
(simHitIt->second).PUhit_info[1][itime].push_back(tof);
(simHitIt->second).PUhit_info[0][itime].push_back(charge);

int waferThickness = getCellThickness(geom, id);
if (itime == (int)thisBx_) {
++count_thisbx;
if (PhitRefs_bx0[id].empty()) {
PhitRefs_bx0[id].emplace_back(charge, charge, tof);
} else if (tof > std::get<2>(PhitRefs_bx0[id].back())) {
PhitRefs_bx0[id].emplace_back(charge, charge + std::get<1>(PhitRefs_bx0[id].back()), tof);
} else if (tof == std::get<2>(PhitRefs_bx0[id].back())) {
std::get<0>(PhitRefs_bx0[id].back()) += charge;
std::get<1>(PhitRefs_bx0[id].back()) += charge;
} else {
//find position to insert new entry preserving time sorting
hitRec_itr findPos =
std::upper_bound(PhitRefs_bx0[id].begin(),
PhitRefs_bx0[id].end(),
hit_timeStamp(charge, 0.f, tof),
[](const auto& i, const auto& j) { return std::get<2>(i) <= std::get<2>(j); });

hitRec_itr insertedPos = findPos;

if (tof == std::get<2>(*(findPos - 1))) {
std::get<0>(*(findPos - 1)) += charge;
std::get<1>(*(findPos - 1)) += charge;

} else {
insertedPos = PhitRefs_bx0[id].insert(findPos,
(findPos == PhitRefs_bx0[id].begin())
? hit_timeStamp(charge, charge, tof)
: hit_timeStamp(charge, charge + std::get<1>(*(findPos - 1)), tof));
}
//cumulate the charge of new entry for all elements that follow in the sorted list
//and resize list accounting for cases when the inserted element itself crosses the threshold

for (hitRec_itr step = insertedPos; step != PhitRefs_bx0[id].end(); ++step) {
if (step != insertedPos)
std::get<1>(*(step)) += charge;

// resize the list stopping with the first timeStamp with cumulative charge above threshold
if (std::get<1>(*step) > tdcForToAOnset[waferThickness - 1] &&
std::get<2>(*step) != std::get<2>(PhitRefs_bx0[id].back())) {
PhitRefs_bx0[id].resize(
std::upper_bound(PhitRefs_bx0[id].begin(),
PhitRefs_bx0[id].end(),
hit_timeStamp(charge, 0.f, std::get<2>(*step)),
[](const auto& i, const auto& j) { return std::get<2>(i) < std::get<2>(j); }) -
PhitRefs_bx0[id].begin());
for (auto stepEnd = step + 1; stepEnd != PhitRefs_bx0[id].end(); ++stepEnd)
std::get<1>(*stepEnd) += charge;
break;
}
}
}
}
}

for (const auto& hitCollection : PhitRefs_bx0) {
const uint32_t detectorId = hitCollection.first;
auto simHitIt = pusimHitAccumulator_->emplace(detectorId, HGCCellHitInfo()).first;

for (const auto& hit_timestamp : PhitRefs_bx0[detectorId]) {
(simHitIt->second).PUhit_info[1][thisBx_].push_back(std::get<2>(hit_timestamp));
(simHitIt->second).PUhit_info[0][thisBx_].push_back(std::get<0>(hit_timestamp));
}
}

if (nchits == 0) {
HGCPUSimHitDataAccumulator::iterator simHitIt = pusimHitAccumulator_->emplace(0, HGCCellHitInfo()).first;
(simHitIt->second).PUhit_info[1][9].push_back(0.0);
(simHitIt->second).PUhit_info[0][9].push_back(0.0);
}
hitRefs.clear();
PhitRefs_bx0.clear();
}

//
Expand Down