Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update TSG tests from 2017 real data to 2018 real data (11_1_X) #30884

Merged

Conversation

Martin-Grunewald
Copy link
Contributor

PR description:

Update TSG tests from 2017 real data to 2018 real data (11_1_X)
Based on CMSSW_11_1_2_patch1

PR validation:

TSG tests

if this PR is a backport please specify the original PR and why you need to backport that PR:

Backport of #30882

Avoid flood of error messages in log files of tests

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 23, 2020

A new Pull Request was created by @Martin-Grunewald (Martin Grunewald) for CMSSW_11_1_X.

It involves the following packages:

Configuration/HLT
HLTrigger/Configuration

@cmsbuild, @Martin-Grunewald, @fwyzard can you please review it and eventually sign? Thanks.
@makortel, @fabiocos this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

@Martin-Grunewald
Copy link
Contributor Author

backport of #30882

@Martin-Grunewald
Copy link
Contributor Author

type bug-fix

@Martin-Grunewald
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 23, 2020

The tests are being triggered in jenkins.

@Martin-Grunewald
Copy link
Contributor Author

abort

@cmsbuild
Copy link
Contributor

Jenkins tests are aborted.

@cmsbuild
Copy link
Contributor

Pull request #30884 was updated. @cmsbuild, @Martin-Grunewald, @fwyzard can you please check and sign again.

@Martin-Grunewald
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 24, 2020

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+1
Tested at: 827062f
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d69d19/8260/summary.html
CMSSW: CMSSW_11_1_X_2020-07-23-2300
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d69d19/8260/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 36
  • DQMHistoTests: Total histograms compared: 2780792
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2780741
  • DQMHistoTests: Total skipped: 50
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 35 files compared)
  • Checked 152 log files, 16 edm output root files, 36 DQM output files

@Martin-Grunewald
Copy link
Contributor Author

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_11_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@silviodonato
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 5b0f149 into cms-sw:CMSSW_11_1_X Jul 25, 2020
@Martin-Grunewald Martin-Grunewald deleted the UpdateTSGtestsTo2018for111X branch October 27, 2021 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants