Move ModelpMSSMFilter to src

[mmrowietz]

PR description:

The ModelpMSSMFilter was backported to this CMSSW version as part of the Run-II pMSSM effort. In newer versions of CMSSW, GenFilters like the ModelpMSSMFilter are put into the plugins directory in GeneratorInterface/GenFilters/plugins. The plugins directory is not built in this version of CMSSW, which means the ModelpMSSMFilter has to be in the src directory (like all the other GenFilters).
No output changed are expected by this, and no other PRs are expected to be affected.
The relevant backports are:
backport of filter
backport of fixes
This PR was already done in CMSSW_9_4_X
CMSSW_9_4_X version

PR validation:

PR validation:

A test fragment containing the filter was successfully converted to a config using cmsDriver and run with cmsRun.

[mmrowietz]

please test

[cmsbuild]

A new Pull Request was created by @mmrowietz for CMSSW_10_2_X.

It involves the following packages:

GeneratorInterface/GenFilters

@SiewYan, @mkirsano, @cmsbuild, @GurpreetSinghChahal, @agrohsje, @alberto-sanchez, @qliphy can you please review it and eventually sign? Thanks.
@alberto-sanchez, @agrohsje, @mkirsano this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[mmrowietz]

please test

[ssekmen]

please test

[cmsbuild]

The tests are being triggered in jenkins.

• CMSSW_10_2_X_2020-07-24-1100/slc6_amd64_gcc700: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/8266/console Started: 2020/07/24 12:49

[cmsbuild]

+1
Tested at: 11ec98e
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-185413/8266/summary.html
CMSSW: CMSSW_10_2_X_2020-07-24-1100
SCRAM_ARCH: slc6_amd64_gcc700

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-185413/8266/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 2 differences found in the comparisons
• DQMHistoTests: Total files compared: 31
• DQMHistoTests: Total histograms compared: 3007544
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3007353
• DQMHistoTests: Total skipped: 190
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 30 files compared)
• Checked 129 log files, 14 edm output root files, 31 DQM output files

[silviodonato]

@alberto-sanchez @SiewYan @qliphy @GurpreetSinghChahal @mkirsano @agrohsje can we merge this PR?

[davidlange6]

just to correct a comment above - plugins directories are built in this CMSSW release. They do however, need a build file in the plugins directory in order to specify how the plugins should be built (just as in the current master branch).

[qliphy]

+generators

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[silviodonato]

+1