remove hltSiPixelPhase1TrackClustersAnalyzer from path

[mmusich]

resolves #30911

PR description:

As discussed in #30911 (comment) this proposes a minimal fix, by removing hltSiPixelPhase1TrackClustersAnalyzer from being executed (it was not giving any meaningful outcome anyway).
The real bug-fix should still be validated and is expected in the coming weeks.

PR validation:

I've run wf. 11634.0 and step3 does not get any warning.

if this PR is a backport please specify the original PR and why you need to backport that PR:

This PR is not a backport.

cc:
@mtosi @arossi83

[cmsbuild]

The code-checks are being triggered in jenkins.

[mmusich]

@cmsbuild, please test

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30912/17308

• This PR adds an extra 16KB to repository

[cmsbuild]

The tests are being triggered in jenkins.

• CMSSW_11_2_X_2020-07-25-1100/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/8287/console Started: 2020/07/25 16:22

[cmsbuild]

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

DQMOffline/Trigger

@andrius-k, @kmaeshima, @schneiml, @cmsbuild, @jfernan2, @fioriNTU can you please review it and eventually sign? Thanks.
@missirol, @mtosi, @Fedespring, @calderona, @HuguesBrun, @jhgoh, @cericeci, @trocino, @folguera, @rociovilar this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

-1

Tested at: 10a1958

CMSSW: CMSSW_11_2_X_2020-07-25-1100
SCRAM_ARCH: slc7_amd64_gcc820
You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8a06dd/8287/summary.html

I found follow errors while testing this PR

Failed tests: RelVals

• RelVals:

When I ran the RelVals I found an error in the following workflows:
10042.0 step3

runTheMatrix-results/10042.0_ZMM_13+ZMM_13TeV_TuneCUETP8M1_2017_GenSimFull+DigiFull_2017+RecoFull_2017+HARVESTFull_2017+ALCAFull_2017+NanoFull_2017/step3_ZMM_13+ZMM_13TeV_TuneCUETP8M1_2017_GenSimFull+DigiFull_2017+RecoFull_2017+HARVESTFull_2017+ALCAFull_2017+NanoFull_2017.log

10024.0 step3

runTheMatrix-results/10024.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017_GenSimFull+DigiFull_2017+RecoFull_2017+HARVESTFull_2017+ALCAFull_2017+NanoFull_2017/step3_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017_GenSimFull+DigiFull_2017+RecoFull_2017+HARVESTFull_2017+ALCAFull_2017+NanoFull_2017.log

10824.0 step3

runTheMatrix-results/10824.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2018_GenSimFull+DigiFull_2018+RecoFull_2018+HARVESTFull_2018+ALCAFull_2018+NanoFull_2018/step3_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2018_GenSimFull+DigiFull_2018+RecoFull_2018+HARVESTFull_2018+ALCAFull_2018+NanoFull_2018.log

10224.0 step3

runTheMatrix-results/10224.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017PU_GenSimFull+DigiFullPU_2017PU+RecoFullPU_2017PU+HARVESTFullPU_2017PU+NanoFull_2017PU/step3_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017PU_GenSimFull+DigiFullPU_2017PU+RecoFullPU_2017PU+HARVESTFullPU_2017PU+NanoFull_2017PU.log

[cmsbuild]

Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped)

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30912/17312

• This PR adds an extra 16KB to repository

[mmusich]

When I ran the RelVals I found an error in the following workflows

This begs a bit the question of what is the purpose of running the HLT monitoring in workflows in which only a fake HLT is run.

[cmsbuild]

Pull request #30912 was updated. @andrius-k, @kmaeshima, @schneiml, @cmsbuild, @jfernan2, @fioriNTU can you please check and sign again.

[mmusich]

@cmsbuild, please test

[cmsbuild]

The tests are being triggered in jenkins.

• CMSSW_11_2_X_2020-07-25-1100/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/8291/console Started: 2020/07/25 18:34

[cmsbuild]

+1
Tested at: 29608eb
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8a06dd/8291/summary.html
CMSSW: CMSSW_11_2_X_2020-07-25-1100
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8a06dd/8291/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 35 differences found in the comparisons
• DQMHistoTests: Total files compared: 34
• DQMHistoTests: Total histograms compared: 2525444
• DQMHistoTests: Total failures: 9
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2525388
• DQMHistoTests: Total skipped: 47
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -20185.41 KiB( 33 files compared)
• DQMHistoSizes: changed ( 10024.0,... ): -3364.235 KiB HLT/Pixel
• Checked 144 log files, 17 edm output root files, 34 DQM output files

[jfernan2]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[silviodonato]

@mmusich could you comment on the differences https://cmssdt.cern.ch/SDT/jenkins-artifacts/baseLineComparisons/CMSSW_11_2_X_2020-07-25-1100+8a06dd/37969/validateJR/all_mini_OldVSNew_TTbar14TeV2026D60wf28234p0/all_mini_OldVSNew_TTbar14TeV2026D60wf28234p0c_patTaus_slimmedTaus__RECO_obj___tauIDs__75__second.png ?

[silviodonato]

+1
differences are not related to this PR
(see https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3822eb/8290/summary.html
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8e562d/8292/summary.html )

[mmusich]

@silviodonato I think that's spurious, it cannot come from the changes I propose here.
Can't it be related to this PR: #30919 ?
I see in the description:

I expect that this should get rid of non-reproducible behavior in phase-2 workflows in tau ID outputs

so my take is that currently there are irreproducibilities in tau reconstruction in phase-2.