Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DB utilties for SiPixelVCal #30924

Merged
merged 6 commits into from Aug 3, 2020
Merged

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Jul 27, 2020

PR description:

This PR adds few utilities to be able to inspect payloads of the type SiPixelVCal introduced in PR #29829.
It does:

  • introduce a series of classes for the Pixel Payload Inspector to plot payloads of the type SiPixelVCal;
  • adds amenities to dump,fetch, import the new DB format;
  • improves the related unit-tests;
  • in order to avoid replication of boiter-plate code a couple of new getter methods: SiPixelVCal::getAllSlopes() and SiPixelVCal::getAllOffsets() are added to the CondFormat.

Here is an example of plot that can be produced with the new code:

image

PR validation:

Relies on the exiting unit-tests, which have been upgraded in this PR.

if this PR is a backport please specify the original PR and why you need to backport that PR:

Not a backport and no backport is needed.
cc:
@tvami

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@mmusich
Copy link
Contributor Author

mmusich commented Jul 27, 2020

@cmsbuild , please test

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30924/17327

  • This PR adds an extra 36KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 27, 2020

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

CondCore/SiPixelPlugins
CondCore/Utilities
CondFormats/SiPixelObjects

@christopheralanwest, @tocheng, @cmsbuild, @tlampen, @ggovi, @pohsun can you please review it and eventually sign? Thanks.
@mmusich, @dkotlins, @tocheng, @seemasharmafnal, @VinInn this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

+1
Tested at: c83f5d5
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-97cded/8311/summary.html
CMSSW: CMSSW_11_2_X_2020-07-27-1100
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-97cded/8311/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 2525444
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2525396
  • DQMHistoTests: Total skipped: 47
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
  • Checked 144 log files, 17 edm output root files, 34 DQM output files

@ggovi
Copy link
Contributor

ggovi commented Jul 28, 2020

+1

@pohsun
Copy link

pohsun commented Aug 1, 2020

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 1, 2020

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@silviodonato
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit b37ee32 into cms-sw:master Aug 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants