Throw if dereference an unset edm::Handle #30928

Dr15Jones · 2020-07-27T17:57:32Z

PR description:

Consistently throw if an edm::Handle is invalid. Previously it would only throw if the edm::Handle was used as part of a get call. Now also throw if the edm::Handle was never set.

PR validation:

The code compiles. Framework unit tests pass.

cmsbuild · 2020-07-27T17:57:58Z

The code-checks are being triggered in jenkins.

cmsbuild · 2020-07-27T18:03:53Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30928/17335

This PR adds an extra 12KB to repository

cmsbuild · 2020-07-27T18:04:13Z

A new Pull Request was created by @Dr15Jones (Chris Jones) for master.

It involves the following packages:

DataFormats/Common

@makortel, @smuzaffar, @cmsbuild, @Dr15Jones can you please review it and eventually sign? Thanks.
@makortel, @rovere, @wddgit this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

Dr15Jones · 2020-07-27T18:05:42Z

please test

cmsbuild · 2020-07-27T18:06:05Z

The tests are being triggered in jenkins.

CMSSW_11_2_X_2020-07-27-1100/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/8322/console Started: 2020/07/27 20:26

cmsbuild · 2020-07-27T21:30:48Z

-1

Tested at: d11825c

CMSSW: CMSSW_11_2_X_2020-07-27-1100
SCRAM_ARCH: slc7_amd64_gcc820

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

Migrate to std::filesystem #30825 @camolezi: Migrate to std::filesystem
Migrate L1trigger from boost::format to {fmt} #30858 @fwyzard: Migrate L1trigger from boost::format to {fmt}
move dictionaries for TrackingParticle and TrajectoryStateOnSurface to proper package #30848 @davidlange6: move dictionaries for TrackingParticle and TrajectoryStateOnSurface to proper package
Store anode wire hits in ALCT (ACLUT-3) #30301 @dildick: Store anode wire hits in ALCT (ACLUT-3)
drop wrong default params in TLorentzVector in TestCorrections.C #30872 @slava77: drop wrong default params in TLorentzVector in TestCorrections.C
HLT menu development (PixelClusterCounting for Lumi) #30923 @cms-tsg-storm: HLT menu development (PixelClusterCounting for Lumi)
Remove use of boost::mpl from Ref.h #30876 @Dr15Jones: Remove use of boost::mpl from Ref.h
fix index typo in PFRecoTauClusterVariables #30919 @slava77: fix index typo in PFRecoTauClusterVariables
Phase2-hgx256 Try to provide V14 geometry for HGCal #30862 @bsunanda: Phase2-hgx256 Try to provide V14 geometry for HGCal

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e80d09/8322/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e80d09/8322/git-merge-result

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e80d09/8322/summary.html

I found follow errors while testing this PR

Failed tests: UnitTests RelVals AddOn

Unit Tests:

I found errors in the following unit tests:

---> test testPhase2PixelNtuple had ERRORS
---> test testTauEmbeddingProducers had ERRORS

RelVals:

When I ran the RelVals I found an error in the following workflows:
8.0 step2

runTheMatrix-results/8.0_BeamHalo+BeamHalo+DIGICOS+RECOCOS+ALCABH+HARVESTCOS/step2_BeamHalo+BeamHalo+DIGICOS+RECOCOS+ALCABH+HARVESTCOS.log

5.1 step1

runTheMatrix-results/5.1_TTbar+TTbarFS+HARVESTFS/step1_TTbar+TTbarFS+HARVESTFS.log

135.4 step1

runTheMatrix-results/135.4_ZEE_13+ZEEFS_13+HARVESTUP15FS+MINIAODMCUP15FS/step1_ZEE_13+ZEEFS_13+HARVESTUP15FS+MINIAODMCUP15FS.log

7.3 step2

runTheMatrix-results/7.3_CosmicsSPLoose_UP18+CosmicsSPLoose_UP18+DIGICOS_UP18+RECOCOS_UP18+ALCACOS_UP18+HARVESTCOS_UP18/step2_CosmicsSPLoose_UP18+CosmicsSPLoose_UP18+DIGICOS_UP18+RECOCOS_UP18+ALCACOS_UP18+HARVESTCOS_UP18.log

136.7611 step2

runTheMatrix-results/136.7611_RunJetHT2016E_reminiaod+RunJetHT2016E_reminiaod+REMINIAOD_data2016_HIPM+HARVESTDR2_REMINIAOD_data2016_HIPM/step2_RunJetHT2016E_reminiaod+RunJetHT2016E_reminiaod+REMINIAOD_data2016_HIPM+HARVESTDR2_REMINIAOD_data2016_HIPM.log

9.0 step2

runTheMatrix-results/9.0_Higgs200ChargedTaus+Higgs200ChargedTaus+DIGI+RECO+HARVEST/step2_Higgs200ChargedTaus+Higgs200ChargedTaus+DIGI+RECO+HARVEST.log

1306.0 step2

runTheMatrix-results/1306.0_SingleMuPt1_UP15+SingleMuPt1_UP15+DIGIUP15+RECOUP15+HARVESTUP15/step2_SingleMuPt1_UP15+SingleMuPt1_UP15+DIGIUP15+RECOUP15+HARVESTUP15.log

25.0 step2

runTheMatrix-results/25.0_TTbar+TTbar+DIGI+RECOAlCaCalo+HARVEST+ALCATT/step2_TTbar+TTbar+DIGI+RECOAlCaCalo+HARVEST+ALCATT.log

1330.0 step2

runTheMatrix-results/1330.0_ZMM_13+ZMM_13+DIGIUP15+RECOUP15_L1TMuDQM+HARVESTUP15_L1TMuDQM+NANOUP15/step2_ZMM_13+ZMM_13+DIGIUP15+RECOUP15_L1TMuDQM+HARVESTUP15_L1TMuDQM+NANOUP15.log

158.0 step2

runTheMatrix-results/158.0_HydjetQ_B12_5020GeV_2018_ppReco+HydjetQ_B12_5020GeV_2018_ppReco+DIGIHI2018PPRECO+RECOHI2018PPRECO+ALCARECOHI2018PPRECO+HARVESTHI2018PPRECO/step2_HydjetQ_B12_5020GeV_2018_ppReco+HydjetQ_B12_5020GeV_2018_ppReco+DIGIHI2018PPRECO+RECOHI2018PPRECO+ALCARECOHI2018PPRECO+HARVESTHI2018PPRECO.log

10042.0 step2

runTheMatrix-results/10042.0_ZMM_13+ZMM_13TeV_TuneCUETP8M1_2017_GenSimFull+DigiFull_2017+RecoFull_2017+HARVESTFull_2017+ALCAFull_2017+NanoFull_2017/step2_ZMM_13+ZMM_13TeV_TuneCUETP8M1_2017_GenSimFull+DigiFull_2017+RecoFull_2017+HARVESTFull_2017+ALCAFull_2017+NanoFull_2017.log

25202.0 step2

runTheMatrix-results/25202.0_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25+NANOUP15_PU25/step2_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25+NANOUP15_PU25.log

10024.0 step2

runTheMatrix-results/10024.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017_GenSimFull+DigiFull_2017+RecoFull_2017+HARVESTFull_2017+ALCAFull_2017+NanoFull_2017/step2_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017_GenSimFull+DigiFull_2017+RecoFull_2017+HARVESTFull_2017+ALCAFull_2017+NanoFull_2017.log

10824.0 step2

runTheMatrix-results/10824.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2018_GenSimFull+DigiFull_2018+RecoFull_2018+HARVESTFull_2018+ALCAFull_2018+NanoFull_2018/step2_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2018_GenSimFull+DigiFull_2018+RecoFull_2018+HARVESTFull_2018+ALCAFull_2018+NanoFull_2018.log

10224.0 step2

runTheMatrix-results/10224.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017PU_GenSimFull+DigiFullPU_2017PU+RecoFullPU_2017PU+HARVESTFullPU_2017PU+NanoFull_2017PU/step2_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017PU_GenSimFull+DigiFullPU_2017PU+RecoFullPU_2017PU+HARVESTFullPU_2017PU+NanoFull_2017PU.log

11634.0 step2

runTheMatrix-results/11634.0_TTbar_14TeV+TTbar_14TeV_TuneCP5_2021_GenSimFull+DigiFull_2021+RecoFull_2021+HARVESTFull_2021+ALCAFull_2021/step2_TTbar_14TeV+TTbar_14TeV_TuneCP5_2021_GenSimFull+DigiFull_2021+RecoFull_2021+HARVESTFull_2021+ALCAFull_2021.log

12434.0 step2

runTheMatrix-results/12434.0_TTbar_14TeV+TTbar_14TeV_TuneCP5_2023_GenSimFull+DigiFull_2023+RecoFull_2023+HARVESTFull_2023+ALCAFull_2023/step2_TTbar_14TeV+TTbar_14TeV_TuneCP5_2023_GenSimFull+DigiFull_2023+RecoFull_2023+HARVESTFull_2023+ALCAFull_2023.log

23234.0 step2

runTheMatrix-results/23234.0_TTbar_14TeV+TTbar_14TeV_TuneCP5_2026D49_GenSimHLBeamSpotFull14+DigiFullTrigger_2026D49+RecoFullGlobal_2026D49+HARVESTFullGlobal_2026D49/step2_TTbar_14TeV+TTbar_14TeV_TuneCP5_2026D49_GenSimHLBeamSpotFull14+DigiFullTrigger_2026D49+RecoFullGlobal_2026D49+HARVESTFullGlobal_2026D49.log

28234.0 step2

runTheMatrix-results/28234.0_TTbar_14TeV+TTbar_14TeV_TuneCP5_2026D60_GenSimHLBeamSpotFull14+DigiFullTrigger_2026D60+RecoFullGlobal_2026D60+HARVESTFullGlobal_2026D60/step2_TTbar_14TeV+TTbar_14TeV_TuneCP5_2026D60_GenSimHLBeamSpotFull14+DigiFullTrigger_2026D60+RecoFullGlobal_2026D60+HARVESTFullGlobal_2026D60.log

250202.181 step3

runTheMatrix-results/250202.181_TTbar_13UP18+TTbar_13UP18+PREMIXUP18_PU25+DIGIPRMXLOCALUP18_PU25+RECOPRMXUP18_PU25+HARVESTUP18_PU25/step3_TTbar_13UP18+TTbar_13UP18+PREMIXUP18_PU25+DIGIPRMXLOCALUP18_PU25+RECOPRMXUP18_PU25+HARVESTUP18_PU25.log

AddOn:

I found errors in the following addon tests:

cmsDriver.py TTbar_Tauola_13TeV_TuneCUETP8M1_cfi -s GEN,SIM,DIGI,L1,DIGI2RAW --mc --scenario=pp -n 10 --conditions auto:run3_mc_GRun --relval 9000,50 --datatier "GEN-SIM-RAW" --eventcontent RAWSIM --customise=HLTrigger/Configuration/CustomConfigs.L1T --era Run3 --fileout file:RelVal_Raw_GRun_MC.root : FAILED - time: date Mon Jul 27 23:26:05 2020-date Mon Jul 27 23:13:51 2020 s - exit: 16640
cmsDriver.py TTbar_Tauola_13TeV_TuneCUETP8M1_cfi -s GEN,SIM,DIGI,L1,DIGI2RAW --mc --scenario=pp -n 10 --conditions auto:run3_mc_PRef --relval 9000,50 --datatier "GEN-SIM-RAW" --eventcontent RAWSIM --customise=HLTrigger/Configuration/CustomConfigs.L1T --era Run3 --fileout file:RelVal_Raw_PRef_MC.root : FAILED - time: date Mon Jul 27 23:21:22 2020-date Mon Jul 27 23:13:59 2020 s - exit: 16640
cmsDriver.py TTbar_Tauola_8TeV_TuneCUETP8M1_cfi -s GEN,SIM,DIGI,L1,DIGI2RAW --mc --scenario=pp -n 10 --conditions auto:run1_mc_Fake --relval 9000,50 --datatier "GEN-SIM-RAW" --eventcontent RAWSIM --customise=HLTrigger/Configuration/CustomConfigs.L1T --fileout file:RelVal_Raw_Fake_MC.root : FAILED - time: date Mon Jul 27 23:21:12 2020-date Mon Jul 27 23:14:08 2020 s - exit: 16640
cmsDriver.py TTbar_Tauola_13TeV_TuneCUETP8M1_cfi -s GEN,SIM,DIGI,L1,DIGI2RAW --mc --scenario=pp -n 10 --conditions auto:run3_mc_HIon --relval 9000,50 --datatier "GEN-SIM-RAW" --eventcontent RAWSIM --customise=HLTrigger/Configuration/CustomConfigs.L1T --era Run3_pp_on_PbPb --fileout file:RelVal_Raw_HIon_MC.root : FAILED - time: date Mon Jul 27 23:22:20 2020-date Mon Jul 27 23:14:12 2020 s - exit: 16640
cmsDriver.py TTbar_Tauola_13TeV_TuneCUETP8M1_cfi -s GEN,SIM,DIGI,L1,DIGI2RAW --mc --scenario=pp -n 10 --conditions auto:run2_mc_Fake2 --relval 9000,50 --datatier "GEN-SIM-RAW" --eventcontent RAWSIM --customise=HLTrigger/Configuration/CustomConfigs.L1T --era Run2_2016 --fileout file:RelVal_Raw_Fake2_MC.root : FAILED - time: date Mon Jul 27 23:21:19 2020-date Mon Jul 27 23:14:16 2020 s - exit: 16640
cmsDriver.py TTbar_Tauola_13TeV_TuneCUETP8M1_cfi -s GEN,SIM,DIGI,L1,DIGI2RAW --mc --scenario=pp -n 10 --conditions auto:run2_mc_Fake1 --relval 9000,50 --datatier "GEN-SIM-RAW" --eventcontent RAWSIM --customise=HLTrigger/Configuration/CustomConfigs.L1T --era Run2_25ns --fileout file:RelVal_Raw_Fake1_MC.root : FAILED - time: date Mon Jul 27 23:21:15 2020-date Mon Jul 27 23:14:19 2020 s - exit: 16640
cmsRun /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_2_X_2020-07-27-1100/src/HLTrigger/Configuration/test/OnLine_HLT_GRun.py realData=True globalTag=@ inputFiles=@ : FAILED - time: date Mon Jul 27 23:27:58 2020-date Mon Jul 27 23:14:37 2020 s - exit: 16640
cmsDriver.py RelVal -s HLT:GRun,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run3_data_GRun --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run3 --processName=HLTRECO --filein file:RelVal_Raw_GRun_DATA.root --fileout file:RelVal_Raw_GRun_DATA_HLT_RECO.root : FAILED - time: date Mon Jul 27 23:27:58 2020-date Mon Jul 27 23:14:37 2020 s - exit: 16640
cmsDriver.py TTbar_Tauola_13TeV_TuneCUETP8M1_cfi -s GEN,SIM,DIGI,L1,DIGI2RAW --mc --scenario=pp -n 10 --conditions auto:run3_mc_PIon --relval 9000,50 --datatier "GEN-SIM-RAW" --eventcontent RAWSIM --customise=HLTrigger/Configuration/CustomConfigs.L1T --era Run3 --fileout file:RelVal_Raw_PIon_MC.root : FAILED - time: date Mon Jul 27 23:23:05 2020-date Mon Jul 27 23:18:12 2020 s - exit: 16640

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

Migrate to std::filesystem #30825 @camolezi: Migrate to std::filesystem
Migrate L1trigger from boost::format to {fmt} #30858 @fwyzard: Migrate L1trigger from boost::format to {fmt}
move dictionaries for TrackingParticle and TrajectoryStateOnSurface to proper package #30848 @davidlange6: move dictionaries for TrackingParticle and TrajectoryStateOnSurface to proper package
Store anode wire hits in ALCT (ACLUT-3) #30301 @dildick: Store anode wire hits in ALCT (ACLUT-3)
drop wrong default params in TLorentzVector in TestCorrections.C #30872 @slava77: drop wrong default params in TLorentzVector in TestCorrections.C
HLT menu development (PixelClusterCounting for Lumi) #30923 @cms-tsg-storm: HLT menu development (PixelClusterCounting for Lumi)
Remove use of boost::mpl from Ref.h #30876 @Dr15Jones: Remove use of boost::mpl from Ref.h
fix index typo in PFRecoTauClusterVariables #30919 @slava77: fix index typo in PFRecoTauClusterVariables
Phase2-hgx256 Try to provide V14 geometry for HGCal #30862 @bsunanda: Phase2-hgx256 Try to provide V14 geometry for HGCal

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e80d09/8322/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e80d09/8322/git-merge-result

cmsbuild · 2020-07-27T21:30:51Z

Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped)

Dr15Jones · 2020-07-27T21:36:35Z

The failures were expected since we also need the change from #30925

Consistently throw if an edm::Handle is invalid. Previously it would only throw if the edm::Handle was used as part of a get call. Now also throw if the edm::Handle was never set.

Dr15Jones · 2020-08-06T11:43:51Z

please test

cmsbuild · 2020-08-06T11:44:12Z

The tests are being triggered in jenkins.

CMSSW_11_2_X_2020-08-05-2300/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/8612/console Started: 2020/08/06 15:23

cmsbuild · 2020-08-06T14:36:29Z

+1
Tested at: b3c1e40
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e80d09/8612/summary.html
CMSSW: CMSSW_11_2_X_2020-08-05-2300
SCRAM_ARCH: slc7_amd64_gcc820

cmsbuild · 2020-08-06T14:36:32Z

Comparison job queued.

cmsbuild · 2020-08-06T16:04:59Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e80d09/8612/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 2 differences found in the comparisons
DQMHistoTests: Total files compared: 35
DQMHistoTests: Total histograms compared: 2612401
DQMHistoTests: Total failures: 5
DQMHistoTests: Total nulls: 1
DQMHistoTests: Total successes: 2612347
DQMHistoTests: Total skipped: 48
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.004 KiB( 34 files compared)
DQMHistoSizes: changed ( 10224.0 ): 0.004 KiB MessageLogger/Warnings
Checked 149 log files, 22 edm output root files, 35 DQM output files

Dr15Jones · 2020-08-06T16:05:55Z

It looks like all the necessary changes are now in CMSSW.

makortel · 2020-08-06T16:07:38Z

+1

cmsbuild · 2020-08-06T16:08:03Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

silviodonato · 2020-08-06T19:16:36Z

+1

makortel · 2020-08-07T12:27:18Z

The IOPool/Input unit test is failing with

+ cmsRun --parameter-set /data/cmsbld/jenkins/workspace/ib-run-qa/CMSSW_11_2_X_2020-08-06-2300/src/IOPool/Input/test/preMerge_cfg.py
Begin processing the 1st record. Run 1, Event 1, LumiSection 1 on stream 0 at 07-Aug-2020 07:51:19.154 CEST
----- Begin Fatal Exception 07-Aug-2020 07:51:19 CEST-----------------------
An exception of category 'DereferenceUnsetHandle' occurred while
   [0] Processing  Event run: 1 lumi: 1 event: 1 stream: 0
   [1] Running path 'p'
   [2] Calling method for module OtherThingProducer/'OtherThing'
Exception Message:
An attempt was made to dereference an edm::Handle which was never set.
----- End Fatal Exception -------------------------------------------------

https://cmssdt.cern.ch/SDT/cgi-bin/logreader/slc7_amd64_gcc820/CMSSW_11_2_X_2020-08-06-2300/unitTestLogs/IOPool/Input#/1431-1431

@Dr15Jones could you fix it?

Dr15Jones · 2020-08-07T14:15:19Z

Unit test fix in #31093. @smuzaffar do we know why this pull request did not find the unit test failure during the initial testing?

makortel · 2020-08-07T14:20:36Z

Thanks. This PR modified only DataFormats/Common/src/HandleBase.cc, so it did not lead to checking out IOPool/Input and running its unit tests.

cmsbuild added this to the CMSSW_11_2_X milestone Jul 27, 2020

cmsbuild added code-checks-pending comparison-pending core-pending orp-pending pending-signatures tests-pending labels Jul 27, 2020

cmsbuild added code-checks-approved and removed code-checks-pending labels Jul 27, 2020

cmsbuild added tests-started and removed tests-pending labels Jul 27, 2020

cmsbuild added comparison-notrun tests-rejected and removed comparison-pending tests-started labels Jul 27, 2020

Throw if dereference an unset edm::Handle

b3c1e40

Consistently throw if an edm::Handle is invalid. Previously it would only throw if the edm::Handle was used as part of a get call. Now also throw if the edm::Handle was never set.

Dr15Jones force-pushed the invalidHandleThrows branch from d11825c to b3c1e40 Compare July 27, 2020 21:39

cmsbuild added code-checks-pending comparison-pending and removed code-checks-approved comparison-notrun tests-rejected labels Jul 27, 2020

cmsbuild added comparison-pending tests-pending and removed comparison-notrun tests-rejected labels Aug 6, 2020

cmsbuild added tests-started and removed tests-pending labels Aug 6, 2020

cmsbuild added tests-approved and removed tests-started labels Aug 6, 2020

cmsbuild added comparison-available and removed comparison-pending labels Aug 6, 2020

cmsbuild added core-approved fully-signed and removed core-pending pending-signatures labels Aug 6, 2020

cmsbuild added orp-approved and removed orp-pending labels Aug 6, 2020

cmsbuild merged commit eed595d into cms-sw:master Aug 6, 2020

Dr15Jones deleted the invalidHandleThrows branch August 28, 2020 16:19

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Throw if dereference an unset edm::Handle #30928

Throw if dereference an unset edm::Handle #30928

Dr15Jones commented Jul 27, 2020

cmsbuild commented Jul 27, 2020

cmsbuild commented Jul 27, 2020

cmsbuild commented Jul 27, 2020

Dr15Jones commented Jul 27, 2020

cmsbuild commented Jul 27, 2020 •

edited

cmsbuild commented Jul 27, 2020

cmsbuild commented Jul 27, 2020

Dr15Jones commented Jul 27, 2020

Dr15Jones commented Aug 6, 2020

cmsbuild commented Aug 6, 2020 •

edited

cmsbuild commented Aug 6, 2020

cmsbuild commented Aug 6, 2020

cmsbuild commented Aug 6, 2020

Dr15Jones commented Aug 6, 2020

makortel commented Aug 6, 2020

cmsbuild commented Aug 6, 2020

silviodonato commented Aug 6, 2020

makortel commented Aug 7, 2020

Dr15Jones commented Aug 7, 2020

makortel commented Aug 7, 2020

Throw if dereference an unset edm::Handle #30928

Throw if dereference an unset edm::Handle #30928

Conversation

Dr15Jones commented Jul 27, 2020

PR description:

PR validation:

cmsbuild commented Jul 27, 2020

cmsbuild commented Jul 27, 2020

cmsbuild commented Jul 27, 2020

Dr15Jones commented Jul 27, 2020

cmsbuild commented Jul 27, 2020 • edited

cmsbuild commented Jul 27, 2020

cmsbuild commented Jul 27, 2020

Dr15Jones commented Jul 27, 2020

Dr15Jones commented Aug 6, 2020

cmsbuild commented Aug 6, 2020 • edited

cmsbuild commented Aug 6, 2020

cmsbuild commented Aug 6, 2020

cmsbuild commented Aug 6, 2020

Dr15Jones commented Aug 6, 2020

makortel commented Aug 6, 2020

cmsbuild commented Aug 6, 2020

silviodonato commented Aug 6, 2020

makortel commented Aug 7, 2020

Dr15Jones commented Aug 7, 2020

makortel commented Aug 7, 2020

cmsbuild commented Jul 27, 2020 •

edited

cmsbuild commented Aug 6, 2020 •

edited