Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MET filter fix for nanoAOD step in extraflags_cff file i.e. addition of slimmedOfflinePrimaryVertices input tag (follow up of PR 30015) #30974

Merged
merged 1 commit into from Jul 30, 2020

Conversation

amkalsi
Copy link
Contributor

@amkalsi amkalsi commented Jul 30, 2020

MET filter fix for nanoAOD step in extraflags_cff file i.e. addition of slimmedOfflinePrimaryVertices input tag (follow up of #30015).
This PR fixes the error found in wf 136.7722 and 1329.1 since CMSSW_11_2_X_2020-07-28-2300 (#30015)

----- Begin Fatal Exception 29-Jul-2020 04:47:17 CEST-----------------------
An exception of category 'ProductNotFound' occurred while
   [0] Processing  Event run: 283877 lumi: 11 event: 18172717 stream: 3
   [1] Running path 'nanoAOD_step'
   [2] Calling method for module BadParticleFilter/'BadPFMuonTagger'
Exception Message:
Principal::getByToken: Found zero products matching all criteria
Looking for type: std::vector<reco::Vertex>
Looking for module label: offlinePrimaryVertices
Looking for productInstanceName: 

   Additional Info:
      [a] If you wish to continue processing events after a ProductNotFound exception,
add "SkipEvent = cms.untracked.vstring('ProductNotFound')" to the "options" PSet in the configuration.

----- End Fatal Exception -------------------------------------------------

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@amkalsi amkalsi changed the title changes for nanoAOD step additions in extraflags_cff file (follow up of PR 30015) Jul 30, 2020
@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30974/17414

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @amkalsi (Amandeep Kaur Kalsi) for master.

It involves the following packages:

PhysicsTools/NanoAOD

@gouskos, @cmsbuild, @fgolf, @mariadalfonso, @santocch, @peruzzim can you please review it and eventually sign? Thanks.
@gpetruc this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@slava77
Copy link
Contributor

slava77 commented Jul 30, 2020

@cmsbuild please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@slava77
Copy link
Contributor

slava77 commented Jul 30, 2020

@amkalsi please add some text in the PR title to clarify that this is for MET filter
e.g. "MET filter fix for nanoAOD in extraflags_cff file (follow up to #30015) " to improve self-documentation.

@slava77
Copy link
Contributor

slava77 commented Jul 30, 2020

abort test

@cmsbuild
Copy link
Contributor

Jenkins tests are aborted.

@slava77
Copy link
Contributor

slava77 commented Jul 30, 2020

@cmsbuild please test workflow 136.7722,1329.1

now with the workflows supposedly fixed by this PR

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 30, 2020

The tests are being triggered in jenkins.
Test Parameters:

@amkalsi amkalsi changed the title additions in extraflags_cff file (follow up of PR 30015) MET filter fix for nanoAOD in extraflags_cff file (follow up of PR 30015) Jul 30, 2020
@amkalsi amkalsi changed the title MET filter fix for nanoAOD in extraflags_cff file (follow up of PR 30015) MET filter fix for nanoAOD step in extraflags_cff file which is addition of slimmedOfflinePrimaryVertices input tag (follow up of PR 30015) Jul 30, 2020
@amkalsi amkalsi changed the title MET filter fix for nanoAOD step in extraflags_cff file which is addition of slimmedOfflinePrimaryVertices input tag (follow up of PR 30015) MET filter fix for nanoAOD step in extraflags_cff file i.e. addition of slimmedOfflinePrimaryVertices input tag (follow up of PR 30015) Jul 30, 2020
@cmsbuild
Copy link
Contributor

+1
Tested at: 537c696
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-47d728/8410/summary.html
CMSSW: CMSSW_11_2_X_2020-07-29-2300
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-47d728/8410/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 2525444
  • DQMHistoTests: Total failures: 7
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2525390
  • DQMHistoTests: Total skipped: 47
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
  • Checked 144 log files, 17 edm output root files, 34 DQM output files

@silviodonato
Copy link
Contributor

merge
@cms-sw/analysis-l2 @cms-sw/xpog-l2
this fix is trivial but also important to avoid the crash of workflows 136.7722 and 1329.1

@santocch
Copy link

santocch commented Aug 7, 2020

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants