Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix L1T Phase2 EG scale #30979

Merged
merged 1 commit into from Jul 31, 2020
Merged

Fix L1T Phase2 EG scale #30979

merged 1 commit into from Jul 31, 2020

Conversation

cerminar
Copy link
Contributor

PR description:

The PR fixes the scale problems of L1 EG objects in HGC reported in:

https://hypernews.cern.ch/HyperNews/CMS/get/L1TriggerUpgrades/385/1/1/1/1/1/1/1/1.html

PR validation:

canvas(165)
canvas(164)
c_42257b_2
c_42257b_1

Backport of PR #30978

@cmsbuild cmsbuild added this to the CMSSW_11_1_X milestone Jul 30, 2020
@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 30, 2020 •
edited

A new Pull Request was created by @cerminar for CMSSW_11_1_X.

It involves the following packages:

L1Trigger/L1THGCal

@cmsbuild, @rekovic, @benkrikler, @kpedro88 can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @amarini, @jbsauvan, @lgray this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@fwyzard
Copy link
Contributor

fwyzard commented Jul 30, 2020

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 30, 2020 •
edited

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+1
Tested at: b111efe
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-093743/8428/summary.html
CMSSW: CMSSW_11_1_X_2020-07-30-1100
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-093743/8428/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 36
  • DQMHistoTests: Total histograms compared: 2780792
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2780740
  • DQMHistoTests: Total skipped: 50
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 35 files compared)
  • Checked 152 log files, 16 edm output root files, 36 DQM output files

@kpedro88
Copy link
Contributor

backport of #30978

@silviodonato
Copy link
Contributor

urgent

@kpedro88
Copy link
Contributor

+upgrade

@kpedro88 kpedro88 mentioned this pull request Jul 31, 2020
Merged
@silviodonato
Copy link
Contributor

merge

@cmsbuild cmsbuild merged commit cbb4c23 into cms-sw:CMSSW_11_1_X Jul 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
backport-ok comparison-available l1-pending orp-approved pending-signatures tests-approved upgrade-approved urgent
Projects
None yet
Milestone
CMSSW_11_1_X
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@cerminar @cmsbuild @fwyzard @kpedro88 @silviodonato