Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up L1TTrackMatch producers [11_1_X] #30982

Merged
merged 7 commits into from Aug 3, 2020
Merged

Clean up L1TTrackMatch producers [11_1_X] #30982

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
b40c602
clean up L1TkEmParticleProducer
kpedro88 Jul 29, 2020
7857801
avoid modifying class member
kpedro88 Jul 29, 2020
2b66a40
clean up L1TkFastVertexProducer
kpedro88 Jul 29, 2020
81029da
avoid modifying class members
kpedro88 Jul 29, 2020
cc4b585
clean up L1TkMuonProducer
kpedro88 Jul 29, 2020
942e129
code format
kpedro88 Jul 29, 2020
592181a
use esConsumes
kpedro88 Jul 29, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
145 changes: 50 additions & 95 deletions L1Trigger/L1TTrackMatch/plugins/L1TkMuonProducer.cc
View file
Open in desktop
Expand Up @@ -5,7 +5,7 @@
// user include files
#include "FWCore/Utilities/interface/InputTag.h"
#include "FWCore/Framework/interface/Frameworkfwd.h"
#include "FWCore/Framework/interface/EDProducer.h"
#include "FWCore/Framework/interface/global/EDProducer.h"
#include "FWCore/Framework/interface/Event.h"
#include "FWCore/Framework/interface/MakerMacros.h"
#include "FWCore/Framework/interface/ESHandle.h"
Expand Down Expand Up @@ -43,7 +43,7 @@ static constexpr float max_mu_propagator_eta = 2.5;

using namespace l1t;

class L1TkMuonProducer : public edm::EDProducer {
class L1TkMuonProducer : public edm::global::EDProducer<> {
public:
typedef TTTrack<Ref_Phase2TrackerDigi_> L1TTTrackType;
typedef std::vector<L1TTTrackType> L1TTTrackCollectionType;
Expand All @@ -67,7 +67,7 @@ class L1TkMuonProducer : public edm::EDProducer {
static void fillDescriptions(edm::ConfigurationDescriptions& descriptions);

private:
void produce(edm::Event&, const edm::EventSetup&) override;
void produce(edm::StreamID, edm::Event&, const edm::EventSetup&) const override;
PropState propagateToGMT(const L1TTTrackType& l1tk) const;
double sigmaEtaTP(const RegionalMuonCand& mu) const;
double sigmaPhiTP(const RegionalMuonCand& mu) const;
Expand All @@ -90,18 +90,12 @@ class L1TkMuonProducer : public edm::EDProducer {
const edm::Handle<RegionalMuonCandBxCollection>& muonH,
int detector) const;

// as above, but for the TkMu that were built from a EMTFCollection - do not produce a valid muon ref
void build_tkMuons_from_idxs(TkMuonCollection& tkMuons,
const std::vector<int>& matches,
const edm::Handle<L1TTTrackCollectionType>& l1tksH,
int detector) const;

// dump and convert tracks to the format needed for the MAnTra correlator
std::vector<L1TkMuMantraDF::track_df> product_to_trkvec(const L1TTTrackCollectionType& l1tks); // tracks
std::vector<L1TkMuMantraDF::track_df> product_to_trkvec(const L1TTTrackCollectionType& l1tks) const; // tracks
// regional muon finder
std::vector<L1TkMuMantraDF::muon_df> product_to_muvec(const RegionalMuonCandBxCollection& l1mtfs);
std::vector<L1TkMuMantraDF::muon_df> product_to_muvec(const RegionalMuonCandBxCollection& l1mtfs) const;
// endcap muon finder - eventually to be moved to regional candidate
std::vector<L1TkMuMantraDF::muon_df> product_to_muvec(const EMTFTrackCollection& l1mus);
std::vector<L1TkMuMantraDF::muon_df> product_to_muvec(const EMTFTrackCollection& l1mus) const;

float etaMin_;
float etaMax_;
Expand Down Expand Up @@ -130,7 +124,7 @@ class L1TkMuonProducer : public edm::EDProducer {
const edm::EDGetTokenT<RegionalMuonCandBxCollection> emtfToken_;
// the track collection, directly from the EMTF and not formatted by GT
const edm::EDGetTokenT<EMTFTrackCollection> emtfTCToken_;
const edm::EDGetTokenT<std::vector<TTTrack<Ref_Phase2TrackerDigi_> > > trackToken;
const edm::EDGetTokenT<std::vector<TTTrack<Ref_Phase2TrackerDigi_> > > trackToken_;
};

L1TkMuonProducer::L1TkMuonProducer(const edm::ParameterSet& iConfig)
Expand All @@ -147,7 +141,7 @@ L1TkMuonProducer::L1TkMuonProducer(const edm::ParameterSet& iConfig)
omtfToken_(consumes<RegionalMuonCandBxCollection>(iConfig.getParameter<edm::InputTag>("L1OMTFInputTag"))),
emtfToken_(consumes<RegionalMuonCandBxCollection>(iConfig.getParameter<edm::InputTag>("L1EMTFInputTag"))),
emtfTCToken_(consumes<EMTFTrackCollection>(iConfig.getParameter<edm::InputTag>("L1EMTFTrackCollectionInputTag"))),
trackToken(consumes<std::vector<TTTrack<Ref_Phase2TrackerDigi_> > >(
trackToken_(consumes<std::vector<TTTrack<Ref_Phase2TrackerDigi_> > >(
iConfig.getParameter<edm::InputTag>("L1TrackInputTag"))) {
// --------------------- configuration of the muon algorithm type

Expand Down Expand Up @@ -177,8 +171,6 @@ L1TkMuonProducer::L1TkMuonProducer(const edm::ParameterSet& iConfig)
throw cms::Exception("TkMuAlgoConfig")
<< "the ID " << bmtfMatchAlgoVersionString << " of the BMTF algo matcher passed is invalid\n";

//

if (omtfMatchAlgoVersionString == "tp")
omtfMatchAlgoVersion_ = kTP;
else if (omtfMatchAlgoVersionString == "mantra")
Expand All @@ -187,8 +179,6 @@ L1TkMuonProducer::L1TkMuonProducer(const edm::ParameterSet& iConfig)
throw cms::Exception("TkMuAlgoConfig")
<< "the ID " << omtfMatchAlgoVersionString << " of the OMTF algo matcher passed is invalid\n";

//

if (emtfMatchAlgoVersionString == "tp")
emtfMatchAlgoVersion_ = kTP;
else if (emtfMatchAlgoVersionString == "dynamicwindows")
Expand All @@ -211,7 +201,7 @@ L1TkMuonProducer::L1TkMuonProducer(const edm::ParameterSet& iConfig)
std::string fIn_bounds_name = iConfig.getParameter<edm::FileInPath>("emtfcorr_boundaries").fullPath();
std::string fIn_theta_name = iConfig.getParameter<edm::FileInPath>("emtfcorr_theta_windows").fullPath();
std::string fIn_phi_name = iConfig.getParameter<edm::FileInPath>("emtfcorr_phi_windows").fullPath();
auto bounds = L1TkMuCorrDynamicWindows::prepare_corr_bounds(fIn_bounds_name, "h_dphi_l");
const auto& bounds = L1TkMuCorrDynamicWindows::prepare_corr_bounds(fIn_bounds_name, "h_dphi_l");
TFile* fIn_theta = TFile::Open(fIn_theta_name.c_str());
TFile* fIn_phi = TFile::Open(fIn_phi_name.c_str());
dwcorr_ = std::make_unique<L1TkMuCorrDynamicWindows>(bounds, fIn_theta, fIn_phi);
Expand All @@ -229,7 +219,6 @@ L1TkMuonProducer::L1TkMuonProducer(const edm::ParameterSet& iConfig)

dwcorr_->set_do_relax_factor(iConfig.getParameter<bool>("do_relax_factors"));

//
dwcorr_->set_n_trk_par(iConfig.getParameter<int>("n_trk_par"));
dwcorr_->set_min_trk_p(iConfig.getParameter<double>("min_trk_p"));
dwcorr_->set_max_trk_aeta(iConfig.getParameter<double>("max_trk_aeta"));
Expand All @@ -243,7 +232,7 @@ L1TkMuonProducer::L1TkMuonProducer(const edm::ParameterSet& iConfig)
std::string fIn_theta_name = iConfig.getParameter<edm::FileInPath>("mantra_bmtfcorr_theta_windows").fullPath();
std::string fIn_phi_name = iConfig.getParameter<edm::FileInPath>("mantra_bmtfcorr_phi_windows").fullPath();

auto bounds = L1TkMuMantra::prepare_corr_bounds(fIn_bounds_name, "h_dphi_l");
const auto& bounds = L1TkMuMantra::prepare_corr_bounds(fIn_bounds_name, "h_dphi_l");

TFile* fIn_theta = TFile::Open(fIn_theta_name.c_str());
TFile* fIn_phi = TFile::Open(fIn_phi_name.c_str());
Expand All @@ -263,7 +252,7 @@ L1TkMuonProducer::L1TkMuonProducer(const edm::ParameterSet& iConfig)
std::string fIn_theta_name = iConfig.getParameter<edm::FileInPath>("mantra_omtfcorr_theta_windows").fullPath();
std::string fIn_phi_name = iConfig.getParameter<edm::FileInPath>("mantra_omtfcorr_phi_windows").fullPath();

auto bounds = L1TkMuMantra::prepare_corr_bounds(fIn_bounds_name, "h_dphi_l");
const auto& bounds = L1TkMuMantra::prepare_corr_bounds(fIn_bounds_name, "h_dphi_l");

TFile* fIn_theta = TFile::Open(fIn_theta_name.c_str());
TFile* fIn_phi = TFile::Open(fIn_phi_name.c_str());
Expand All @@ -283,7 +272,7 @@ L1TkMuonProducer::L1TkMuonProducer(const edm::ParameterSet& iConfig)
std::string fIn_theta_name = iConfig.getParameter<edm::FileInPath>("mantra_emtfcorr_theta_windows").fullPath();
std::string fIn_phi_name = iConfig.getParameter<edm::FileInPath>("mantra_emtfcorr_phi_windows").fullPath();

auto bounds = L1TkMuMantra::prepare_corr_bounds(fIn_bounds_name, "h_dphi_l");
const auto& bounds = L1TkMuMantra::prepare_corr_bounds(fIn_bounds_name, "h_dphi_l");

TFile* fIn_theta = TFile::Open(fIn_theta_name.c_str());
TFile* fIn_phi = TFile::Open(fIn_phi_name.c_str());
Expand All @@ -302,7 +291,7 @@ L1TkMuonProducer::L1TkMuonProducer(const edm::ParameterSet& iConfig)
L1TkMuonProducer::~L1TkMuonProducer() {}

// ------------ method called to produce the data ------------
void L1TkMuonProducer::produce(edm::Event& iEvent, const edm::EventSetup& iSetup) {
void L1TkMuonProducer::produce(edm::StreamID, edm::Event& iEvent, const edm::EventSetup& iSetup) const {
// the L1Mu objects
edm::Handle<RegionalMuonCandBxCollection> l1bmtfH;
edm::Handle<RegionalMuonCandBxCollection> l1omtfH;
Expand All @@ -316,7 +305,7 @@ void L1TkMuonProducer::produce(edm::Event& iEvent, const edm::EventSetup& iSetup

// the L1Tracks
edm::Handle<L1TTTrackCollectionType> l1tksH;
iEvent.getByToken(trackToken, l1tksH);
iEvent.getByToken(trackToken_, l1tksH);

TkMuonCollection oc_bmtf_tkmuon;
TkMuonCollection oc_omtf_tkmuon;
Expand All @@ -333,8 +322,8 @@ void L1TkMuonProducer::produce(edm::Event& iEvent, const edm::EventSetup& iSetup
if (bmtfMatchAlgoVersion_ == kTP)
runOnMTFCollection_v1(l1bmtfH, l1tksH, oc_bmtf_tkmuon, barrel_MTF_region);
else if (bmtfMatchAlgoVersion_ == kMantra) {
auto muons = product_to_muvec(*l1bmtfH.product());
auto match_idx = mantracorr_barr_->find_match(mantradf_tracks, muons);
const auto& muons = product_to_muvec(*l1bmtfH.product());
const auto& match_idx = mantracorr_barr_->find_match(mantradf_tracks, muons);
build_tkMuons_from_idxs(oc_bmtf_tkmuon, match_idx, l1tksH, l1bmtfH, barrel_MTF_region);
} else
throw cms::Exception("TkMuAlgoConfig") << " barrel : trying to run an invalid algorithm version "
Expand All @@ -344,8 +333,8 @@ void L1TkMuonProducer::produce(edm::Event& iEvent, const edm::EventSetup& iSetup
if (omtfMatchAlgoVersion_ == kTP)
runOnMTFCollection_v1(l1omtfH, l1tksH, oc_omtf_tkmuon, overlap_MTF_region);
else if (omtfMatchAlgoVersion_ == kMantra) {
auto muons = product_to_muvec(*l1omtfH.product());
auto match_idx = mantracorr_ovrl_->find_match(mantradf_tracks, muons);
const auto& muons = product_to_muvec(*l1omtfH.product());
const auto& match_idx = mantracorr_ovrl_->find_match(mantradf_tracks, muons);
build_tkMuons_from_idxs(oc_omtf_tkmuon, match_idx, l1tksH, l1omtfH, overlap_MTF_region);
} else
throw cms::Exception("TkMuAlgoConfig") << " overlap : trying to run an invalid algorithm version "
Expand All @@ -357,9 +346,11 @@ void L1TkMuonProducer::produce(edm::Event& iEvent, const edm::EventSetup& iSetup
else if (emtfMatchAlgoVersion_ == kDynamicWindows)
runOnMTFCollection_v2(l1emtfTCH, l1tksH, oc_emtf_tkmuon);
else if (emtfMatchAlgoVersion_ == kMantra) {
auto muons = product_to_muvec(*l1emtfTCH.product());
auto match_idx = mantracorr_endc_->find_match(mantradf_tracks, muons);
build_tkMuons_from_idxs(oc_emtf_tkmuon, match_idx, l1tksH, endcap_MTF_region);
const auto& muons = product_to_muvec(*l1emtfTCH.product());
const auto& match_idx = mantracorr_endc_->find_match(mantradf_tracks, muons);
//for the TkMu that were built from a EMTFCollection - do not produce a valid muon ref
edm::Handle<RegionalMuonCandBxCollection> invalidMuonH;
build_tkMuons_from_idxs(oc_emtf_tkmuon, match_idx, l1tksH, invalidMuonH, endcap_MTF_region);
} else
throw cms::Exception("TkMuAlgoConfig") << "endcap : trying to run an invalid algorithm version "
<< emtfMatchAlgoVersion_ << " (this should never happen)\n";
Expand Down Expand Up @@ -392,16 +383,13 @@ void L1TkMuonProducer::runOnMTFCollection_v1(const edm::Handle<RegionalMuonCandB
float l1mu_phi =
MicroGMTConfiguration::calcGlobalPhi(l1mu->hwPhi(), l1mu->trackFinderType(), l1mu->processor()) * phi_scale;

float l1mu_feta = fabs(l1mu_eta);
float l1mu_feta = std::abs(l1mu_eta);
if (l1mu_feta < etaMin_)
continue;
if (l1mu_feta > etaMax_)
continue;

float drmin = 999;
float ptmax = -1;
if (ptmax < 0)
ptmax = -1; // dummy

PropState matchProp;
int match_idx = -1;
Expand All @@ -417,7 +405,7 @@ void L1TkMuonProducer::runOnMTFCollection_v1(const edm::Handle<RegionalMuonCandB
continue;

float l1tk_z = l1tk.POCA().z();
if (fabs(l1tk_z) > zMax_)
if (std::abs(l1tk_z) > zMax_)
continue;

float l1tk_chi2 = l1tk.chi2();
Expand All @@ -431,7 +419,7 @@ void L1TkMuonProducer::runOnMTFCollection_v1(const edm::Handle<RegionalMuonCandB
float l1tk_eta = l1tk.momentum().eta();
float l1tk_phi = l1tk.momentum().phi();

float dr2 = deltaR2(l1mu_eta, l1mu_phi, l1tk_eta, l1tk_phi);
float dr2 = reco::deltaR2(l1mu_eta, l1mu_phi, l1tk_eta, l1tk_phi);
if (dr2 > dr2_cutoff)
continue;

Expand All @@ -441,7 +429,7 @@ void L1TkMuonProducer::runOnMTFCollection_v1(const edm::Handle<RegionalMuonCandB
if (!pstate.valid)
continue;

float dr2prop = deltaR2(l1mu_eta, l1mu_phi, pstate.eta, pstate.phi);
float dr2prop = reco::deltaR2(l1mu_eta, l1mu_phi, pstate.eta, pstate.phi);
// FIXME: check if this matching procedure can be improved with
// a pT dependent dR window
if (dr2prop < drmin) {
Expand Down Expand Up @@ -497,7 +485,7 @@ void L1TkMuonProducer::runOnMTFCollection_v2(const edm::Handle<EMTFTrackCollecti
TkMuonCollection& tkMuons) const {
const EMTFTrackCollection& l1mus = (*muonH.product());
const L1TTTrackCollectionType& l1trks = (*l1tksH.product());
auto corr_mu_idxs = dwcorr_->find_match(l1mus, l1trks);
const auto& corr_mu_idxs = dwcorr_->find_match(l1mus, l1trks);
// it's a vector with as many entries as the L1TT vector.
// >= 0 : the idx in the EMTF vector of matched mu
// < 0: no match
Expand All @@ -508,7 +496,7 @@ void L1TkMuonProducer::runOnMTFCollection_v2(const edm::Handle<EMTFTrackCollecti
<< "the size of tkmu indices does not match the size of input trk collection\n";

for (uint il1ttrack = 0; il1ttrack < corr_mu_idxs.size(); ++il1ttrack) {
int emtf_idx = corr_mu_idxs.at(il1ttrack);
int emtf_idx = corr_mu_idxs[il1ttrack];
if (emtf_idx < 0)
continue;

Expand Down Expand Up @@ -584,10 +572,7 @@ L1TkMuonProducer::PropState L1TkMuonProducer::propagateToGMT(const L1TkMuonProdu
deta = deta * tanh(tk_eta);
}
float resPhi = tk_phi - 1.464 * tk_q * cosh(1.7) / cosh(etaProp) / tk_pt * dzCorrPhi - M_PI / 144.;
if (resPhi > M_PI)
resPhi -= 2. * M_PI;
if (resPhi < -M_PI)
resPhi += 2. * M_PI;
resPhi = reco::reduceRange(resPhi);

dest.eta = tk_eta + deta;
dest.phi = resPhi;
Expand All @@ -613,24 +598,24 @@ double L1TkMuonProducer::sigmaPhiTP(const RegionalMuonCand& mu) const { return 0

// ------------------------------------------------------------------------------------------------------------

std::vector<L1TkMuMantraDF::track_df> L1TkMuonProducer::product_to_trkvec(const L1TTTrackCollectionType& l1tks) {
std::vector<L1TkMuMantraDF::track_df> L1TkMuonProducer::product_to_trkvec(const L1TTTrackCollectionType& l1tks) const {
std::vector<L1TkMuMantraDF::track_df> result(l1tks.size());
for (uint itrk = 0; itrk < l1tks.size(); ++itrk) {
auto& trk = l1tks.at(itrk);

result.at(itrk).pt = trk.momentum().perp();
result.at(itrk).eta = trk.momentum().eta();
result.at(itrk).theta = L1TkMuMantra::to_mpio2_pio2(L1TkMuMantra::eta_to_theta(trk.momentum().eta()));
result.at(itrk).phi = trk.momentum().phi();
result.at(itrk).nstubs = trk.getStubRefs().size();
result.at(itrk).chi2 = trk.chi2();
result.at(itrk).charge = (trk.rInv() > 0 ? 1 : -1);
auto& trk = l1tks[itrk];

result[itrk].pt = trk.momentum().perp();
result[itrk].eta = trk.momentum().eta();
result[itrk].theta = L1TkMuMantra::to_mpio2_pio2(L1TkMuMantra::eta_to_theta(trk.momentum().eta()));
result[itrk].phi = trk.momentum().phi();
result[itrk].nstubs = trk.getStubRefs().size();
result[itrk].chi2 = trk.chi2();
result[itrk].charge = (trk.rInv() > 0 ? 1 : -1);
}

return result;
}

std::vector<L1TkMuMantraDF::muon_df> L1TkMuonProducer::product_to_muvec(const RegionalMuonCandBxCollection& l1mtfs) {
std::vector<L1TkMuMantraDF::muon_df> L1TkMuonProducer::product_to_muvec(const RegionalMuonCandBxCollection& l1mtfs) const {
std::vector<L1TkMuMantraDF::muon_df> result;
for (auto l1mu = l1mtfs.begin(0); l1mu != l1mtfs.end(0); ++l1mu) // considering BX = 0 only
{
Expand All @@ -646,15 +631,15 @@ std::vector<L1TkMuMantraDF::muon_df> L1TkMuonProducer::product_to_muvec(const Re
return result;
}

std::vector<L1TkMuMantraDF::muon_df> L1TkMuonProducer::product_to_muvec(const EMTFTrackCollection& l1mus) {
std::vector<L1TkMuMantraDF::muon_df> L1TkMuonProducer::product_to_muvec(const EMTFTrackCollection& l1mus) const {
std::vector<L1TkMuMantraDF::muon_df> result(l1mus.size());
for (uint imu = 0; imu < l1mus.size(); ++imu) {
auto& mu = l1mus.at(imu);
result.at(imu).pt = mu.Pt();
result.at(imu).eta = mu.Eta();
result.at(imu).theta = L1TkMuMantra::to_mpio2_pio2(L1TkMuMantra::eta_to_theta(mu.Eta()));
result.at(imu).phi = L1TkMuMantra::deg_to_rad(mu.Phi_glob());
result.at(imu).charge = mu.Charge();
auto& mu = l1mus[imu];
result[imu].pt = mu.Pt();
result[imu].eta = mu.Eta();
result[imu].theta = L1TkMuMantra::to_mpio2_pio2(L1TkMuMantra::eta_to_theta(mu.Eta()));
result[imu].phi = L1TkMuMantra::deg_to_rad(mu.Phi_glob());
result[imu].charge = mu.Charge();
}
return result;
}
Expand All @@ -665,36 +650,7 @@ void L1TkMuonProducer::build_tkMuons_from_idxs(TkMuonCollection& tkMuons,
const edm::Handle<RegionalMuonCandBxCollection>& muonH,
int detector) const {
for (uint imatch = 0; imatch < matches.size(); ++imatch) {
int match_trk_idx = matches.at(imatch);
if (match_trk_idx < 0)
continue; // this muon was not matched to any candidate

// take properties of the track
const L1TTTrackType& matchTk = (*l1tksH.product())[match_trk_idx];
const auto& p3 = matchTk.momentum();
const auto& tkv3 = matchTk.POCA();
float p4e = sqrt(mu_mass * mu_mass + p3.mag2());
math::XYZTLorentzVector l1tkp4(p3.x(), p3.y(), p3.z(), p4e);

edm::Ptr<L1TTTrackType> l1tkPtr(l1tksH, match_trk_idx);
edm::Ref<RegionalMuonCandBxCollection> l1muRef(muonH, imatch);

float trkisol = -999;
TkMuon l1tkmu(l1tkp4, l1muRef, l1tkPtr, trkisol);
l1tkmu.setTrackCurvature(matchTk.rInv());
l1tkmu.setTrkzVtx((float)tkv3.z());
l1tkmu.setMuonDetector(detector);
tkMuons.push_back(l1tkmu);
}
return;
}

void L1TkMuonProducer::build_tkMuons_from_idxs(TkMuonCollection& tkMuons,
const std::vector<int>& matches,
const edm::Handle<L1TTTrackCollectionType>& l1tksH,
int detector) const {
for (uint imatch = 0; imatch < matches.size(); ++imatch) {
int match_trk_idx = matches.at(imatch);
Comment on lines -668 to -697
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kpedro88 could you comment about this deletion? Thanks

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There were two functions that only differed by one line. Since a default-constructed edm::Handle is invalid, I unified the functions by checking if the corresponding argument is valid (a few lines below this). This reduces code duplication.

int match_trk_idx = matches[imatch];
if (match_trk_idx < 0)
continue; // this muon was not matched to any candidate

Expand All @@ -706,8 +662,7 @@ void L1TkMuonProducer::build_tkMuons_from_idxs(TkMuonCollection& tkMuons,
math::XYZTLorentzVector l1tkp4(p3.x(), p3.y(), p3.z(), p4e);

edm::Ptr<L1TTTrackType> l1tkPtr(l1tksH, match_trk_idx);
edm::Ref<RegionalMuonCandBxCollection>
l1muRef; // NOTE: this is the only difference from the function above, but could not find a way to make a conditional constructor
auto l1muRef = muonH.isValid() ? edm::Ref<RegionalMuonCandBxCollection>(muonH, imatch) : edm::Ref<RegionalMuonCandBxCollection>();

float trkisol = -999;
TkMuon l1tkmu(l1tkp4, l1muRef, l1tkPtr, trkisol);
Expand Down