added esConsumes to modules in RecoHGCal/TICL and related packages

[JamminJones]

PR description:

while adding esConsumes to the modules the RecHitTools class was modified to decouple EventSetup from it.

PR validation:

the code compiles

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31013/17487

• This PR adds an extra 68KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31013/17487/code-format.patch
  e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31013/17487/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31013/17496

• This PR adds an extra 72KB to repository

[cmsbuild]

A new Pull Request was created by @JamminJones for master.

It involves the following packages:

RecoEgamma/EgammaTools
RecoHGCal/TICL
RecoLocalCalo/HGCalRecAlgos
RecoLocalCalo/HGCalRecProducers
RecoParticleFlow/PFClusterProducer
SimCalorimetry/HGCalAssociatorProducers
Validation/HGCalValidation

@perrotta, @andrius-k, @kmaeshima, @civanch, @mdhildreth, @cmsbuild, @jfernan2, @fioriNTU, @slava77, @jpata, @kpedro88 can you please review it and eventually sign? Thanks.
@felicepantaleo, @jainshilpi, @argiro, @bsunanda, @pfs, @varuns23, @seemasharmafnal, @mmarionncern, @sethzenz, @lgray, @apsallid, @vandreev11, @Sam-Harper, @cbernet, @rovere, @cseez, @deguio, @hatakeyamak, @clelange, @rchatter, @riga, @edjtscott, @sobhatta, @lecriste, @afiqaize this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[civanch]

please test

[cmsbuild]

The tests are being triggered in jenkins.

• CMSSW_11_2_X_2020-08-01-1100/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/8492/console Started: 2020/08/01 19:07

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c8b0a3/8623/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 2 differences found in the comparisons
• DQMHistoTests: Total files compared: 35
• DQMHistoTests: Total histograms compared: 2612401
• DQMHistoTests: Total failures: 5
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 2612347
• DQMHistoTests: Total skipped: 48
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.004 KiB( 34 files compared)
• DQMHistoSizes: changed ( 10224.0 ): 0.004 KiB MessageLogger/Warnings
• Checked 149 log files, 22 edm output root files, 35 DQM output files

[kpedro88]

+upgrade

[jfernan2]

+1

[perrotta]

+1

• Technical
• Jenkins tests pass

[Dr15Jones]

@cms-sw/simulation-l2 ping

[civanch]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[silviodonato]

+1