Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SiPixelGenErrorDBObject payload inspector #31042

Merged
merged 4 commits into from Aug 4, 2020

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Aug 4, 2020

PR description:

This PR adds few payload inspector classes for the SiPixelGenErrorDBObject CondFormat.
In addition few improvements are implemented for the SiPixelTemplateDBObject one.
Unit tests are updated accordingly.

PR validation:

Relies on the existing and extended unit tests.
Example of output plot obtainable with these changes:

image

if this PR is a backport please specify the original PR and why you need to backport that PR:

This PR is not a backport, and no backport is needed.
cc:
@tvami

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 4, 2020

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 4, 2020

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31042/17541

  • This PR adds an extra 28KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 4, 2020

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

CondCore/SiPixelPlugins

@ggovi, @cmsbuild can you please review it and eventually sign? Thanks.
@mmusich, @dkotlins, @VinInn this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor Author

mmusich commented Aug 4, 2020

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 4, 2020

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 4, 2020

+1
Tested at: fe9543c
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6e9135/8541/summary.html
CMSSW: CMSSW_11_2_X_2020-08-03-2300
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 4, 2020

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 4, 2020

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6e9135/8541/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 2525448
  • DQMHistoTests: Total failures: 5
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 2525395
  • DQMHistoTests: Total skipped: 47
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.004 KiB( 33 files compared)
  • DQMHistoSizes: changed ( 10224.0 ): 0.004 KiB MessageLogger/Warnings
  • Checked 144 log files, 17 edm output root files, 34 DQM output files

@ggovi
Copy link
Contributor

ggovi commented Aug 4, 2020

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 4, 2020

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@silviodonato
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 5329789 into cms-sw:master Aug 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants