Adding an HLT filter for matching between PPS local tracks and central jet properties #31045

maaraujo94 · 2020-08-04T11:08:23Z

PR description:

This PR implements an HLT filter which requires the matching between the proton track information from the PPS detector and the jet properties from the central CMS detector.

The filter can require matching of mass+rapidity and/or of xi - fractional energy loss of the scattered proton.

PR validation:

Filter has been run on data and MC and has worked as expected. More information on tests done is shown here

if this PR is a backport please specify the original PR and why you need to backport that PR:

PR is not a backport.

cc: @fabferro @jjhollar @kshcheli @jan-kaspar

cmsbuild · 2020-08-04T11:08:49Z

The code-checks are being triggered in jenkins.

cmsbuild · 2020-08-04T11:14:43Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31045/17543

This PR adds an extra 20KB to repository
Found files with invalid states:
- HLTrigger/special/HLTPPSJetComparisonFilter.cc:
  - Added: 5a9f611
  - Modified: 909cd14
  - Deleted: cf3b00c
- HLTrigger/special/HLTPPSJetComparisonFilter.h:
  - Added: 5a9f611
  - Modified: 9c31cb4, 909cd14
  - Deleted: cf3b00c

cmsbuild · 2020-08-04T11:15:06Z

A new Pull Request was created by @maaraujo94 for master.

It involves the following packages:

HLTrigger/special

@cmsbuild, @Martin-Grunewald, @fwyzard can you please review it and eventually sign? Thanks.
@Martin-Grunewald this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

Martin-Grunewald · 2020-08-04T11:34:09Z

-1
Class name must be the same as file name and start with HLT... .
Header file not needed unless another cc file would need to include it.
Should use std::abs instead of abs
This filter does not use/does not inherit from / any HLTFilter functionality, so why does it have to be an HLTFilter in an HLT package?

cmsbuild · 2020-08-12T14:33:26Z

The code-checks are being triggered in jenkins.

maaraujo94 · 2020-08-12T14:34:08Z

The issues indicated have been corrected.
Regarding the last issue, I am not sure what is meant. We are using an EDFilter because the filter does not use HLTFilter functionality, following the advice given in a previous PR. We are submitting this filter as it is meant to be used in an HLT trigger proposal. If we should change from EDFilter to something else, of course we will be happy to change it.

cmsbuild · 2020-08-12T14:41:11Z

-code-checks

ERROR: Build errors found during clang-tidy run.

HLTrigger/special/plugins/HLTPPSJetComparisonFilter.cc:147:58: error: no member named 'getRPId' in 'CTPPSLocalTrackLite' [clang-diagnostic-error]
            (*proton.contributingLocalTracks().begin())->getRPId());  // get RP ID (rpId.arm() is 0 for 45 and 1 for 56)
                                                         ^
HLTrigger/special/plugins/HLTPPSJetComparisonFilter.cc:174:59: error: no member named 'getRPId' in 'CTPPSLocalTrackLite' [clang-diagnostic-error]
            (*proton1.contributingLocalTracks().begin())->getRPId());  // get RP ID (rpId.arm() is 0 for 45 and 1 for 56)
                                                          ^
HLTrigger/special/plugins/HLTPPSJetComparisonFilter.cc:181:78: error: no member named 'getRPId' in 'CTPPSLocalTrackLite' [clang-diagnostic-error]
              CTPPSDetId rpId2((*proton2.contributingLocalTracks().begin())->getRPId());
                                                                             ^
Suppressed 1529 warnings (1524 in non-user code, 4 NOLINT, 1 with check filters).
--
gmake: *** [config/SCRAM/GMake/Makefile.coderules:128: code-checks] Error 2
gmake: *** [There are compilation/build errors. Please see the detail log above.] Error 2

Martin-Grunewald · 2020-08-13T12:35:03Z

HLTrigger/special/plugins/HLTPPSJetComparisonFilter.cc

+  desc.add<bool>("do_xi", true)->setComment("flag to require xi matching");
+  desc.add<bool>("do_my", false)->setComment("flag to require m,y matching");
+
+  descriptions.add("hltCTPPSKinematicFilter", desc);


Should be descriptions.addWithDefaultLabel(desc);

cmsbuild · 2020-08-13T19:52:05Z

The code-checks are being triggered in jenkins.

cmsbuild · 2020-08-13T19:59:00Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31045/17748

This PR adds an extra 24KB to repository
Found files with invalid states:
- HLTrigger/special/HLTPPSJetComparisonFilter.cc:
  - Added: 5a9f611
  - Modified: 909cd14
  - Deleted: cf3b00c
- HLTrigger/special/HLTPPSJetComparisonFilter.h:
  - Added: 5a9f611
  - Modified: 9c31cb4, 909cd14
  - Deleted: cf3b00c
- HLTrigger/special/plugins/HLTPPSJetComparisonFilter.h:
  - Added: cf3b00c
  - Deleted: d3a88a5

cmsbuild · 2020-08-13T19:59:24Z

Pull request #31045 was updated. @cmsbuild, @Martin-Grunewald, @fwyzard can you please check and sign again.

Martin-Grunewald · 2020-08-14T04:26:00Z

please test

cmsbuild · 2020-08-14T04:26:23Z

The tests are being triggered in jenkins.

CMSSW_11_2_X_2020-08-13-2300/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/8751/console Started: 2020/08/14 06:28

cmsbuild · 2020-08-14T05:41:57Z

+1
Tested at: c1f7e49
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-df0fd7/8751/summary.html
CMSSW: CMSSW_11_2_X_2020-08-13-2300
SCRAM_ARCH: slc7_amd64_gcc820

cmsbuild · 2020-08-14T05:41:59Z

Comparison job queued.

Martin-Grunewald · 2020-08-14T06:31:11Z

+1

cmsbuild · 2020-08-14T06:31:35Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

cmsbuild · 2020-08-14T07:08:29Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-df0fd7/8751/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 35
DQMHistoTests: Total histograms compared: 2608246
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2608197
DQMHistoTests: Total skipped: 48
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
Checked 149 log files, 22 edm output root files, 35 DQM output files

qliphy · 2020-08-14T07:13:13Z

+1

maaraujo94 added 4 commits July 17, 2020 17:17

Added HLT filter for PPS track and jet kinematic matching

5a9f611

style changes to header file

9c31cb4

applied clang formatting

909cd14

moved files to correct directory

cf3b00c

cmsbuild added this to the CMSSW_11_2_X milestone Aug 4, 2020

cmsbuild added code-checks-pending comparison-pending hlt-pending orp-pending pending-signatures tests-pending labels Aug 4, 2020

cmsbuild added code-checks-approved and removed code-checks-pending labels Aug 4, 2020

cmsbuild added hlt-rejected and removed hlt-pending labels Aug 4, 2020

corrected class name; removed header file; replaced abs with std::abs

d3a88a5

cmsbuild added code-checks-pending hlt-pending and removed code-checks-approved hlt-rejected labels Aug 12, 2020

cmsbuild added code-checks-rejected and removed code-checks-pending labels Aug 12, 2020

corrected rPId() command; added LHCInfo.h directory to BuildFile

2ce58fb

Martin-Grunewald reviewed Aug 13, 2020

View reviewed changes

corrected descriptions.add() command

c1f7e49

cmsbuild added code-checks-pending and removed code-checks-approved labels Aug 13, 2020

cmsbuild added code-checks-approved and removed code-checks-pending labels Aug 13, 2020

cmsbuild added tests-started and removed tests-pending labels Aug 14, 2020

cmsbuild added tests-approved and removed tests-started labels Aug 14, 2020

cmsbuild added fully-signed hlt-approved and removed hlt-pending pending-signatures labels Aug 14, 2020

cmsbuild added comparison-available and removed comparison-pending labels Aug 14, 2020

cmsbuild added orp-approved and removed orp-pending labels Aug 14, 2020

cmsbuild merged commit ed643cb into cms-sw:master Aug 14, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adding an HLT filter for matching between PPS local tracks and central jet properties #31045

Adding an HLT filter for matching between PPS local tracks and central jet properties #31045

maaraujo94 commented Aug 4, 2020

cmsbuild commented Aug 4, 2020

cmsbuild commented Aug 4, 2020

cmsbuild commented Aug 4, 2020

Martin-Grunewald commented Aug 4, 2020

cmsbuild commented Aug 12, 2020

maaraujo94 commented Aug 12, 2020

cmsbuild commented Aug 12, 2020

Martin-Grunewald Aug 13, 2020

cmsbuild commented Aug 13, 2020

cmsbuild commented Aug 13, 2020

cmsbuild commented Aug 13, 2020

Martin-Grunewald commented Aug 14, 2020

cmsbuild commented Aug 14, 2020 •

edited

cmsbuild commented Aug 14, 2020

cmsbuild commented Aug 14, 2020

Martin-Grunewald commented Aug 14, 2020

cmsbuild commented Aug 14, 2020

cmsbuild commented Aug 14, 2020

qliphy commented Aug 14, 2020

Adding an HLT filter for matching between PPS local tracks and central jet properties #31045

Adding an HLT filter for matching between PPS local tracks and central jet properties #31045

Conversation

maaraujo94 commented Aug 4, 2020

PR description:

PR validation:

if this PR is a backport please specify the original PR and why you need to backport that PR:

cmsbuild commented Aug 4, 2020

cmsbuild commented Aug 4, 2020

cmsbuild commented Aug 4, 2020

Martin-Grunewald commented Aug 4, 2020

cmsbuild commented Aug 12, 2020

maaraujo94 commented Aug 12, 2020

cmsbuild commented Aug 12, 2020

Martin-Grunewald Aug 13, 2020

Choose a reason for hiding this comment

cmsbuild commented Aug 13, 2020

cmsbuild commented Aug 13, 2020

cmsbuild commented Aug 13, 2020

Martin-Grunewald commented Aug 14, 2020

cmsbuild commented Aug 14, 2020 • edited

cmsbuild commented Aug 14, 2020

cmsbuild commented Aug 14, 2020

Martin-Grunewald commented Aug 14, 2020

cmsbuild commented Aug 14, 2020

cmsbuild commented Aug 14, 2020

qliphy commented Aug 14, 2020

cmsbuild commented Aug 14, 2020 •

edited