Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing pair dictionaries in DataFormats/GEMDigi #31048

Merged
merged 1 commit into from Aug 5, 2020

Conversation

Dr15Jones
Copy link
Contributor

PR description:

DQM/Integration unit tests fail without these dictionaries.

PR validation:

The minimum failing configuration now is able to start processing where before it failed during startup.

DQM/Integration unit tests fail without these dictionaries.
@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 4, 2020

The code-checks are being triggered in jenkins.

@silviodonato
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 4, 2020

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31048/17550

  • This PR adds an extra 16KB to repository

  • There are other open Pull requests which might conflict with changes you have proposed:

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 4, 2020

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 4, 2020

A new Pull Request was created by @Dr15Jones (Chris Jones) for master.

It involves the following packages:

DataFormats/GEMDigi

@cmsbuild, @civanch, @kpedro88, @mdhildreth can you please review it and eventually sign? Thanks.
@jshlee, @dildick, @rovere this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@Dr15Jones
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 4, 2020

+1
Tested at: f613f7a
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4f703b/8561/summary.html
CMSSW: CMSSW_11_2_X_2020-08-04-1100
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 4, 2020

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 4, 2020

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4f703b/8561/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 8 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 2525448
  • DQMHistoTests: Total failures: 11
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 2525389
  • DQMHistoTests: Total skipped: 47
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.004 KiB( 33 files compared)
  • DQMHistoSizes: changed ( 10224.0 ): -0.004 KiB MessageLogger/Warnings
  • Checked 144 log files, 17 edm output root files, 34 DQM output files

@civanch
Copy link
Contributor

civanch commented Aug 5, 2020

+1

@Dr15Jones
Copy link
Contributor Author

ping @kpedro88

@kpedro88
Copy link
Contributor

kpedro88 commented Aug 5, 2020

+upgrade

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 5, 2020

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@silviodonato
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit a92e536 into cms-sw:master Aug 5, 2020
@Dr15Jones Dr15Jones deleted the fixDictDataFormatsGEMDigi branch August 28, 2020 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants