Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update comment about concurrency #31066

Merged
merged 2 commits into from Aug 12, 2020
Merged

update comment about concurrency #31066

merged 2 commits into from Aug 12, 2020

Conversation

wddgit
Copy link
Contributor

@wddgit wddgit commented Aug 5, 2020

PR description:

Update comments about concurrency. This only affects comments. None of the executable code is changed

PR validation:

Nothing should change.

@cmsbuild cmsbuild added this to the CMSSW_11_2_X milestone Aug 5, 2020
@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 5, 2020

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 5, 2020

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31066/17578

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 5, 2020

A new Pull Request was created by @wddgit (W. David Dagenhart) for master.

It involves the following packages:

CondCore/ESSources

@christopheralanwest, @tocheng, @cmsbuild, @tlampen, @ggovi, @pohsun can you please review it and eventually sign? Thanks.
@mmusich, @tocheng this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@wddgit
Copy link
Contributor Author

wddgit commented Aug 5, 2020

please test

FYI @makortel @Dr15Jones

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 5, 2020 •
edited

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 5, 2020

+1
Tested at: 34d4293
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-38e78b/8591/summary.html
CMSSW: CMSSW_11_2_X_2020-08-04-2300
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 5, 2020

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 5, 2020

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-38e78b/8591/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 35
  • DQMHistoTests: Total histograms compared: 2612401
  • DQMHistoTests: Total failures: 5
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 2612347
  • DQMHistoTests: Total skipped: 48
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.004 KiB( 34 files compared)
  • DQMHistoSizes: changed ( 10224.0 ): -0.004 KiB MessageLogger/Warnings
  • Checked 149 log files, 22 edm output root files, 35 DQM output files

@tlampen
Copy link
Contributor

tlampen commented Aug 6, 2020

+1

Dr15Jones
Dr15Jones reviewed Aug 6, 2020
View reviewed changes
CondCore/ESSources/plugins/CondDBESSource.h Outdated
// all related calls to DataProxy::initializeForNewIOV are made before
// another call to setIntervalFor is made. It is configurable how many
// 2. CondDBESSource contains a single SerialTaskQueue. The tasks
// that run the prefetch function are placed this SerialTaskQueue.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// that run the prefetch function are placed this SerialTaskQueue.
// that run the prefetch function are placed in this SerialTaskQueue.

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 6, 2020

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 6, 2020

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31066/17604

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 6, 2020

Pull request #31066 was updated. @christopheralanwest, @tocheng, @cmsbuild, @tlampen, @ggovi, @pohsun can you please check and sign again.

@wddgit
Copy link
Contributor Author

wddgit commented Aug 6, 2020

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 6, 2020 •
edited

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 6, 2020

+1
Tested at: d9d6f0c
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-38e78b/8618/summary.html
CMSSW: CMSSW_11_2_X_2020-08-06-1100
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 6, 2020

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 6, 2020

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-38e78b/8618/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 35
  • DQMHistoTests: Total histograms compared: 2612401
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2612352
  • DQMHistoTests: Total skipped: 48
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
  • Checked 149 log files, 22 edm output root files, 35 DQM output files

@pohsun
Copy link

pohsun commented Aug 9, 2020

+1

@ggovi
Copy link
Contributor

ggovi commented Aug 12, 2020

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Aug 12, 2020

+1

@cmsbuild cmsbuild merged commit d644e37 into cms-sw:master Aug 12, 2020
@wddgit wddgit deleted the updateComment branch September 24, 2020 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dr15Jones Dr15Jones Dr15Jones left review comments

Assignees
No one assigned
Labels
alca-approved code-checks-approved comparison-available db-approved fully-signed orp-approved tests-approved
Projects
None yet
Milestone
CMSSW_11_2_X
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@wddgit @cmsbuild @tlampen @pohsun @ggovi @qliphy @Dr15Jones