backporting of the Online ESProducer code for next MWGR

[gennai]

PR description:

This is a back porting of the code needed to test the ESProducer introduced in 11_2_x for the Run3 online beamspot workflow.

PR validation:

I have checked using the readOnlineBeamSpotFromDB.py under RecoVertex/BeamSpotProducer/test that I can read the payload created from the past MWGR as well as reading those in the GT after having converted them.

if this PR is a backport please specify the original PR and why you need to backport that PR:

original PR was: #30965
(already merged)

[cmsbuild]

A new Pull Request was created by @gennai (simone gennai) for CMSSW_11_1_X.

It involves the following packages:

CondFormats/DataRecord
RecoVertex/BeamSpotProducer

@perrotta, @slava77, @christopheralanwest, @tocheng, @cmsbuild, @jpata, @tlampen, @ggovi, @pohsun can you please review it and eventually sign? Thanks.
@makortel, @GiacomoSguazzoni, @JanFSchulte, @tocheng, @VinInn, @ebrondol, @rovere, @mmusich, @mtosi, @dgulhan, @seemasharmafnal this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[jpata]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.

• CMSSW_11_1_X_2020-08-06-1100/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/8613/console Started: 2020/08/06 15:25

[cmsbuild]

-1

Tested at: be77349

CMSSW: CMSSW_11_1_X_2020-08-06-1100
SCRAM_ARCH: slc7_amd64_gcc820
You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18cbba/8613/summary.html

I found follow errors while testing this PR

Failed tests: Build

• Build:

I found compilation error when building:

@@@@ Running edmWriteConfigs for AlcaBeamMonitor
--- Registered EDM Plugin: AlcaBeamMonitor
Entering library rule at src/DQM/BeamMonitor/plugins
>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_1_X_2020-08-06-1100/src/DQM/BeamMonitor/plugins/BeamSpotProblemMonitor.cc 
In file included from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_1_X_2020-08-06-1100/src/DQM/BeamMonitor/plugins/BeamSpotProblemMonitor.cc:17:
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_1_X_2020-08-06-1100/poison/RecoVertex/BeamSpotProducer/interface/BeamSpotOnlineProducer.h:1:2: error: #error THIS FILE HAS BEEN REMOVED FROM THE PACKAGE.
 #error THIS FILE HAS BEEN REMOVED FROM THE PACKAGE.
  ^~~~~
In file included from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_1_X_2020-08-06-1100/src/DQM/BeamMonitor/plugins/BeamSpotProblemMonitor.cc:17:
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_1_X_2020-08-06-1100/poison/RecoVertex/BeamSpotProducer/interface/BeamSpotOnlineProducer.h:1:2: error: #error THIS FILE HAS BEEN REMOVED FROM THE PACKAGE.
 #error THIS FILE HAS BEEN REMOVED FROM THE PACKAGE.


[cmsbuild]

Comparison not run due to Build errors (RelVals and Igprof tests were also skipped)

[gennai]

my bad, I will fix it when back from holidays

[cmsbuild]

Pull request #31076 was updated. @perrotta, @slava77, @christopheralanwest, @tocheng, @cmsbuild, @jpata, @tlampen, @ggovi, @pohsun can you please check and sign again.

[gennai]

This latest commit has reverted the online producers (which should not have touched, I did it by mistake).
Now the file modified are the same as the original PR

[jpata]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.

• CMSSW_11_1_X_2020-08-06-1100/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/8630/console Started: 2020/08/06 20:40

[cmsbuild]

+1
Tested at: 418072f
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18cbba/8630/summary.html
CMSSW: CMSSW_11_1_X_2020-08-06-1100
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18cbba/8630/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

• /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-18cbba/23234.1001_TTbar_14TeV+RecoFullGlobal_TestOldDigi_2026D49+HARVESTFullGlobal_2026D49

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 36
• DQMHistoTests: Total histograms compared: 2780792
• DQMHistoTests: Total failures: 2
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2780740
• DQMHistoTests: Total skipped: 50
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 35 files compared)
• Checked 152 log files, 16 edm output root files, 36 DQM output files

[silviodonato]

@cms-sw/alca-l2 @cms-sw/db-l2 @cms-sw/reconstruction-l2 this PR is needed for the next MWGR

[tlampen]

+1

[jpata]

+1

• tests pass
• is a backport of Online BeamSpot ESProducer for Run3 workflow #30965 and brings in only the needed changes

[ggovi]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_11_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1