SimTracker/TrackerMaterialAnalysis Unit test

[vargasa]

PR description:

Add Unit Test to keep track of changes in Geometry Files

PR validation:

./genTrackerPlots.sh should now do the work, and if everything runs smoothly and things haven't changed since the last time I wrote one of these, we should be able to see directly the plots from @cmsbuild output

@mtosi, @mmusich as discussed earlier today

[cmsbuild]

The code-checks are being triggered in jenkins.

[mmusich]

@cmsbuild, please test

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31083/17622

• This PR adds an extra 16KB to repository

[cmsbuild]

The tests are being triggered in jenkins.

• CMSSW_11_2_X_2020-08-06-1100/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/8638/console Started: 2020/08/06 23:15

[cmsbuild]

A new Pull Request was created by @vargasa (Andres Vargas) for master.

It involves the following packages:

SimTracker/TrackerMaterialAnalysis

@cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks.
@makortel, @mtosi, @GiacomoSguazzoni, @JanFSchulte, @rovere, @VinInn, @apsallid, @ebrondol, @threus, @dgulhan this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[mmusich]

part of #31068

[cmsbuild]

+1
Tested at: 6720b9a
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12fbca/8638/summary.html
CMSSW: CMSSW_11_2_X_2020-08-06-1100
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12fbca/8638/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 6 differences found in the comparisons
• DQMHistoTests: Total files compared: 35
• DQMHistoTests: Total histograms compared: 2612401
• DQMHistoTests: Total failures: 11
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 2612341
• DQMHistoTests: Total skipped: 48
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.004 KiB( 34 files compared)
• DQMHistoSizes: changed ( 10224.0 ): 0.004 KiB MessageLogger/Warnings
• Checked 149 log files, 22 edm output root files, 35 DQM output files

[mmusich]

@vargasa
thanks for the clean-up. I have few comments below.

[civanch]

@vargasa , I am sorry, for me many lines with "see comment above" is a problem - it is not clear if concerns are still not addressed or should not be addressed.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31083/17653

• This PR adds an extra 16KB to repository

• Found files with invalid states:

  • SimTracker/TrackerMaterialAnalysis/test/listIds.py:
    • Deleted: e20bc57
    • Added: b1e7fc1

[cmsbuild]

Pull request #31083 was updated. @cmsbuild, @civanch, @mdhildreth can you please check and sign again.

[mmusich]

please test

[cmsbuild]

The tests are being triggered in jenkins.

• CMSSW_11_2_X_2020-08-07-2300/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/8669/console Started: 2020/08/08 12:05

[cmsbuild]

+1
Tested at: 595bccc
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12fbca/8669/summary.html
CMSSW: CMSSW_11_2_X_2020-08-07-2300
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[vargasa]

Hello @mtosi, the plots can be found here, Can you take a look at those please? I know they may be a bit harder to read as the unit test takes 1k instead of 200k events but if you can point out some obvious discrepancies from the ones you have seen before would be very useful. @mmusich as for the unit test, this should be good to go now

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12fbca/8669/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 35
• DQMHistoTests: Total histograms compared: 2612401
• DQMHistoTests: Total failures: 7
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2612346
• DQMHistoTests: Total skipped: 48
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
• Checked 149 log files, 22 edm output root files, 35 DQM output files

[mtosi]

ciao, thanks for the update, I confirm plots are similar to the ones I got.
Energy Loss spectrum plots would need an adjustment of the x-axis range (but I think it is not related to your code update)

[civanch]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[silviodonato]

+1