Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop obsolete condDBv2 files #31127

Merged
merged 4 commits into from Aug 26, 2020

Conversation

fwyzard
Copy link
Contributor

@fwyzard fwyzard commented Aug 12, 2020

PR description:

Delete the obsolete files for "condDBv2", and update the configurations that were still using them.

PR validation:

None.

@fwyzard
Copy link
Contributor Author

fwyzard commented Aug 12, 2020

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31127/17719

  • This PR adds an extra 36KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 12, 2020

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @fwyzard (Andrea Bocci) for master.

It involves the following packages:

CalibTracker/SiPixelConnectivity
Calibration/HcalAlCaRecoProducers
CondTools/SiPixel
Configuration/AlCa
L1Trigger/GlobalTriggerAnalyzer
L1Trigger/L1TNtuples

@benkrikler, @christopheralanwest, @tocheng, @cmsbuild, @rekovic, @tlampen, @ggovi, @pohsun can you please review it and eventually sign? Thanks.
@kreczko, @makortel, @tocheng, @VinInn, @Martin-Grunewald, @dkotlins, @thomreis, @mmusich, @fabiocos this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@@ -14,7 +14,7 @@

#hptopo
process.load("Configuration.StandardSequences.FrontierConditions_GlobalTag_condDBv2_cff")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since you are at it, you might as well drop this other obsolete piece:
https://github.com/cms-sw/cmssw/blob/master/Configuration/StandardSequences/python/FrontierConditions_GlobalTag_condDBv2_cff.py

which just does:

from Configuration.StandardSequences.FrontierConditions_GlobalTag_cff import *

@Martin-Grunewald
Copy link
Contributor

+1

@tlampen
Copy link
Contributor

tlampen commented Aug 13, 2020

+1

@civanch
Copy link
Contributor

civanch commented Aug 16, 2020

+1

@santocch
Copy link

+1

@silviodonato
Copy link
Contributor

+operations

@silviodonato
Copy link
Contributor

kind reminder @cms-sw/db-l2 @cms-sw/generators-l2 @cms-sw/l1-l2

@fwyzard
Copy link
Contributor Author

fwyzard commented Aug 24, 2020

just ignore them and merge ?

@qliphy
Copy link
Contributor

qliphy commented Aug 24, 2020

+generators

@ggovi
Copy link
Contributor

ggovi commented Aug 25, 2020

+1

@silviodonato
Copy link
Contributor

merge
@cms-sw/l1-l2

@cmsbuild cmsbuild merged commit 3c9563b into cms-sw:master Aug 26, 2020
@fwyzard fwyzard deleted the drop_obsolete_autoCond_condDBv2 branch August 18, 2021 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment