Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refine RuInfo payload inspector #31128

Merged
merged 5 commits into from Aug 18, 2020
Merged

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Aug 12, 2020

PR description:

The goal of this PR is two-fold

  1. first: is to improve the graphical appearance of the output of the RunInfoParameters plotting class. This now contains human readable run start and end times as well as small descriptor if the payload is valid, invalid or fake.
  2. second: at the moment, the trend plots of values vs run-number (e.g. RunInfoBFieldHistory) are polluted by fake payloads which in production are interposed between valid ones. In order to discard them in plotting a hack in CondCore/Utilities/interface/PayloadInspector.h has been introduced in order to treat the case in which the return type of getFromPayload is a std::pair<bool, float>, where the boolean stores the information whether the payload is fake or not.

PR validation:

This a graphical display with this script of the output of running the command:

getPayloadData.py --plugin pluginRunInfo_PayloadInspector --plot plot_RunInfoBFieldHistory --tag runinfo_31X_hlt --time_type Run --iovs '{"start_iov": "312000", "end_iov": "312260"}' --db Prod --test ;

with this branch and the master branch, showing how the fake payloads are epurated.

comparison_masterbranch_vs_thisPR_json

if this PR is a backport please specify the original PR and why you need to backport that PR:

This PR is not a backport and no backport is needed.

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31128/17721

  • This PR adds an extra 24KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

CondCore/RunInfoPlugins
CondCore/Utilities

@ggovi, @cmsbuild can you please review it and eventually sign? Thanks.
@mmusich this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor Author

mmusich commented Aug 12, 2020

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 12, 2020

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+1
Tested at: 3cf29b1
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7c76f2/8732/summary.html
CMSSW: CMSSW_11_2_X_2020-08-12-1100
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7c76f2/8732/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 35
  • DQMHistoTests: Total histograms compared: 2612401
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2612352
  • DQMHistoTests: Total skipped: 48
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
  • Checked 149 log files, 22 edm output root files, 35 DQM output files

@ggovi
Copy link
Contributor

ggovi commented Aug 18, 2020

+1

@mmusich
Copy link
Contributor Author

mmusich commented Aug 18, 2020

@cmsbuild ping?

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Aug 18, 2020

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants