New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refine RuInfo payload inspector #31128
Conversation
…nInfo time trends
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31128/17721
|
A new Pull Request was created by @mmusich (Marco Musich) for master. It involves the following packages: CondCore/RunInfoPlugins @ggovi, @cmsbuild can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild, please test |
The tests are being triggered in jenkins.
|
+1 |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
@cmsbuild ping? |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
The goal of this PR is two-fold
RunInfoParameters
plotting class. This now contains human readable run start and end times as well as small descriptor if the payload is valid, invalid or fake.RunInfoBFieldHistory
) are polluted by fake payloads which in production are interposed between valid ones. In order to discard them in plotting a hack inCondCore/Utilities/interface/PayloadInspector.h
has been introduced in order to treat the case in which the return type ofgetFromPayload
is astd::pair<bool, float>
, where the boolean stores the information whether the payload is fake or not.PR validation:
This a graphical display with this script of the output of running the command:
with this branch and the master branch, showing how the fake payloads are epurated.
if this PR is a backport please specify the original PR and why you need to backport that PR:
This PR is not a backport and no backport is needed.