New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move "wmsplit" dict build to a static method, remove circular import (backport to 11_1_X) #31137
Move "wmsplit" dict build to a static method, remove circular import (backport to 11_1_X) #31137
Conversation
A new Pull Request was created by @justinasr (Justinas Rumeviius) for CMSSW_11_1_X. It involves the following packages: Configuration/PyReleaseValidation @chayanit, @cmsbuild, @wajidalikhan, @kpedro88, @jordan-martins can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
backport of #31122 |
please test |
The tests are being triggered in jenkins.
|
+1 |
Comparison job queued. |
Comparison is ready @slava77 comparisons for the following workflows were not done due to missing matrix map:
Comparison Summary:
|
+1 |
+upgrade |
This pull request is fully signed and it will be integrated in one of the next CMSSW_11_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
Same as #31122
PR validation:
Ran runTheMatrix.py with commented-out submission to computing and added prints to see if values are picked up from the moved "wmsplit" dictionary. Code did not crash and print statements printed expected values from "wmsplit".
if this PR is a backport please specify the original PR and why you need to backport that PR:
This is a backport of #31122
This is needed for the currently developed RelVal machine by PdmV.