New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove boost::phoenix dependency #31150
Conversation
In this case we can use std::bind instead of phoenix.
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31150/17772
|
A new Pull Request was created by @camolezi (Lucas Camolezi) for master. It involves the following packages: FWCore/Modules @makortel, @smuzaffar, @cmsbuild, @Dr15Jones can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test
On 15 Aug 2020, at 16:08, cmsbuild <notifications@github.com> wrote:
A new Pull Request was created by @camolezi<https://github.com/camolezi> (Lucas Camolezi) for master.
It involves the following packages:
FWCore/Modules
@makortel<https://github.com/makortel>, @smuzaffar<https://github.com/smuzaffar>, @cmsbuild<https://github.com/cmsbuild>, @Dr15Jones<https://github.com/Dr15Jones> can you please review it and eventually sign? Thanks.
@makortel<https://github.com/makortel>, @wddgit<https://github.com/wddgit> this is something you requested to watch as well.
@silviodonato<https://github.com/silviodonato>, @dpiparo<https://github.com/dpiparo>, @qliphy<https://github.com/qliphy> you are the release manager for this.
cms-bot commands are listed here<http://cms-sw.github.io/cms-bot-cmssw-cmds.html>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#31150 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ABGPFQ74BMCYWZFZH6UKDF3SA2JBNANCNFSM4QAJE6QA>.
|
The tests are being triggered in jenkins.
|
+1 |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
In this case we can use std::bind instead of phoenix::bind
PR validation:
Passed on basic runTheMatrix test.
if this PR is a backport please specify the original PR and why you need to backport that PR:
@vgvassilev @davidlange6