Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DetIdSelector in SiStripBaseCondObjDQM.cc #312

Merged
merged 6 commits into from Aug 23, 2013

Conversation

mtosi
Copy link
Contributor

@mtosi mtosi commented Aug 14, 2013

rolled back standard C++ "&&" and "||"
plus the adjustment of the input parameters name [modulesToBeIncluded --> ModulesToBeIncluded_DetIdSelector and modulesToBeExcluded --> ModulesToBeExcluded_DetIdSelector]

@mtosi mtosi mentioned this pull request Aug 14, 2013
@ghost ghost assigned deguio Aug 14, 2013
@nclopezo
Copy link
Contributor

Hi,

I took these changes on top of CMSSW_7_0_X_2013-08-13-1400, I ran the unit tests and RelVals, all tests passed.

You can see the logs here:

https://cmssdt.cern.ch/jenkins/job/Pull-Request-Integration/ARCHITECTURE=slc5_amd64_gcc472/99/console

@ktf
Copy link
Contributor

ktf commented Aug 14, 2013

@deguio @rovere can you sign this?

@cmsbuild
Copy link
Contributor

The following categories have been signed by @deguio: DQM

@cms-git-dqm

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IBs unless changes.

ktf added a commit that referenced this pull request Aug 23, 2013
…rNEW2

DetIdSelector in SiStripBaseCondObjDQM.cc
@ktf ktf merged commit 7dd05d1 into cms-sw:CMSSW_7_0_X Aug 23, 2013
makortel pushed a commit to makortel/cmssw that referenced this pull request Apr 22, 2015
Seyoung-Han pushed a commit to Seyoung-Han/cmssw that referenced this pull request May 13, 2021
slava77 pushed a commit to slava77/cmssw that referenced this pull request Oct 9, 2021
Hit selection windows for multi-iteration MkFit
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants