Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix for JMENano backport PR #31124 #31207

Merged
merged 1 commit into from Aug 24, 2020

Conversation

nurfikri89
Copy link
Contributor

PR description:

This fixes a silly mistake that was left behind for Custom JME NanoAODs in PR #31124 (which was a backport of #30674). My apologies.

if this PR is a backport please specify the original PR:

This is a fix for a backport, #31124.

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 21, 2020

A new Pull Request was created by @nurfikri89 (Nurfikri Norjoharuddeen) for CMSSW_10_6_X.

It involves the following packages:

PhysicsTools/NanoAOD

@gouskos, @cmsbuild, @fgolf, @mariadalfonso, @santocch, @peruzzim can you please review it and eventually sign? Thanks.
@gpetruc this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@mariadalfonso
Copy link
Contributor

please test workflow 1325.6,1325.7,1325.8,1329.1,136.7722,136.7952,136.8521,10224.15,11024.15

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 21, 2020

The tests are being triggered in jenkins.
Test Parameters:

@mariadalfonso
Copy link
Contributor

backport #31124

@mariadalfonso
Copy link
Contributor

mariadalfonso commented Aug 21, 2020

type bug-fix

@mariadalfonso
Copy link
Contributor

@nurfikri89 edit the title such that the "JMEnano" appear

@cmsbuild
Copy link
Contributor

+1
Tested at: e4dec9a
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3863cd/8859/summary.html
CMSSW: CMSSW_10_6_X_2020-08-21-1100
SCRAM_ARCH: slc7_amd64_gcc700

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3863cd/8859/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3863cd/8859/git-merge-result

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3863cd/8859/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 3214674
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3214338
  • DQMHistoTests: Total skipped: 334
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
  • Checked 140 log files, 14 edm output root files, 34 DQM output files

@nurfikri89 nurfikri89 changed the title Bugfix for backport PR #31124 Bugfix for JMENano backport PR #31124 Aug 22, 2020
@mariadalfonso
Copy link
Contributor

+xpog
this PR complete the backport regarding JMEnano only.
central Nano are not expected/seen to be affected

@silviodonato
Copy link
Contributor

merge
@cms-sw/analysis-l2

@cmsbuild cmsbuild merged commit 5a00285 into cms-sw:CMSSW_10_6_X Aug 24, 2020
@santocch
Copy link

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_6_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_2_X is complete. This pull request will be automatically merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants