Turn on dual slope ToT in phase-2 pixels digitizer and clusterizer and update CPE payloads to match

[OzAmram]

This pull request turns on the 'dual-slope' configuration of the phase 2 pixel electronics simulation, and changes the Q/ToT settings from 600e to 1500e and the threshhold from 1200e to 1000e.

To match these changes GenErrors and Templates were made for the T21 and T22 geometries, and these are being activated as well. The 'generic reco only' configuration of the T22 geoemtry is turned off as well now that the necessary payloads exist.

The performance of these new payloads in local reconstruction were tested and look good.

Tracking validation was also run with the new changes using 100 TTbar events without pileup for both the T21 and T22 geometries (workflows 29034 and 29434). They show only minor differences as expected.

These tests are summarized in slides here.

@mmusich @tsusa @emiglior @cmantill @mtosi @tvami @pmaksim1 @JanFSchulte @jalimena @perrotta @slava77

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31253/17916

• This PR adds an extra 32KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File RecoLocalTracker/SiPixelClusterizer/python/SiPixelClusterizer_cfi.py modified in PR(s): Squash all Patatrack developments on top of CMSSW_11_3_0_pre5 #27983

[cmsbuild]

A new Pull Request was created by @OzAmram (Oz Amram) for master.

It involves the following packages:

Configuration/AlCa
Configuration/PyReleaseValidation
RecoLocalTracker/SiPixelClusterizer
SimTracker/SiPhase2Digitizer

@perrotta, @civanch, @jordan-martins, @chayanit, @wajidalikhan, @slava77, @christopheralanwest, @mdhildreth, @cmsbuild, @tocheng, @tlampen, @jpata, @pohsun, @kpedro88 can you please review it and eventually sign? Thanks.
@fabiocos, @makortel, @felicepantaleo, @GiacomoSguazzoni, @JanFSchulte, @tocheng, @VinInn, @Martin-Grunewald, @dkotlins, @ebrondol, @rovere, @threus, @gpetruc, @mmusich, @mtosi, @dgulhan, @slomeo this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[slava77]

@cmsbuild please test workflow 29034.0,29434.0

[cmsbuild]

The tests are being triggered in jenkins.
Test Parameters:

• MATRIX_EXTRAS = 29434.0,29034.0
• CMSSW_11_2_X_2020-08-25-2300/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/8938/console Started: 2020/08/26 19:24

[cmsbuild]

+1
Tested at: 0cfe9f7
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ca28e1/8938/summary.html
CMSSW: CMSSW_11_2_X_2020-08-25-2300
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ca28e1/8938/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

• /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-ca28e1/29034.0_TTbar_14TeV+2026D62+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14+DigiTrigger+RecoGlobal+HARVESTGlobal
• /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-ca28e1/29434.0_TTbar_14TeV+2026D63+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14+DigiTrigger+RecoGlobal+HARVESTGlobal

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 5156 differences found in the comparisons
• DQMHistoTests: Total files compared: 35
• DQMHistoTests: Total histograms compared: 2609656
• DQMHistoTests: Total failures: 64398
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2545236
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
• Checked 149 log files, 22 edm output root files, 35 DQM output files

[kpedro88]

+upgrade
changes limited to Phase 2 workflows, arising from differences in the tracking
tracking performance is expected to be similar; see e.g. only minor fluctuations in general track pT and PF candidate pT:

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ca28e1/9031/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 5315 differences found in the comparisons
• DQMHistoTests: Total files compared: 35
• DQMHistoTests: Total histograms compared: 2609667
• DQMHistoTests: Total failures: 62528
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2547117
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
• Checked 149 log files, 22 edm output root files, 35 DQM output files

[jpata]

+reconstruction

• updates phase 2 tracking with the dual-slope configuration, includes also a bugfix in PixelThresholdClusterizer.cc
• there are a large number of minute differences from changes to tracking, but the overall tracking performance has not changed, as validated on workflows 29034.0 and 29434.0, slides have been attached to a recent Tracker DPG agenda
• the configuration values in SiPixelClusterizer_cfi.py are now loaded from phase2TrackerDigitizer_cfi.py

[tlampen]

+1

[civanch]

+1

[mmusich]

@cms-sw/pdmv-l2 @cms-sw/upgrade-l2 any further comment?

[mmusich]

@kpedro88 @chayanit any further comment on this PR? Thank you.

[kpedro88]

+upgrade

[chayanit]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1