Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PY3] Remove release check condition to fix unit test #31262

Merged
merged 1 commit into from Sep 2, 2020

Conversation

mrodozov
Copy link
Contributor

@mrodozov mrodozov commented Aug 27, 2020

PR description:

Removing the PY3 release condition made the unit test start working.
Found it by chance removing conditions from the the BuildFile

PR validation:

The test https://cmssdt.cern.ch/SDT/cgi-bin/logreader/slc7_amd64_gcc820/CMSSW_11_2_PY3_X_2020-08-26-2300/unitTestLogs/CondCore/BeamSpotPlugins#/
is running under the PY3 IB after the change

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@mrodozov
Copy link
Contributor Author

test parameters:

  • release_queue=CMSSW_11_2_PY3_X

@mrodozov
Copy link
Contributor Author

please test

@mrodozov mrodozov changed the title Remove release check condition to fix unit test [PY3] Remove release check condition to fix unit test Aug 27, 2020
@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31262/17934

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 27, 2020

The tests are being triggered in jenkins.
Test Parameters:

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mrodozov (Mircho Rodozov) for master.

It involves the following packages:

CondCore/BeamSpotPlugins

@ggovi, @cmsbuild can you please review it and eventually sign? Thanks.
@mmusich this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

+1
Tested at: b08389c
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c4da6b/8955/summary.html
CMSSW: CMSSW_11_2_PY3_X_2020-08-26-2300
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c4da6b/8955/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4183 differences found in the comparisons
  • DQMHistoTests: Total files compared: 35
  • DQMHistoTests: Total histograms compared: 2611207
  • DQMHistoTests: Total failures: 782
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 2610424
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.004 KiB( 34 files compared)
  • DQMHistoSizes: changed ( 10224.0 ): 0.004 KiB MessageLogger/Warnings
  • Checked 149 log files, 22 edm output root files, 35 DQM output files

@ggovi
Copy link
Contributor

ggovi commented Sep 2, 2020

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 2, 2020

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@silviodonato
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 25cc96a into cms-sw:master Sep 2, 2020
@silviodonato
Copy link
Contributor

test parameters:

  • release_queue=CMSSW_11_2_X

@silviodonato
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 2, 2020

The tests are being triggered in jenkins.
Test Parameters:

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 2, 2020

+1
Tested at: b08389c
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c4da6b/9070/summary.html
CMSSW: CMSSW_11_2_X_2020-09-01-2300
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 2, 2020

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 2, 2020

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c4da6b/9070/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 35
  • DQMHistoTests: Total histograms compared: 2609667
  • DQMHistoTests: Total failures: 5
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 2609639
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.004 KiB( 34 files compared)
  • DQMHistoSizes: changed ( 10224.0 ): 0.004 KiB MessageLogger/Warnings
  • Checked 149 log files, 22 edm output root files, 35 DQM output files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants