New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PY3] Remove release check condition to fix unit test #31262
Conversation
The code-checks are being triggered in jenkins. |
test parameters:
|
please test |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31262/17934
|
The tests are being triggered in jenkins.
|
A new Pull Request was created by @mrodozov (Mircho Rodozov) for master. It involves the following packages: CondCore/BeamSpotPlugins @ggovi, @cmsbuild can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
+1 |
Comparison is ready Comparison Summary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
test parameters:
|
please test |
The tests are being triggered in jenkins.
|
+1 |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
PR description:
Removing the PY3 release condition made the unit test start working.
Found it by chance removing conditions from the the BuildFile
PR validation:
The test https://cmssdt.cern.ch/SDT/cgi-bin/logreader/slc7_amd64_gcc820/CMSSW_11_2_PY3_X_2020-08-26-2300/unitTestLogs/CondCore/BeamSpotPlugins#/
is running under the PY3 IB after the change