Fixed generator/Geant4 interface for PPS

[civanch]

PR description:

Generator/Geant4 interface is fixed:

1. for non-central particles (cosmic and protons after Hector transport) filter is not applied. As a results of Hector
   transport scattered protons moved to from IR to PPS station and Geant4 get these protons in front of PPS or ZDC. Actual implementation of Hector transport is outside this PR, here only interface is provided
2. n, nbar, gamma with direction along beam pipe eta cut is not applied in order to allow them fly forward to ZDC
3. code format and printout format
   These modifications are needed for PPS simulation. Due to change in very forward direction simulation histories are affected, so no regression is expected

PR validation:

private

if this PR is a backport please specify the original PR and why you need to backport that PR: not now

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31270/17951

• This PR adds an extra 16KB to repository

[cmsbuild]

A new Pull Request was created by @civanch (Vladimir Ivantchenko) for master.

It involves the following packages:

SimG4Core/Generators

@cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks.
@makortel, @rovere, @fabiocos, @slomeo this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[civanch]

please test

[cmsbuild]

The tests are being triggered in jenkins.

• CMSSW_11_2_X_2020-08-27-1100/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/8968/console Started: 2020/08/27 23:59

[civanch]

@mundim , please, try this out.

[cmsbuild]

+1
Tested at: d097571
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-83a51e/8968/summary.html
CMSSW: CMSSW_11_2_X_2020-08-27-1100
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-83a51e/8968/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 37747 differences found in the comparisons
• DQMHistoTests: Total files compared: 35
• DQMHistoTests: Total histograms compared: 2609667
• DQMHistoTests: Total failures: 371887
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 2237757
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.635 KiB( 34 files compared)
• DQMHistoSizes: changed ( 10224.0 ): 0.352 KiB SiStrip/MechanicalView
• DQMHistoSizes: changed ( 250202.181 ): 0.342 KiB SiStrip/MechanicalView
• DQMHistoSizes: changed ( 25202.0 ): -0.059 KiB SiStrip/MechanicalView
• Checked 149 log files, 22 edm output root files, 35 DQM output files

[civanch]

+1

differences are expected

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1

[silviodonato]

+1

differences are expected

@civanch could you spend some words about the expected differences (it might be useful also for the future validation of 11_2_0_pre6 @cms-sw/pdmv-l2 )? Are they expected only at large eta? I see many plots changed. Thank you

[civanch]

@silviodonato , I have extended the description. plots changed due to change of histories.

[silviodonato]

Thanks @civanch. If I understand correctly, we expect changes only in simulated objects because the simulation is extended up to PPS/ZDC and the history changes.
So why do we see changes even in central reconstructed objects (eg. eta distribution or reco tracks [1]) ?
I suspect I'm missing some points...

[1] https://cmssdt.cern.ch/SDT/jenkins-artifacts/baseLineComparisons/CMSSW_11_2_X_2020-08-27-1100+83a51e/38518/validateJR/all_OldVSNew_Higgs200ChargedTauswf9p0/all_OldVSNew_Higgs200ChargedTauswf9p0c_recoTracks_generalTracks__RECO_obj_eta.png

[civanch]

@silviodonato , unfortunately when we spend few or less random numbers in some event, then the history in the next event may be completely different. I see statistical agreement in this plot but no regression.